[Resolved] script problem

tuf-web_co_uk

can anyone tell me why this doesnt work please

for some reason if the url is ?mode=newpass nothing shows up
and when the url is ?mode=style or ?mode=info it shows what should have been shown for ?mode=newpass

http://www.theutherfish.com/users/txtindex.txt

thanks Jon

OhLordy

Post likely a problem in your logic. Please post your code.
Rob

edit:
Sorry :rolleyes: didn't look at the link.

tuf-web_co_uk

should of put it as an attachment sorry

OhLordy

Try putting echo($_GET['mode']); at the start of your script and then echo some data just after every relevent conditional statement. That will let you know exactly where your script is going awry.
HTH
Rob

tuf-web_co_uk

hey

i changed my code to what you said, echo out $_GET[mode] and add some info to certain sections
like below

and when i viewed the page they brought back the relevant data, so i'm thinking there is something wrong with my if and else statements

i'll get back to you when i've tried again if i need anymore help

thanks

<?
echo ($_GET['mode']);

if ($_GET['mode']) {

// START OF NEWPASS
if ($_GET['mode'] == 'newpass') {

echo "this is newpass";

}
// END OF NEWPASS

// START OF INFO
else if ($_GET['mode'] == 'info') {

echo "this is info panel";

}
// END OF INFO

// START OF STYLE	
else if ($_GET['mode'] == 'style') {

echo "this is style panel";

}
// END OF STYLE

}
?>

Jon 🙂

stolzyboy

i cut and pasted your code to test it quick and the if's in that last snippet worked just fine

it may have something to do with your isset($submit) once you are in the if's though

maybe try

if (isset($_POST['submit'])

instead

tuf-web_co_uk

hey again

(isset($_POST['submit']) needs an extra ) at the end but i knew what you meant

and it still doesnt work 🙁

index.php?mode=newpass - shows nothing
index.php?mode=info - shows password page
index.php?mode=style - shows password page

if its not my if statements what could it be?!

thanks again, Jon

stolzyboy

do you have register_globals on or off

tuf-web_co_uk

i just checked my php info and they are on

stolzyboy

well i guess its time to debug some more

after all your isset submit's just simply echo something like
"in submit for newpass" and make it different for each one

then if you get into that if, do the same where you are checking for !password etc...

that will lead you down to what if's are/aren't working

keep doing that to make sure your if/else conditions are the
way you want them

i think you have the general idea, its just you have bugs and until
you learn HOW to debug, you will always be frustrated

once you get debugging down, you will like this programming business much more and it will flow in your mind better

tuf-web_co_uk

thanks very much, i'll take your advice 😃

Jon 😉

tuf-web_co_uk

well i have kinda found the problem it seems it something along the lines of my else statement

<?
if ($_GET['mode']) {

// START OF NEWPASS
if ($_GET['mode'] == 'newpass') {
	echo "newpassmode<br>";
	// START OF ISSET($_POST['SUBMIT'])
	if (isset($_POST['submit'])) {
	echo "newpasssubmitmode";
		// NOT ALL THINGS NEED EXIST
		if (!$oldpassword || !$password || !$password2) {

		echo "you have not entered all of the details needed to change your password";
		echo "<br>please try again";
		echo "<br><br><a href=javascript:history.back();>back</a>";

		}

		// EVERYTHING EXISTS
		else {

		// FIND USER
		$sql = "SELECT * from custom WHERE username='".$_COOKIE[user]."' AND password=MD5('$oldpassword')";
		$query = mysql_query($sql) or die("could not select records");
		$number = mysql_num_rows($query);

			// IF USER AND PASSWORD COMBO DOESNT EXIST
			if ($number != '1') {

			echo "password entered does not match password in database";
			echo "<br>please try again";
			echo "<br><br><a href=javascript:history.back();>back</a>";

			}

			else {

				// IF PASSWORDS DONT MATCH
				if ($password != $password2) {

				echo "the passwords you have entered do not match";
				echo "<br>please try again";
				echo "<br><br><a href=javascript:history.back();>back</a>";

				}

				// IF PASSWORDS MATCH
				else {

				// UPDATE PASSWORD
				$sql = "UPDATE custom set password=MD5('$password') WHERE username='".$_COOKIE[user]."'";
				$query = mysql_query($sql) or die("could not update password");
				$rows = mysql_affected_rows();

					// IF UPDATED ROWS IS NOT 1 - ERROR MESSAGE
					if ($rows != '1') {

					echo "could not update password";
					echo "<br>please try again";
					echo "<br><br><a href=javascript:history.back();>back</a>";

					}

					// PASSWORD UPDATED
					else {

					echo "password updated";

					}

				}					

			}

		}

	}
	// END OF ISSET($_POST['SUBMIT'])

}
// END OF NEWPASS

// IF USER IS NOT TRYING TO CHANGE PASS SHOW FORM
else {
echo "newpassformmode";
?>

		<table width=400 border=0 cellspacing=0 cellpadding=1 bgcolor=#666699>
		<tr align=center>
		<td>
 		<style type=text/css>
			<!--
			 .input { font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 8pt}
			 -->
		</style>
  		<font face=Verdana, Arial, Helvetica, sans-serif size=1 color=#FFFFFF><b>User Customization Registration</b></font>
		</td>
		</tr>
		<tr align=center> 
		<td> 
  		<table width=100% border=0 cellspacing=0 cellpadding=2 align=center bgcolor=#FFFFFF>
    	<tr> 
      	<td height=40 valign=middle><font face=Verdana, Arial, Helvetica, sans-serif color=#000000 size=1><b>
      	<!-- Form Starts -->

		<form method="POST" action="<?=$PHP_SELF?>?mode=newpass">
		<br>
        Old Password(20) - <input type="password" name="oldpassword" size="20" maxlength="20"><br><br>
        New Password(20) - <input type="password" name="password" size="20" maxlength="20"><br><br>
        Confirm New Password(20) - <input type="password" name="password2" size="20" maxlength="20"><br><br>

		<center><input type="submit" value="Submit" name="submit">   <input type="reset" value="Reset" name="B2"></center></p>

        </form>

      	<!-- Form Ends -->
     	</td>
    	</tr>
  		</table>
		</td>
		</tr>
		</table>



	<?
echo "endofnewpassformmode";
}
?>

of mode exists and isset($submit) doesnt then the else statement just above where i have echoed

echo "newpassformmode";

doesnt come in to play because nothing is being echoed out, so i'm guessing this is where the problem is,

any ideas?!

thanks for your time btw

Jon 🙂

tuf-web_co_uk

nevermind i think i have the hang of this "debugging" thing now

now for the rest of the modes

thanks again 🙂

Jon

stolzyboy

well if that is what you think the problem is, then you will need to do some {} checking, you may be closing too many so the last else is confused, and not all the times will parse errors occur, cuz you have the right amount of { and }, but they simply are in the wrong places

what i would suggest is take out all the other checking code but the if's stuff and save it as something else and make it down to the barebones if/else combos, then start putting in conditions and your blocks of code

baby steps sometimes is the best way to go, cuz then you don't have a huge chunk of code to check cuz you only put in say 3 lines and now it doesn't work, then you just check the 3 lines

catch my drift

i know this isn't really solving your problem, but it should help you
track down your problem

kinda indelved in a large project right now so am just hopping back and forth from it to phpbuilder and helping as much as possible

i know i have helped you before when you were starting the login process, but i was not busy at that time, sorry

stolzyboy

LOL you must've posted when i started writing, ok, good luck