File upload script not working......

kamy99

Hi all:

I have a simple upload file which works fine on one server and does NOT work on another!

After lots of seraching, my best guess is it has to do with PHP version.
The server which the scripts functions properly has PHP Version 4.2.2.

The problematic one has PHP Version 4.0.6.

Any suggestions?
My code is pasted below.

PS. All folders exist and I've kept the same directory structure.

tx
Kamy


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Up</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

</head>

<body>




<?
global $Action;
global $userfile;
global $userfile_name;

if($Action=="Upload")
{
echo "done";
$upfile="../image/".$userfile_name;
is_uploaded_file($userfile);
copy($userfile,$upfile);
echo "<hr>";

echo "Your File:&nbsp;&nbsp;<b>".$userfile_name."</b>&nbsp;&nbsp;has been uploaded successfully!<hr>";
?>
<form name="ImageForm">
<input name="ImageName" value="<? echo $userfile_name ;?>">
</form>
<?
echo "<hr>";

if (!is_uploaded_file($userfile))
{echo "failed";}

}
else
{
?>
<form enctype="multipart/form-data" action="?Action=Upload" method="post" >
<input type="hidden" name="MAX_FILE_SIZE" value="100000000000">
Upload a file: <input type="file" name="userfile" class="ViewForm">
<input type="submit" value="Upload" class="AdminOptions">
</form>
<?

}


?>

</body>
</html>

thessoro

action="?Action=Upload"...
this works at all??
try: <form whatever action="<?=$_SERVER['PHP_SELF']?>?Action=Upload">

kamy99

thessoro:

That part works fine........

thessoro

congratulations :p

(just i haven't seen that before 😉 )

kamy99

I think it doesn't work because register globals is off on the other machine..

Any suggestions?

thessoro

quite obvious (i think i'm misunderstanding again 🙂 ) You can enable register_globals or pick up the variable $Action using $_POST['Action']. But if you are asking how make the system compliant with both values of register_globals, i've seen posted there somewhere in this forum. One possibility (not very smart) could be:

if ($Action || $_POST['Action'])

Mordecai

Change $userfile to $FILES["userfile"], $userfile to $FILES["userfile"][""] (replace the * with whatever it is, obviously), and all post data to $POST["fieldname"] rather than $fieldname.

kamy99

Hi again:

Thanx for your replies.
I have revised the code, few of the problems have dissapeared 🙂 , but two still persist! 🙁

I'm attaching the code at the end.

Basically the copy line is not working.
I get an error like this:

Warning: Unable to open 'test.jpg' for reading: No such file or directory in c:\apache\htdocs\soccermania\game\upload.php on line 19

Line 19 is :

copy($myFile,$upfile);

The file doesn't get uploaded.

I'm going to bang my head on the wall a bit, until someone helps me!

tx

Kamy

<html>
<head>
<title>UPLOAD</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>
<body>
<?
global $Action;
global $userfile;
global $userfile_name;
global $upfile;
global $PHP_SELF;
if(isset($_GET['Action']))
{
$userfile_name=$_FILES['userfile']['name'];
$upfile="../images/".$userfile_name;
$myFile=$_FILES['userfile']['name'];
is_uploaded_file($myFile);
copy($myFile,$upfile);
echo "<hr>";
?>
<?
echo "<hr>";

if (!is_uploaded_file($_FILES['userfile']['name']))
{echo "failed";}

}
else
{
global $Action;
global $userfile;
global $userfile_name;
global $upfile;
?>
<form enctype="multipart/form-data" action="?Action=Upload" method="post" >
<input type="hidden" name="MAX_FILE_SIZE" value="100000000000">
Upload a file: <input type="file" name="userfile" class="ViewForm">
<input type="submit" value="Upload" class="AdminOptions">
</form>
<?
}
?>
</body>
</html>

ofSHIZ

I think that maybe the error is a few lines above it.. (not to sure) but it only realizes it at line 19.

thessoro

maybe (just guessing) in some hostings i needed to write the full basename path in order to move an uploaded file (something like "/mnt/.../public-html/yoursite/images" or whatever your basepath is)

tsinka

Hi,

$_FILES['userfile']['name'] contains just the filename. The file you want to copy might be

$_FILES['userfile']['tmp_name']

Read the comments on

http://de2.php.net/manual/de/function.is-uploaded-file.php

They'll show some code to handle uploaded files 🙂

kamy99

After reading the manual again, and by using your tips, I was able to finish it off.

thank you all.

In case, here's my final code:


<html>
<head>
<title>UPLOAD</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>
<body>
<?
if(isset($_GET['Action']))
{


$uploaddir = 'Z:/www/game/';



print "<pre>";
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploaddir . $_FILES['userfile']['name'])) 
{
    print "File is valid, and was successfully uploaded.  Here's some more debugging info:\n";
   print_r($_FILES);
	echo "<a href=index.php>View the Live Page!</a>";
} else {
    print "Possible file upload attack!  Here's some debugging info:\n";
    print_r($_FILES);
}

echo "<hr>";

?>
<?
echo "<hr>";


}
else
{

?>
<form enctype="multipart/form-data" action="?Action=Upload" method="post" >
<input type="hidden" name="MAX_FILE_SIZE" value="100000000000">
Upload a file: <input type="file" name="userfile" class="ViewForm">
<input type="submit" value="Upload" class="AdminOptions">
</form>
<?
}
?>
</body>
</html>