Upload troubles!!! HELP!

loureiro

Hi,

Im having some troubles uploading files from a form. I eventually want to throw the uploaded image into a database and i have to make it skip a few pages. I have been using the $_POST variable to continually pass it on and it has been working well for me. I have all the other information on my form going through properly and into a database except for this picture. actually there are two! what should i do?

barand

Does this help?

loureiro

that is exactly what i have been going with! i cant get it to work!

ereptur

uhh... how about a little source code so we can try and help

loureiro

ok. im trying to use the exact same source code that was on that page.

<?php

$uploaddir = '';

print "<pre>";
if (move_uploaded_file($FILES['pictureupload']['tmp_name'], $uploaddir . $FILES['pictureupload']['name'])) {
print "File is valid, and was successfully uploaded. Here's some more debugging info:\n";
print_r($FILES);
} else {
print "Possible file upload attack! Here's some debugging info:\n";
print_r($FILES);
}

and the second one im trying to upload is:

<?php

$uploaddir = '';

print "<pre>";
if (move_uploaded_file($FILES['signatureupload']['tmp_name'], $uploaddir . $FILES['signatureupload']['name'])) {
print "File is valid, and was successfully uploaded. Here's some more debugging info:\n";
print_r($FILES);
} else {
print "Possible file upload attack! Here's some debugging info:\n";
print_r($FILES);
}

I wanted to instead of take this and move it around to another file which would be a good step just jump right to the end which is bad i know and see if i can just get it to pass along the file from one page to another and then after a few pages when the customer pays for their purchase insert it into a database into a LongBlob record. But im pretty much having trouble doing all these things! your help would be greatly appreciated!

ereptur

I think maybe the problem is in your move_uploaded_file() call.
You have upload_dir set to NULL. Then you try to move the uploaded file to:

(example) NULL . myfilename.jpg

try setting your upload_dir to "./" which means the current directory. See if that works for you.

loureiro

Possible file upload attack! Here's some debugging info:
Array
(
[pictureupload] => Array
(
[name] => loadingbar.gif
[type] => image/gif
)

)

Possible file upload attack! Here's some debugging info:
Array
(
[pictureupload] => Array
(
[name] => loadingbar.gif
[type] => image/gif
)

)

this is what i get when i changed it! it must be something else. I dont really understand why its not working!

loureiro

this is the page that Im processing the upload on. I wanted to see if I could throw the image into a variable and then pass it along using the $_POST and a hidden field.

ereptur

What exactly are you expecting to see when you execute this script?

loureiro

nothing. I dont want it to show anything at all. Im was going to delete all the stuff that it spits out and format so it just does it and then have it posted to another page and then posted one more time before it gets inserted into a database.

all i want it to do is upload it wherever temporarily before it gets thrown into a hidden field and gets passed along again through $_POST to get to the processing page and then have it inserted. thats all! if i can say that! haha

ereptur

ahh I think I get it.

try this

$upload_dir = "/path/to/your/temp/";  //IMPORTANT!!! make sure that the trailing slash(/) is in there.
if(isset($_POST['userfile'])) { 
    $userfile = $_POST['userfile'];

move_uploaded_file($userfile['tmp_name'], $upload_dir . $userfile['name']);
$msg = "File is valid, and was successfully uploaded. Here's some more debugging info:\n"; 
} else { 
    $msg = "Possible file upload attack! Here's some debugging info:\n"; 
} 
print_r($userfile);

see if that does what you want.

loureiro

nothing happend! it didnt say whether it was good or not. it just completely skipped it!

ereptur

well all of the code I posted was written by me. You will need to substitute your own variables as you are passing them.

loureiro

oh i know. I already changed the variables. but it doesnt work!

loureiro

somebody please help me out! i really didnt think it was that hard to do!

tsinka

Hi,

I had similar problems when I tested the code you sent in the zip file. Here is how I solved it. First of all there is an error:

if (move_uploaded_file($_FILES['pictureupload']['tmp_
name'], $uploaddir . $_FILES['pictureupload']['name'])) {

It's on two lines. Change it to:

if (move_uploaded_file($_FILES['pictureupload']['tmp_name'],$uploaddir.$_FILES['pictureupload']['name'])) {

Sorry, for some reason phpbuilder splits it up to two lines (whioch might be the problem you had), it should be on one line 🙁

Then use an absolute path, not ./ but e.g. /path/to/mytmpdir/

Third you might run in troubles if two people uploading at the same time and using the same file names would overwrite the files of each other so you might need to add a unique value to the file name which you can remove when you actually insert the image into the database (if you also store the filename in the database).

The biggest problem in my case was the first problem (two lines) which always led to the problem that the image couldn't be moved.

Hope this helps you 🙂

Thomas

stolzyboy

here it is after you asked me for it

i have tested it on a nix and win box both, and works fine

loureiro

Parse error: parse error, unexpected ',' in C:...php11.tmp on line 72

heres the line:

copy($FILES['file']), "lifestyles/pictureupload/" . $FILES['pictureupload']['name']));

tsinka

Hi,

there is a ) too much

copy($FILES['file'], "lifestyles/pictureupload/" . $FILES['pictureupload']['name']));

tsinka

But shoudn't it be

$_FILES['pictureupload']['tmp_name'] instead of

$FILES['file'], AFAIK there is no $FILES['file'];