Realy urgent help no one can us emy site

[mrxxlphp]

Can any one tell me why this code doesnt work. It should check the form and make an error if need be other wise send them to the confirmation page:

<?php
$db = mysql_connect("localhost","tcomuk_master","mypass") or die ("error connecting to database.");
$query_username = "SELECT username FROM c_reg_users WHERE username = '$username'";
$sql_username_result = mysql_db_query(tcomuk_pchat4, $query_username, $db) or die ("$query_username". mysql_error());
$num_username_rows = mysql_num_rows($sql_username_result) or die (mysql_error());

if ($num_username_rows >0) {
$error = "Username already taken";
} else if ($username == null) {
$error = "Username";
} else if ($firstname == null) {
$error = "Firstname";
} else if ($lastname == null) {
$error = "Lastname";
} else if ($email == null) {
$error = "Email";
} else if ($mobile == null) {
$error = "Mobile Number";
} else if ($country == null) {
$error = "Country";
} else if ($password1 == null) {
$error = "Password";
} else if ($password2 == null) {
$error = "Repeat Password";
} else if ($password1 != $password2) {
$error = "Password Dont Match";
} else if ($error == null) {
header("Location: confirm.php?username=$username&password=Not%20Shown");
} else {
header("Location: register2.php?error=$error");
}
?>

[ereptur]

Well, what kind of errors are you getting?

[kevinsequeira]

try coding this way

if ($_POST['mobile'] == "")

// and not if ($mobile == null)

similary for the rest.

are u able to print out the form values on this page ??

reg
kevin

[mrxxlphp]

no i cant echo out the variables

thanks

[jimson]

$query_username = "SELECT `username` FROM `c_reg_users` WHERE `username` = '$username'"; 

i don't think the use of ` is correct... :

[jimson]

$query_username = "SELECT username FROM c_reg_users WHERE username = '$username' "; 

[heyrad]

First off... let's clean things up a bit... try this:

$fields = array(
'username' => 'please enter a username',
'firstname' => 'please enter your first name',
'lastname' => 'please enter your last name',
'email' => 'please enter your email address',
'mobile' => 'please enter your mobile number',
'country' => 'please enter your country',
'password1' => 'please enter a password',
'password2' => please re-enter your password',
);

foreach ($fields as $field => $value) {
if ("" == $value) { $error = $fields[$field]; }
}

This will neaten things up a bit. Also try this for the $query:
$query = sprintf("SELECT username FROM %s WHERE username = '%s'",c_reg_users,$username);
Then run the query.

[heyrad]

ooops....

My bad...

$fields = array(
'username' => 'please enter a username',
'firstname' => 'please enter your first name',
'lastname' => 'please enter your last name',
'email' => 'please enter your email address',
'mobile' => 'please enter your mobile number',
'country' => 'please enter your country',
'password1' => 'please enter a password',
'password2' => please re-enter your password',
);

foreach ($fields as $field => $value) {
if ("" == $HTTP_POST_VARS[$field]) { $error = $fields[$field]; }
}

// substitute $HTTP*VARS with whatever array holds the form input variables...

Sorry...

[Moonglobe]

that would only output the last error. try this:

$error= "";
$fields = array(
'username' => 'please enter a username',
'firstname' => 'please enter your first name',
'lastname' => 'please enter your last name',
'email' => 'please enter your email address',
'mobile' => 'please enter your mobile number',
'country' => 'please enter your country',
'password1' => 'please enter a password',
'password2' => 'please re-enter your password',
);

foreach ($fields as $field => $value) {
    if ("" == $_POST[$field]) {
       $error .= $fields[$field]." "; 
    }
}

// substitute $_POST with whatever array holds the form input variables...

[mrxxlphp]

Thanks alot guys for your help, you a great. How can I check if the user name is not already present in the database then insert all the values into the table c_reg_users.

MAny Thanks

[mrxxlphp]

Anyone??

[Moonglobe]

<?php
foreach ($_POST as $k=>$v) {
    $k=$v;
}
$badq = "SELECT `usetname` from `c_reg_users` where `username`='$username'";
$badr = mysql_query($badq);
if (mysql_num_rows($badr) >= 1) {
    //do something if theres already a username
} else {
    $goodq = "insert into c_reg_users(username, 
firstname,
lastname,
email,
mobile,
country,
password)
VALUES (
$username,
$firstname,
$lastname,
$email,
$mobile,
$country,
$password1)"; 
//im also assuming that the post variables have the same name as the fields
//except for password, which im just using password1 for. you have to do 
//your error checking above.
$goodr = mysql_query($goodq);
if (mysql_rows_affected($goodr) == 1) {
    //the user was created
} else { 
    //the user was not created right.
}

hth
moon

[FrozNic]

qry for the inputed username ... -> select * from table where username = (inputed text)

if numrows == 0.. that user name doesn't exhist

[mrxxlphp]

Ok thanks so how would i interngart the hole script with a datavse connection, i am new to MySql.

Thanks

[FrozNic]

here's u a nice tut. on dbase connectivity and how to integrate php and mysql..
http://www.devshed.com/Server_Side/MySQL/Intro/page2.html

[mrxxlphp]

so, can someone put all that together for me witht a databse connections cript.
Thanks very much

[FrozNic]

http://hotwired.lycos.com/webmonkey/99/21/index2a.html?tw=programming

i won't, but there's a link so you can learn how.

[kevinsequeira]

<?php
$errors = array(
'username' => 'please enter a username',
'firstname' => 'please enter your first name',
'lastname' => 'please enter your last name',
'email' => 'please enter your email address',
'mobile' => 'please enter your mobile number',
'country' => 'please enter your country',
'password1' => 'please enter a password',
'password2' => please re-enter your password',
);
$is_error = 0;
$error = "";
foreach ($errors as $key => $value) {
  if ($_POST[$key] == ""){
  	$error .= $errors[$key]."<BR>";
			$is_error = 1;
  }
}
if($_POST['password1']!=$_POST['password2']){
		$is_error = 1;
		$error .="passwords dont match<BR>";
}
if($is_error == 0){ 
  $db = mysql_connect("localhost","tcomuk_master","mypass") or die ("error connecting to database.");
  mysql_select_db("tcomuk_pchat4");
  $query = "SELECT username FROM c_reg_users WHERE username = '".$_POST['username']."'";
  $result = mysql_query($query) or die ("$query". mysql_error());
  if(mysql_num_rows($result)==0){
			header("Location: confirm.php?username=".$_POST['$username']."&password=Not%20Shown");   

  	exit;
  }else{
  	$is_error = 1;
  	$error = "username already exists";
  }	 
}

if($is_error == 1){
		header("Location: register2.php?error=$error"); 
}		
?>

i havent tested this for syntax errors, so u might get some.
i suggest you read up some tutorials so you understand whats been done

reg
kevin

[mrxxlphp]

Wow thank you so much for that, do you have a site i can gut a link to in my advertise section.

What does:

Parse error: parse error, unexpected '=' in /home/t-comuk/public_html/register.php on line 16

mean?

Many Thanks

[laserlight]

I think you should change:
$error. = $errors[$key]."<BR>";
to
$error .= $errors[$key]."<BR>";