Evaluation line problem.

Tekron-X

Ok here is what is going on the script this excerpt is from is a registration scrip that inserts the data into the db.

My script without the line I am going to show works fine and inserts into the database all the info that is given however this line is ment to keep empy data from going in.

I now with all the fields with proper data and all filled without this line works as I checked the DB and nothing was blank so I put this line in for safty sake for people who don't listen and leave stuff blank.

Now it will not insert at all saying that the varables or variable is empty so this line is always evaluating to true when all data is proper and filled in and with the proper data it should evaluate to false causing the DB to be populated.

Here is the line.

if(isset($username) or isset($userpass) or isset($useremail)
   or isset($userempire) or isset($useralign) or isset($privi))

maganv0x

have you tryed a basic if ($username == null) or if ($username != null), etc and see if that would work?

Sorry if I'm not much help, but I'm not exactly a seasoned PHPer and I'm not familiar with the isset() statement

Tekron-X

Humm lol seems that the below line is doing the same thing lol constantly evaluating to true when nothing is blank and all goes through.

if($username == null or $userpass == null or $useremail == null
   or $userempire == null or $useralign == null or $privi == null)

If you need the whole 133 line script I will gladly postit.

maganv0x

lol, I've been having similar problems with an if statment, but you can also try (if $username == "") and replace the or's with ||

Worth a shot I guess lol

Tekron-X

Doh same problem here is the entier script I have tracked it to the if statement through testing it without the if and checking the db and nothing was missing but here it is lol. I warn you don't criticze the first few empty lines as they are not going to be in there as they are useless atm and do nothing to stop anything. I have there so they can help me debug as it warns me if I forgot a field. 😃

<?php
//register.php
//Created By: Bill Lewis
include "./common_db.inc";
echo "<html>";
echo "<head></head>";
echo "<body>";
if(empty($_POST['username'])) echo "Go enter a username!<br>";
if(empty($_POST['userpass'])) echo "Go enter a userpassword!<br>";
if(empty($_POST['useremail'])) echo "Go enter a useremail!<br>";
if(empty($_POST['userempirename'])) echo "Go enter a userempier!<br>";
If(empty($_POST['align'])) echo "Go enter a alignment!<br>";
$useralign = HTMLSpecialChars($_POST['align']);
$privi = 0;

//validity RegExp checks
function checkusername($useradd)
{
    $utestres = ereg("[a-z]{2,8}", $useradd);
    if(!$utestres)
    {
        echo "Invalid character in username put another!<br>";
    }
    else
    {
        return $useradd;
    }
}
$username = checkusername($_POST['username']);

function checkuserpass($passadd)
{
    $ptestres = ereg("[0-9]{8}", $passadd);
    if(!$ptestres)
    {
        echo "Not a valid password put another!<br>";
    }
    else
    {
        return $passadd;
    }
}
$userpass = checkuserpass($_POST['userpass']);

function checkemail($emailadd)
{
    $emtestres = ereg("^.+@.+\\..+$", $emailadd);
    if(!$emtestres)
    {
        echo "Invalid e-mail address go put another<br>";
    }
    else
    {
        return $emailadd;
    }
}
$useremail = checkemail($_POST['useremail']);

function checkuserempire($uemp)
{
    $emptestres = ereg("[A-Z]{8}", $uemp);
    if(!$emptestres)
    {
        echo "Please go back and enter a valid empiername!<br>";
    }
    else
    {
        return $uemp;
    }
}
$userempire = checkuserempire($_POST['userempirename']);

//create DB connection
$link_id = db_connect();
if (!$link_id) die(sql_error());

//check and insert record
function checkandinsert($user, $pass, $email, $empier, $align, $priv)
{
    $username = $user;
    $userpass = $pass;
    $useremail = $email;
    $userempire = $empier;
    $useralign = $align;
    $privi = $priv;

$chkuser = "SELECT userid, userempire FROM user WHERE
            (userid = '$username' OR userempire = '$userempire')
            LIMIT 1";
$chkuserq = mysql_query($chkuser);
$result = mysql_num_rows($chkuserq);
if ($result > 0)
{
    echo "This user and or empire is in existance please
          pick another!<br>";
}
else
{
    //check to see if vars are empty if so make correction.
     $adduser = "INSERT INTO user (userid, userpassword, useremail,
                 registerdate, userpriv, userempire, useralignment)
                 VALUES('$username', Password($userpass),
                        '$useremail', curdate(), '$privi',
                        '$userempire', '$useralign')";
     $insert = mysql_query($adduser);
     //check to see if query was fine if so insert record to db
     if(!$insert)
     {
         echo "We encountered a problem puting you in the EOTA
               Database please contact the game programer at:
               <a href=\"mailto: [email]tekronx@adelphia.net[/email]\">Tekron-X</a>
               with the following error! $nbsp;" . mysql_error();
     }
     else
     {
         echo "Welcome to EOTA you can now login and begin your
               race to save the world. <a href=\"login.php\">
               CLICK HERE TO LOGIN!!!</a>";
     }
}
}
if($username == "" or $userpass == "" or $useremail == ""
   or $userempire == "" or $useralign == "" or $privi == "")
{
    echo "Go Back and fill in all fields or enter proper characters.";
}
else
{
checkandinsert($username, $userpass, $useremail, $userempire,
               $useralign, $privi);
}
mysql_close($link_id);
?>

maganv0x

set $privi = 1; for the heck of it and see what it does

Tekron-X

Well I'll be damed that was the prob who would have guess lol.

Thx alot man I would have never though that with that variable set to 0 would cause all that hassle.

Again thx now I will try to help you out.

maganv0x

I was starting to wonder what I was thinking, asking you to try that. Maybe I should think less rofl. I guess a integer assigned the number 0 is actualy assigned nothing or a 0 is considered a null.

Tekron-X

well I think 0 is nothing and null is null as 0 is something not null 😉