PHP 4.3.2 and File uploads

OzRoy

Hey guys.

I recently upgraded my server from PHP 4.2.3 to 4.3.2.

I am not having problems with scripts that upload files to the server.

It seems the file and it's POST data gets lost somewhere.

Here is a test script I wrote

<?php

if ($_REQUEST['action']) {
        print "<pre>";
        print_r($_REQUEST);
        print "</pre>";
} else {
?>
<form method=post enctype="multipart/form-data">
<input type=hidden name=action value="1">
<input type=file name=fileupload>
<input type=submit>
</form>
<?php
}

?>

The output of this using PHP 4.2.3 is:

Array
(
    [action] => 1
    [fileupload] => Array
        (
            [name] => ccsml.jpg
            [type] => image/jpeg
            [tmp_name] => /tmp/phpYWciHf
            [error] => 0
            [size] => 7681
        )

)

But the output using PHP 4.3.2 is:

Array(
    [action] => 1
)

Does anyone know what I am missing? Is there a new setting I have to put in?

I have tested this on two machines. My actual webserver, and my workstation. The workstation has only ever had 4.3.2 installed on it.

Mordecai

Files are not in $POST[] any more. They are now in $FILES[], their own array.

OzRoy

Originally posted by Mordecai
Files are not in $POST[] any more. They are now in $FILES[], their own array.

So they are not put into the $_REQUEST array either?

Well thats bloody annoying! That means I have to recode everything.

Mordecai

I think it's just as well, but yes, you'll have to recode.

$FILE["fieldname"] = file data
$FILE["fieldname"]["type"] = mimetype
$FILE["fieldname"]["size"] = filesize
$FILE["fieldname"]["name"] = filename
$FILE["fieldname"]["tmp_name"] = temporary name
$FILE["fieldname"]["error"] = any errors you may have gotten, this is fairly new

OzRoy

Can I ask what the reasoning behind this move was?

I can't really think of really important reason for this.

As far as I'm concerned the file is form data and so should appear on REQUEST. After all GET, POST, and COOKIE all appear in that array (unless they changed that too).

Mordecai

I'm not really sure. It does make for cleaner code, however, since everything is specified by what it is (file, cookie, etc.).

OzRoy

The reason why this is particularly annoying for me is because I now have a single form element being treated differently to every other form element.

In my code I have a single base class called 'formelement' and when I create an object based on that class the constructor updates the objects value using _REQUEST. Now that 'file' doesn't use that array I have to code in a special case for that one element. Something that isn't particularly clean.