[Resolved] Positioning the window

spanishsteps

Hola,

I display records on a page from a table using PHP and there is a link called "Contact the person"When i click on this link, i want to open a new page and this page has to be centered on the window.This code is working fine in another application of mine but does'nt seem to work here.Could somebody please tell me why this does'nt work.Is there any problem with the php code, i mean should i add anything else or is my java-script troubling me??

Thanks.

On the first page i've this code:

echo"<tr>";
echo"<td width='50%'><a href='contactform.html' target='_blank'>Contact the Person</a>";
echo"</tr>";

and now when i click on contact the person, the page contactform.html opens and here is the code for that.


<html>

<head>
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<meta name="GENERATOR" content="Microsoft FrontPage 4.0">
<meta name="ProgId" content="FrontPage.Editor.Document">
<title>Contact Page</title>

<script type="text/javascript">

function openWindow(theURL,winName,features, myWidth, myHeight, isCenter) { 
  if(window.screen)if(isCenter)if(isCenter=="true"){ 
    var myLeft = (screen.width-myWidth)/2; 
    var myTop = (screen.height-myHeight)/2; 
    features+=(features!='')?',':''; 
    features+=',left='+myLeft+',top='+myTop; 
  } 
  window.open(theURL,winName,features+((features!='')?',':'')+'width='+myWidth+',height='+myHeight); 
} 

</script>
</head>

<body bgcolor="#FFFFCC">

<table border="1" width="100%">
  <tr>
    <td width="50%">Your name</td>
    <td width="50%">
      <p><input type="text" name="T1" size="20"></p>
      </td>
  </tr>
  <tr>
    <td width="50%">Your text</td>
    <td width="50%"><input type="text" name="T2" size="20"></td>
  </tr>
  <tr>
    <td width="50%">Your description</td>
    <td width="50%">
      <p><textarea rows="2" name="S1" cols="20"></textarea></p>

</td>
  </tr>
</table>

<table border="1" width="100%">
  <tr>
    <td width="100%"><input type="submit" name="submit" value="enter"></td>
  </tr>
</table>

</body>

</html>

hi-liter

check the body tag in your other application and copy the <body onload=openWindow(.... code. as when contactform.html is loaded, nothing triggers your js function.

spanishsteps

Hello hi-liter,

do you mean this code is missing???

echo"<tr>";
echo"<td width='50%'>";
echo"<a href='javascript:";
echo"onClick="openWindow('contactform.html','target=_blank','','toolbar=no,status=no','724','470','true')"
Contact the Person</a>";
echo"</tr>";

This gives me parse errors always, do you have any idea why??

Thanks for your time

hi-liter

this line looks bad:

echo"onClick="openWindow('contactform. html','target=_blank','','toolbar=no,status=no','724','470','true')"

more specifically: echo"onClick=" and )"Contact the Person</a>";

try:

echo("

onClick=\"openWindow('contactform. html','target=_blank','','toolbar=no,status=no','724','470','true')\">Contact the Person</a>

");

and here too:

'java script:";

javascript, one word.

spanishsteps

hello hi-liter,

Sorry this does'nt open any window and i notice at the bottom(Error on page).

Do you have any ideas why??

Thanks for your time

hi-liter

your js code has to go on the page your calling it from, so move that to your first page.

move this;

function openWindow(theURL,winName,features, myWidth, myHeight, isCenter) {
if(window.screen)if(isCenter)if(isCenter=="true"){
var myLeft = (screen.width-myWidth)/2;
var myTop = (screen.height-myHeight)/2;
features+=(features!='')?',':'';
features+=',left='+myLeft+',top='+myTop;
}
window.open(theURL,winName,features+((features!='')?',':'')+'width='+myWidth+',height='+myHeight);
}

</script>

to the page that has:

onClick=\"openWindow('contactform. html','target=_blank','','toolbar=no,status=no','7
24','470','true')\">Contact the Person</a>

hi-liter

this works for me:

<html>

<head>

</script>
</head>

<a href="javascript:" onClick="openWindow('http://www.google.com','','','toolbar=no,status=no','724','470','true');">Contact the Person</a>

</body>

</html>

spanishsteps

Hello hi-liter,

that does'nt work too.when i move the mouse on "contact the person", I notice in the bottom Javascript:onclick="openwindow(
So, it does'nt recognize my file name either and i still see the error??

Is this becuase i also use my another javascript code in the same program.

Thanks once again

This is my page how it looks like:

<html> 
<head>
<link REL=stylesheet href="mystyle.css" TYPE="text/css">
<script type="text/javascript">

function open_phone_number_window(number)
{
	window_html_code = "<html>";
	window_html_code += "<head><title>Phone number</title></head>";
	window_html_code += "<body>";
	window_html_code += "<table width=\"100%\" height=\"100%\">";
	window_html_code += "<tr><td valign=\"middle\" align=\"center\">";
	window_html_code += number;
	window_html_code += "<br>";
	window_html_code += "<a href=\"javascript:window.close();\">close window</a>";
	window_html_code += "</td></tr></table>";
	window_html_code += "</body>";
	window_html_code += "</html>";

win = window.open("","win","top=100,left=200,width=225,height=100");
win.document.write(window_html_code);
}

</script>

<script type="text/javascript"> 

function openWindow(theURL,winName,features, myWidth, myHeight, isCenter) { 
if(window.screen)if(isCenter)if(isCenter=="true"){ 
var myLeft = (screen.width-myWidth)/2; 
var myTop = (screen.height-myHeight)/2; 
features+=(features!='')?',':''; 
features+=',left='+myLeft+',top='+myTop; 
} 
window.open(theURL,winName,features+((features!='')?',':'')+'width='+myWidth+',height='+myHeight); 
} 

</script> 

</head>

<body bgcolor="#FFFFCC"> 
<?php 

// Lets create MySQL connection 

// Lets select the database 

// Lets select the record fields from our database table and check for results 

$query="SELECT introtext,zipcode,image,telephone,description FROM tbl_personals ORDER BY id"; 

$numresults=mysql_query($query,$connection); 
$numrows=mysql_num_rows($numresults); 

// get results

  $result = mysql_query($query) or die("Couldn't execute query");

// We carry out the table population using a 'while' loop 

while ($row=mysql_fetch_array($result)) 
{ 
$var_1=$row["introtext"]; 
$var_2=$row["zipcode"]; 
$var_3=$row["image"]; 
$var_4=$row["telephone"]; 
$var_6=$row["description"]; 

// Display the results 

echo" 
<table width='80%'>";
echo"<tr>";
echo"<td width='100%' colspan='2'><b>$var_1 </b>";

echo ($date);  

echo"</td> 
  </tr>";
echo"<tr>
    <td width='50%'>Zip Code:$var_2</td>
    <td width='50%' rowspan='4' bordercolorlight='#C0C0C0' bordercolordark='#C0C0C0'>$var_6</td>
  </tr>";
echo"<tr>
    <td width='50%'><img src='$var_3'></td>
	  </tr>";
echo"<tr>";
echo"<td width='50%'>";
echo "<a href='javascript:";
echo "open_phone_number_window(".$row['telephone'].");'>Telephone number</a>";
echo"</td>";
echo"</tr>";
echo"<tr>";
echo"<td width='50%'>";
echo"<a href='javascript:";
echo("onClick=\"openWindow('contactform.html','target=_blank','','toolbar=no,status=no','7
24','470','true')\">Contact the Person</a>"); 
echo"</tr>";
echo"</table>
&nbsp";

} 

//We close the MySQL connection 

mysql_close($connection); 

?> 

</TABLE> 
</body> 
</html>

hi-liter

pls look at the code in my previous post.

delete from your code:

target=_blank

ok?

as for PHP, don't do this:

echo "open_phone_number_window(".$row['telephone'].");'>Telephone number</a>";

you can't start with " then in the middle " again and end it w/ ".

\" escape them pls.

echo "open_phone_number_window(\".$row['telephone'].\");'>Telephone number</a>";

spanishsteps

hello hi-liter,

sorry to trouble you.It does'nt seems to work with me.The piece of html code works with me fine too but when it comes to php, it does'nt - either it gives me parse errors or it does'nt show me the window,huh!

This does'nt produce any error but the window does'nt open.

echo "open_phone_number_window(".$row['telephone'].");'>Telephone number</a>";

and this produce parse and white space error.

echo "open_phone_number_window(\".$row['telephone'].\");'>Telephone number</a>";

Thanks for your time.

hi-liter

sorry bout suggesting change to this:
echo "open_phone_number_window(".$row['telephone'].");'>Telephone number</a>";

brain fart, my bad.

did you? :

delete from your code:

target=_blank

that's not working, or needed.

spanishsteps

yeah i removed target=_blank, still not working.aint sure why??

Thanks anyways.

spanishsteps

Alright, i made it working🙂

This is the correction:

echo"<a href=javascript:";
echo"openWindow('contactform.html','','toolbar=no,status=no','724','470','true')>Contact the Person</a>";