SQL install script problems.

fulco

I'm still new to php and my syntax is not great.

I am getting this notice:
Notice: Undefined variable: begin in /home/wwwfulc/public_html/install.php on line 21

Then it prints my link "Begin".

When I click the link it just prints "Completed" and doesn't do the sql.

Here is the PHP (minus the sql dump, since it has over 300 and some odd entries)

You can see the entire file in txt format (minus the html) at http://www.fulco.net/installphp.txt

<html>
<head>
<title>Xenology Database Install Script</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#FFFFFF" text="#000000">
<?php
/*This document Copyright 2003 Scar's Legion ([url]http://st.fulco.net[/url]).
There is no warranty expressed or implied by the use of this script.  

Use at your own risk.  It is published as linkware, and must retain 
all copyrights and links as they where originally programmed.  If 
you are caught using this script without meeting these standards 
you will be prosecuted to the fullest extent.*/
error_reporting(E_ALL);
require("xenosetup.php");

$con = mysql_connect($host, $user, $pass) or die ("I cannot connect to the database because:" . mysql_error());
mysql_select_db($db, $con) or die("I cannot select the correct database because: " . mysql_error());

if ($begin==1){
$sql = 'CREATE TABLE xeno( id int( 10 ) NOT NULL auto_increment, xeno varchar( 50 ) default NULL , xenotxt text, image varchar( 255 ) default NULL , PRIMARY KEY ( id ) , UNIQUE KEY id( id ) )';
$sql = "INSERT INTO xeno (id, xeno, xenotxt, image) VALUES **snip** ";
	echo "Completed.";
} else {
printf("<a href=\"%s?begin=1\">Begin</a><br>", $PHP_SELF);
}
?>
</body>
</html>

Thanks for the help!

fulco

Does anyone have any suggestions?

tdevlin

Can you post the xenosetup.php file, the information you listed does not offer any way to help resolve the problem. We need to see the core file, which judging by the require is xenosetup.php

Regards,
Tony Devlin

laserlight

Well, since you set error reporting to report notices (since E_ALL reports everything), $begin must be defined first.

Now $begin comes from the $_GET array, since you pass it via query string.

Instead of assuming register_globals is On, you should use $_GET['begin']
Now, to actually fix the notice, you can use isset() or empty(), since they do not result in notices when an undefined variable is passed to them.
You could check the value of the variable too, but in this case it doesnt seem necessary.

The code would then be:

<html>
<head>
<title>Xenology Database Install Script</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#FFFFFF" text="#000000">
<?php
/*This document Copyright 2003 Scar's Legion (<a href="http://st.fulco.net" target="_blank">[url]http://st.fulco.net[/url]</a>).
There is no warranty expressed or implied by the use of this script.  

Use at your own risk.  It is published as linkware, and must retain 
all copyrights and links as they where originally programmed.  If 
you are caught using this script without meeting these standards 
you will be prosecuted to the fullest extent.*/
error_reporting(E_ALL);
require("xenosetup.php");

$con = mysql_connect($host, $user, $pass) or die ("I cannot connect to the database because:" . mysql_error());
mysql_select_db($db, $con) or die("I cannot select the correct database because: " . mysql_error());

if (isset($_GET['begin'])) {
	$sql = 'CREATE TABLE xeno( id int( 10 ) NOT NULL auto_increment, xeno varchar( 50 ) default NULL , xenotxt text, image varchar( 255 ) default NULL , PRIMARY KEY ( id ) , UNIQUE KEY id( id ) )';
	$sql = "INSERT INTO xeno (id, xeno, xenotxt, image) VALUES **snip** ";
	echo "Completed.";
} else {
	printf("<a href=\"%s?begin=1\">Begin</a><br>", $_SERVER['PHP_SELF']);
}
?>
</body>
</html>

Note that I changed $PHP_SELF to $_SERVER['PHP_SELF'] as well.

EDIT:
incidentally, your $sql variables dont do anything, you may have to actually send the queries, but I presume it is merely part of development.

fulco

Thanks for the tips, it worked after I made a couple modifications. It ended up looking like this:

<html>
<head>
<title>Xenology Database Install Script</title>
</head>

<body bgcolor="#FFFFFF" text="#000000">
<?php
error_reporting(E_ALL);
require("xenosetup.php");

$con = mysql_connect($host, $user, $pass) or die ("I cannot connect to the database because:" . mysql_error());
mysql_select_db($db, $con) or die("I cannot select the correct database because: " . mysql_error());

if (isset($_GET['begin'])){
$sql1 = 'CREATE TABLE xeno( id int( 10 ) NOT NULL auto_increment, xeno varchar( 50 ) default NULL , xenotxt text, image varchar( 255 ) default NULL , PRIMARY KEY ( id ) , UNIQUE KEY id( id ) )';
$sql2 = "INSERT INTO xeno (id, xeno, xenotxt, image) VALUES (**snip**)";
$result1 = mysql_query($sql1);	
$result2 = mysql_query($sql2);	
	echo "Completed.";
} else {
$begin = "0"; 
printf("<a href=\"%s?begin=1\">Begin</a><br>", $_SERVER['PHP_SELF']);
}
?>
</body>
</html>

It works perfect now.

Thanks for the kind and intelligent response.