forms - agh... - PHPBuilder Forums

forms - agh...

xconspirisist

hey, ive knocked the following up from many different sites, a clump of it I found just a second ago on these forums. I understand the vast magority of the code. and some of it works... some of it doesnt 🙂

ive got a list that comes up with information from the sql database, wicked. but then I get :

Notice: Undefined variable: submit in W:\admin\als\members\and_tutadd.php on line 30

and the form.

When I submit the form, I get a 404. any suggestions?

<?PHP
$reqlevel = 2;
include("membersonly.inc.php");

$db = mysql_connect("localhost", "----", "----");

mysql_select_db("andromeda_news",$db);

$result = mysql_query("SELECT * FROM news",$db);

while ($row = mysql_fetch_array($result))
{
printf ("%s %s %s<br>", $row["ID"], $row["Title"], $row["Content"]);
}

<html>

<body>

<?php

if ($submit) {

// process form

$db = mysql_connect("localhost", "----", "----") or die("Could Not Connect To The Database. <br>" . mysql_error());

mysql_select_db("andromeda_news",$db) or die("Could Not Select The Proper Database. <br>" . mysql_error());

$name = $POST['name'];
$desc = $POST['desc'];
$url = $_POST['url'];

$sql = "INSERT INTO news(Title, Content) VALUES ('$name','$desc','$url')";

$result = mysql_query($sql);

if($result)

{

echo "Data Properly Inserted";

}

else

{

echo "An Error occured while trying to process your information.";

}

echo $sql ;

echo "Thank you! Information entered.\n";

}

else

{

// display form

title:<input type="Text" name="name"><br>

content:<input type="Text" name="desc"><br>

</form>

<?php

} // end if

cgraz

Change

if ($submit) {

if ($_POST['submit']) {

Cgraz

fire_cracker

I can't realy see anything error causing in the program except for this line right here:

$sql = "INSERT INTO news(Title, Content) VALUES ('$name','$desc','$url')";

You have to feilds selected for data, but you have thee values to insert. I don't know the structure of you db, so I can't proclaim that this is the answer, but it is worth taking a look at.

xconspirisist

thanks fire cracker - ive changed the code, your right, it was wrong.

cgraz - ive changed that line, to no effect. The code now reads :

<?PHP  $reqlevel = 2;  

include("membersonly.inc.php");    

$db = mysql_connect("localhost", "----", "----");    

mysql_select_db("andromeda_news",$db);  

$result = mysql_query("SELECT * FROM news",$db);   

while ($row = mysql_fetch_array($result))   

{
 	printf ("%s %s %s<br>", $row["ID"], $row["Title"], $row["Content"]);  

}    

?>    

<html>   

<body>  

<?php     

if ($_POST['submit']) {     // process form     

$db = mysql_connect("localhost", "----", "----") or die("Could Not Connect To The Database. <br>" . mysql_error());     

mysql_select_db("andromeda_news",$db) or die("Could Not Select The Proper Database. <br>" . mysql_error());

$name = $_POST['title']; 

$desc = $_POST['content'];     

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";     

$result = mysql_query($sql);     

if($result)     {     echo "Data Properly Inserted";     

}     

else
{     

echo "An Error occured while trying to process your information.";     }     echo $sql ;

echo "Thank you! Information entered.\n";     

}
else
{     // display form     

?>     

<form method="post" action="<?php echo $PHP_SELF?>">

title:<input type="Text" name="title"><br>
content:<input type="Text" name="content"><br>
<input type="Submit" name="submit" value="Enter information">     

</form>     

<?php     

} // end if     

?>     

</body>     

</html>

but I still get the error :

Notice: Undefined index: submit in W:\admin\als\members\and_tutadd.php on line 24

after I get the database readout, and just before I get the form.

please help, a chunck of my website depends on this code !! 🙂

laserlight

undefined index?
hmm... maybe you should change error reporting not to report notices like undefined variables.

in any case, you could change:

if ($_POST['submit']) { // process form

if (isset($_POST['submit'])) { // process form

bad76

Hi,

Your global variable are off or on ?!?

$name = $_POST['title']; 
$desc = $_POST['content'];     

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

In this peiece you are using both:
$POST['title'] & $title
$POST['content'] & $content

I think more right this

$name = $_POST['title']; 
$desc = $_POST['content'];     

$sql = "INSERT INTO news(Title, Content) VALUES ('$name','$desc')";

or this

$name = $title; 
$desc = $content;     

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

may be?

xconspirisist

I dont know if this is what you're looking for, but its the only line in my php info with global...

register_globals :

local value = off

master value = off

xconspirisist

sorry, ive reworked the code...

and_tutsubmit.php

<?PHP
$reqlevel = 2;
include("membersonly.inc.php");

echo "<font face = verdana size = 2";
echo "<b><b>some text here.</b>";
echo "<br>";
echo "<br>";

$db = mysql_connect("localhost", "-----", "-----");

mysql_select_db("andromeda_news",$db);

$result = mysql_query("SELECT * FROM news",$db);

while ($row = mysql_fetch_array($result))
{
printf ("%s %s %s<br>", $row["ID"], $row["Title"], $row["Content"]);
}

<html>

<body>

title:<input type="Text" name="title"><br>

content:<input type="Text" name="content"><br>

</form>

</font>

</body>

</html>

and_tutsubmit.php

<?php

$db = mysql_connect("localhost", "----", "----") or die("Could Not Connect To The Database. <br>" . mysql_error());

mysql_select_db("andromeda_news",$db) or die("Could Not Select The Proper Database. <br>" . mysql_error());

$title = $POST['title'];
$content = $POST['content'];

if (!$title)
{

echo " no title 🙁 ";
echo " Go back and put a title in! ";

}

else {

echo "<br>";
echo " Title : $title";

}

if (!$content)
{
echo "<br>";
echo " No content !! ";
echo " Go back and put some content in! ";

}

else {

echo "<br>";
echo "Content : $content";

}

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

laserlight

well, either way just use the $POST and $GET arrays.

You should also use the isset() suggestion that I made earlier.

xconspirisist

sorry, I actualy forgot to say what was wrong this time !!

im getting no errors, and the result page prooves that its getting information from the submit page. but the information isnt being writen to the database....

so is there an error in this line ? :

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

kevinsequeira

to debug try this

$sql = "INSERT INTO news(Title, Content) VALUES ('".$title."','".$content."')";     

echo $sql;

$result = mysql_query($sql);     

if (mysql_error())
  echo mysql_error();

try running the output of echo $sql directly in your database
reg
kevin

jimson

the line is no problem

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

the problem is, how are u going to insert the data if u don't query it... i think u forget to query the sql statement u made

try this

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";
// insert after this line
mysql_query($sql) or die(mysql_error());

xconspirisist

works a treat, thanks all !!

kevinsequeira

$sql = "INSERT INTO news(Title, Content) VALUES ('$title','$content')";

$result = mysql_query($sql);

if($result) { echo "Data Properly Inserted";

}

i thought he had already used mysql_query() .....

xconspirisist, what was wrong, why wasnt it working before ?

reg
kevin