How to use uploads correctly

[benkillin]

well, I am making a "file system" script that will have a page that has links to files, I have everything worked out except for uploading the files... here is what I have:

<?
if($_SERVER['REMOTE_ADDR'] == "192.168.0.2" || $_SERVER['REMOTE_ADDR'] == "192.168.0.3" || $_SERVER['REMOTE_ADDR'] == "127.0.0.1" || $_COOKIE['cookie'] == "blah"){
	$author = "1"; //if this is 1, then the add entry link will be at the top
}
$root = $_SERVER['DOCUMENT_ROOT'];
$header = "$root/header.php";
$footer = "$root/footer.php";
$linkfile = "files.dat";

if(!file_exists($linkfile)){
	$make = fopen($linkfile, "w");
	fclose($make);
}

if(isset($_GET['input'])){
	include($header);
	?>
	<form action="file.php?writefile" method="post">
	File:<br />
	<input name="upload" type="file" /><br />
	File Link:<br />
	<input name="lname" type="text" size="20" /><br />
	Description of file:<br />
	<textarea name="descr" cols="50" rows="15"></textarea><br />
	<input name="" type="submit" value="Upload file to system" />&nbsp;<input name="" type="reset"><br />
	</form>
<?
	include($footer);
} elseif(isset($_GET['display'])){
	include($header);
	$link = file("files.dat");
	if($auth = "1"){
		echo "<a href=\"file.php?input\">Upload a file!</a>";
	}

if (sizeof($link) > 0){
echo '<table bgcolor="#E5E5E5" border="1" bordercolor="tan" width="75%" align="center">';
	for ($i=sizeof($link)-1; $i>=0; $i--){
		list($flink, $fdescr, $timestamp) = split("\t", $link[$i]);

		$date = date("m-d-y g:i:s a", $timestamp);

		?>
		  <tr> 
		    <td width="40%">File: <? echo $flink; ?></td>
		    <td width="40%">Description: <? echo $fdescr; ?></td>
			<td width="20%"><? echo $date; ?></td>
		  </tr>
		<?
	}
echo '</table>';
}
include($footer);	
} elseif(isset($_GET['writefile'])){
//	if(isset($_FILES['upload'])){
	//	$name = $_FILES['upload'];
		$uploaddir = "$root/uploads";
		$uploadfile = $_FILES['upload']["$root/temp"];
		$uploaddir = $root.'/uploads/';//.$_FILES['upload']["$name"]; 
		if(is_uploaded_file($_FILES['upload'])){
			move_uploaded_file($uploadfile, $uploaddir);
			echo "File uploaded and moved!";
		} else {
			echo "Sorry, but there was no valid upload file";
		}
//	}
}
?>

the very last part is what is confusing me... how do I correctly upload the files, move them to $root/upload/ have the files name be $name? thanks for any help you may provide, Im just learning PHP.

[Unquick]

First off I noticed that you should inlcude:

enctype="multipart/form-data"

into your <form> tag. Otherwise you'll spend days trying to figure out what wrong =)

Go here for more info on file uploads:
http://ca3.php.net/manual/en/features.file-upload.php

Go here to answer your question on how to move an uploaded file to a new directory:
http://ca.php.net/manual/en/function.move-uploaded-file.php

and lastly to bring the filename into a veriable it will look something like this:
$name = $_FILES['strFile']['name'];

and if you are uploading multiple files they you can access them like this:

$name = $_FILES['strFile']['name'][0];

[0] specifying the first file uploaded. You can read them into a $name array as well, but I won't get into that unless you care =)

[benkillin]

well, after looking at the PHP manual a bit, I get this outputted to the browser:

Warning: move_uploaded_file(I:/SERVER~1/Xitami/webpages/uploads/gnumans IP.txt) [function.move-uploaded-file]: failed to create stream: No such file or directory in I:\SERVER~1\Xitami\webpages\ftest\file.php on line 61

Warning: move_uploaded_file() [function.move-uploaded-file]: Unable to move 'I:\Server Files\php\uploadtemp\php275.tmp' to 'I:/SERVER~1/Xitami/webpages/uploads/gnumans IP.txt' in I:\SERVER~1\Xitami\webpages\ftest\file.php on line 61
Sorry, but there was no valid upload file, or there was an error.

with this code in the last part:

} elseif(isset($_GET['writefile'])){
//	if(isset($_FILES['upload'])){
		$name = $_FILES['upload']['name']; 
		$uploadfile = $_FILES['upload']['tmp_name'];
		$uploaddir = "$root/uploads/".$_FILES['upload']['name']; 
		if(move_uploaded_file($uploadfile, $uploaddir)){
			echo "File uploaded and moved!";
		} else {
			echo "Sorry, but there was no valid upload file, or there was an error.";
		}
//	}
}

and the form tag looks like this:

<form action="file.php?writefile" method="post" enctype="multipart/form-data">

[benkillin]

Oh my god, I am about to kill someone! I spent the last 3 hours trying to figure out why it wasnt moving the file, then I realized I had an "s" on "$root/uploads/"... /uploads/ doesnt exist, but, /upload/ does... GRAAAAAAAAAAAAAAAAAAAAAAAAAAAHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH!

:mad: :mad: :mad: