last login and login count help

[Nathan__02]

Ok, for my site once you login it takes you to check.php where it makes sure your username and password are correct and then lets you go to the main site. I decided that i would have a last login and login count so i could keep track of who is being active...I tried so many ways to get this to work but have no idea. In case you need to kno in the DB both the last_login and login_count are 0.

check.php

<?php
session_start();
include("config.php");
include("style.css");

$username=$_POST['username'];
$password=$_POST['password'];
$query=mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password'") or die("mysql error: ".mysql_error());

echo("<center>");
echo("<BR><BR><BR><BR><BR><BR><BR>");

if (mysql_num_rows($query) > 0) 

{
        $row=mysql_fetch_array($query);

    $_SESSION['id'] = $row[id]; 
    session_register('id');        
    $_SESSION['username'] = $row[username]; 
    session_register('username'); 
    $_SESSION['password'] = $row[password]; 
    session_register('password'); 
    $_SESSION['user_level'] = $row[userlevel]; 
    session_register('userlevel'); 

$row=mysql_fetch_array($query);
$uname=$row['usename'];
$count=$row['number_logins'];
$count= $count + 1;
$date=mktime();

$updatedate=mysql_query("INSERT INTO users(last_login) VALUES ('$date')  WHERE username = '$uname'");
$updatecount=mysql_query("UPDATE users SET number_logins = '$count' WHERE username = '$uname'");

if (!$updatedate) {
echo("LAST LOGIN NOT UPDATED");
} if (!$updatecount) {
echo("LOGIN COUNT NOT UPDATED");
} else {

echo("<h2>Thank you for loggin in, $_SESSION[username]!</h2><br><a href='/home.php'>Please continue on to the main site!</a>");
}
} else {

echo("<h2>You could not be logged in for some reason!</h2>");

}

echo("</center>");

?>

btw...is there anyway i could just make it go to the main page without making them click the link?

[Nathan__02]

Does anyone have any idea?😕

[Nathan__02]

can anyone help me...? I know it isn't that hard...im just doing something wrong.

[Nathan__02]

i t hink its going wrong when i add the login_count by 1. I echo it and it says 0. I tried using $count++; but it still didnt work...and i have no clue whether i should be inserting or updating...thnx whoever helps me 🙂

[jimson]

don't be so desperate

[Nathan__02]

ok thnx

[jimson]

first, u use mysql_query directly... i wonder whether u already connect to the mysql or not since u didn't note that u are connected or not... please confirm me.
u should have something like mysql_connect() and mysql_select_db()...

then,

$query=mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password'");

i assume when $rs = mysql_fetch_array($query),
print_r($rs);
i show see the information about $username.

u got a weird style... u don't seems to indent ur code...

ah ha... maybe ur problem...
u do two times

$row=mysql_fetch_array($query);

the second mysql_fetch_array will return false becoz u already fetch the 1 recordset already before u do $_SESSION['id']=$row['id];

maybe

//	$row=mysql_fetch_array($query); // mark this line as comment.
	$uname=$row['usename'];

[jimson]

u should code ur if statement like these, otherwise, hard to debug and hard for peeps to help u. IMHO

	$updatedate=mysql_query("INSERT INTO users(last_login) VALUES ('$date')  WHERE username = '$uname'");
	$updatecount=mysql_query("UPDATE users SET number_logins = '$count' WHERE username = '$uname'");

if (!$updatedate) {
	echo("LAST LOGIN NOT UPDATED");
}

if (!$updatecount) {
	echo("LOGIN COUNT NOT UPDATED");
} else {
	echo("<h2>Thank you for loggin in, $_SESSION[username]!</h2><br><a href='/home.php'>Please continue on to the main site!</a>");
}
} else {
	echo("<h2>You could not be logged in for some reason!</h2>");
}

[jimson]

post back if u have problems...

[Nathan__02]

ok i will...i cant try it until tomorro because im not at my home pc...but thnx for helpin me this far...ill prob post tomorro whether it worked or not...thanks alot 🙂

[batman]

Try this for your code:

<?php 
session_start(); 
include("config.php"); 
include("style.css"); 

$username=$_POST['username']; 
$password=$_POST['password']; 
$query=mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password'") or die("mysql error: ".mysql_error()); 

echo("<center>"); 
echo("<BR><BR><BR><BR><BR><BR><BR>"); 

while($row=mysql_fetch_array($query))
{ 
   $usename = $row['username'];
   $pass = $row['password'];

    $_SESSION['id'] = $row[id];  
    session_register('id');         
    $_SESSION['username'] = $row[username];  
    session_register('username');  
    $_SESSION['password'] = $row[password];  
    session_register('password');  
    $_SESSION['user_level'] = $row[userlevel];  
    session_register('userlevel');  

$uname=$row['usename']; 
$count=$row['number_logins']; 
$count2 = $count++; 
$date=mktime(); 

$updatedate=mysql_query("UPDATE users SET last_login = '$date', number_logins='$count2' WHERE username = '$uname'"); 

if (!$updatedate)
 { 
echo("INFORMATION COULD NOT BE UPDATED"); 
} 
if(($username == $usename) && ($password == $pass))
 { 
echo"<h2>Thank you for loging in, $username!</h2><br><a href='/home.php'>Please continue on to the main site!</a>"; 
} 
else 
{ 

echo("<h2>You could not be logged in for some reason!</h2>"); 

} 

echo("</center>"); 

?>

-Blake

[jimson]

u are redundant with some error.

while($row=mysql_fetch_array($query)) 

there is no reason to while here becoz we don't expect $row to be more than 1 row.
and thats why nathan use

if (mysql_num_rows($query) > 0)  

in his code... which IMHO
is better with

if (mysql_num_rows($query) == 1)  

no point to session_register('id'); if it gonna be a WHILE.. 🙁