Image Upload Problems!

[Langridge]

HI

I am having some trouble with limiting the images that can be uploaded to ONLY GIF/JPEG/JPG

The problem is it will allow any file type to be uploaded, and dosnt limit it to just these.

Here is the code I am using to test for image type:

if ($FILES['imagefile']['type'] == "image/gif" OR "image/jpeg" OR "image/jpg"){
//if ($FILES['imagefile']['type'] == "image/gif"){
copy ($FILES['imagefile']['tmp_name'], "images/upload/".$FILES['imagefile']['name'])

or die ("Could not copy");

Thanks

[theeper]

Change the if statement from

if ($_FILES['imagefile']['type'] == "image/gif" OR "image/jpeg" OR "image/jpg")

to

if ($FILES['imagefile']['type'] == "image/gif" || $FILES['imagefile']['type'] == "image/jpeg" || $_FILES['imagefile']['type'] == "image/jpg")

[theeper]

BTW, not tring to confuse you, but the || (double pipe) operator can be used where the OR's go.

[Langridge]

Thanks, and cheers for making it nice and simple:

HOWEVER - now it only allows gif files to be uploaded...(the first condition)...

Any ideas?

[theeper]

Echo the $_FILES array and verify it's contents. I am not sure if all browsers handle the file type the same. You may want to do a string comparison on the actual filename instead.