can anyone see whats wrong with this?

djdaz

When i try to run this script i get the error, Parse error: parse error, unexpected $ in /tier-2/pwpstore2/6/generalsworld/htdocs/scripts/php/test/newsup/loginaction.php on line 25, can anyone see why?
Line 25 is the last line of the script, the ?>

<?php
$username=($_POST['username']);
$password=($_POST['username']);
if(strstr($username, "djdaz") && strstr($password, "test"))
{ include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml');?>
Welcome <?php echo $username ;?>, what do you wish to do?
<br>
<a href="/addnews.php?username=<?php echo $username ;?>">Add news</a><br>

<?php
include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml') ;}
else
{if(strstr($username, "djdaz") && strstr($password, "tester"))
{ include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml');?>
Welcome <?php echo $username ;?>, what do you wish to do?
<br>
<a href="/addnews.php?username=<?php echo $username ;?>">Add news</a><br>
<?php
include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml') ;}
else
{ include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml') ;?>
Your username or password is incorrect
<?php
include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml') ;}
?>

Thanks

FoxhoundX

Could you please enclose your code into [PHP][/PHP] Tags, and note what line 25 is?

Thanks

djdaz

ok i changed it.

non_zero

that means you forgot a bracket at the end.

you really need to learn to organize your code better; the if statements are too jumbled up to make sense of.

<?php
$username=($_POST['username']);
$password=($_POST['username']);
if(strstr($username, "djdaz") && strstr($password, "test")) {
    include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml');?>
    Welcome <?php echo $username ;?>, what do you wish to do?
    <br>
    <a href="/addnews.php?username=<?php echo $username ;?>">Add news</a><br>
    <?php
    include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml');
}
else{
    if(strstr($username, "djdaz") && strstr($password, "tester")) {
        include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml');?>
        Welcome <?php echo $username ;?>, what do you wish to do?
        <br>
        <a href="/addnews.php?username=<?php echo $username ;?>">Add news</a><br>
        <?php
        include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml');
    }
    else { include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml');?>
        Your username or password is incorrect
        <?php
        include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml');
    }
//this is where you missed a bracket
}

djdaz

ahh, all works now, i agree i must get into the habit of making neat code.

cdbsi

$username=($POST['username']);
$password=($POST['username']);

needs to be:

$username=($POST['username']);
$password=($POST['password']);

= = = = = = = =

notice on the second line; you had 'username' instead of 'password'