table sorting

[tazgalsinh]

am trying to format a table. I want the table to go three columms along and then start on next row but i can seem to get it to work>

the code i have so far is

<table width="490" border="0">
                    <?php  

                    $i=0; 
                    do {  

                    if($i%3==1) echo("<tr>");?> 

                  <td width="230" height="49"><div align="center"><?php echo $row_Recordset1['typeofproduct']; ?></div></td>
                  <td width="183"><a href="catalog.php?typeid=<?php echo $row_Recordset1['typeID']; ?>  &id1=<?php echo rawurlencode($row_Recordset1['typeofproduct']); ?>"><img src="
				  <?php echo $row_Recordset1['imageURL']; ?>" width="100" height="60" border="1"></a></td>
                </tr>
				<? if($i%3==0) echo("</tr>"); ?> 

                <?php  
                $i++; 
				?>                          
                <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>                   

              </table>

[laserlight]

This could be what you are looking for:

<table width="490" border="0">
<?php
$i = 0;
while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)) {
	if ($i % 3 == 0)
		echo "<tr>";
?>
<td width="230" height="49"><div align="center"><?php
	echo $row_Recordset1['typeofproduct'];
?></div></td>
<td width="183"><a href="catalog.php?typeid=<?php
	echo $row_Recordset1['typeID'];
?>&amp;id1=<?php
	echo rawurlencode($row_Recordset1['typeofproduct']);
?>"><img src="<?php
	echo $row_Recordset1['imageURL'];
?>" width="100" height="60" border="1"></a></td>
<?php
	if ($i % 3 == 0)
		echo "</tr>";
	$i++;
}
?>
</table>

[tazgalsinh]

thanks for the reply, when i use that it seems to be missing some records out,

the orginal script with no sorting is

   <?php do { ?>
                    <tr> 
                      <td width="230" height="49"><div align="center"><?php echo $row_Recordset1['typeofproduct']; ?></div></td>
                      <td width="183"><a href="catalog.php?typeid=<?php echo $row_Recordset1['typeID']; ?>&id1=<?php echo rawurlencode($row_Recordset1['typeofproduct']); ?>"><img src="<?php echo $row_Recordset1['imageURL']; ?>" width="100" height="60" border="1"></a></td>
                    </tr>
                    <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>

              </table>

[laserlight]

what do you mean by missing some records out?

The code should be the same, just that it has better formatting and using a while loop which makes more sense than a do while loop.

[tazgalsinh]

it seems to be missing the top record out

[laserlight]

ah, I see.
Do you call
$row_Recordset1 = mysql_fetch_assoc($Recordset1);

outside the loop?
That's probably why.
You could change back to a do while loop in that case, but I suspect that that call was actually not needed.

[tazgalsinh]

yes there was that call but i deleted it now and all the records are now displayed.

Now the formatted is strange.

it is formatted like this.(i will try and draw it). the blocks being the image.(imageURL)

'typeofproduct'[___]

'typeofproduct'[] 'typeofproduct' []

'typeofproduct'[___]

'typeofproduct'[] 'typeofproduct' []

'typeofproduct'[___]

[laserlight]

My mistake, I should have checked your logic but I didnt.

You wanted 3 columns.
So we have to modify the $i looping a bit.

Instead of

    if ($i % 3 == 0) 
        echo "</tr>"; 
    $i++; 

We should use:

    if ($i % 3 == 2) 
        echo "</tr>"; 
    $i++; 

This comes up with another problem: what if the number of records is not a multiple of 3?
There are various ways to solve this, but it depends on what you want.

[tazgalsinh]

that works great. thank you alot for your help now. take care.

[tazgalsinh]

one final question, how do i space out the columns?