Function within Class problem

[Chris_Evans]

Hi there,
I've written the following function which is called by another function, both of which are within the same class.

		function dbquery($query)
		{
			$connection = mysql_connect($this->dbserv,$this->dbuser,$this->dbpass)
				or die(mysql_error());
			$ret = mysql_db_query($this->$dbname,$query,$connection)
				or die(mysql_error());
			return $ret;
		}

Now when this function is called I get "No database selected error".

Now that function uses the following two functions to operate:

		function call_dbfunction()
		{
			$this->dbfunction("localhost","root","","aupairagency");
		}

	function dbfunction($dbserv,$dbuser,$dbpass,$dbname)
	{
		$this->dbserv = $dbserv;
		$this->dbuser = $dbuser;
		$this->dbpass = $dbpass;
		$this->dbname = $dbname;
	}

Any ideas?

Thanks in advance,

Chris

[ahundiak]

Too many dollar signs.

$this->$dbname

[Chris_Evans]

Woo yeah! I'll reply if it works tommorow when I'm working on it again but that looks like the problem... I can blame it on tiredness! 🙂

Thanks,

Chris

[Chris_Evans]

I tested it anyway lol

<?php
// The UK Au Pair Agency Web Site
// was designed by First Choice Junction
// 10 Marketing Ltd in June 2003

class News
	{
		function call_dbfunction()
		{
			$this->dbfunction("localhost","root","","aupairagency");
		}

	function dbfunction($dbserv,$dbuser,$dbpass,$dbname)
	{
		$this->dbserv = $dbserv;
		$this->dbuser = $dbuser;
		$this->dbpass = $dbpass;
		$this->dbname = $dbname;
	}

	function dbquery($query)
	{
		$connection = mysql_connect($this->dbserv,$this->dbuser,$this->dbpass)
			or die(mysql_error());
		$ret = mysql_db_query($this->dbname,$query,$connection)
			or die(mysql_error());
		return $ret;
	}

	function retrieve_news($table)
	{
		$this->table = $table;
		$query = "SELECT title,body,date FROM $this->table";
		$result = $this->dbquery($query);
		$rowcount = mysql_num_rows($result);
		if($rowcount > 0)
			{
				echo "<table width=\"100%\" align=\"center\">";
				While($array = mysql_fetch_array($result))
					{
						echo "<tr><td class=\"newstitle\" width=\"100%\">";
						echo $array['title'];
						echo "</td></tr><tr><td class =\"newsbody\" width=\"100%\">";
						echo $array['body'];
						echo "</td></tr><tr><td class =\"newsfooter\" width=\"100%\">Posted on: <i>";
						echo $array['date'];
						echo "</i>, courtesy of The UK Au Pair Agency</td></tr><tr><td>&nbsp;</td></tr>";
					}
					mysql_free_result($result);
				echo "</table>";
			}
			else
			{
				echo "<table width=\"100%\" align=\"center\"><tr><td class=\"newstitle\" width=\"100%\">Sorry...</td></tr>";
				echo "<tr><td class=\"newsbody\" width=\"100%\">...but there is currently no posted news available. Please feel free to browse around and look at our selections around the site. There are two main areas on this site, Families and Au Pairs. Simply click on the relevant catergory from the first menu, then click on the relevant links in the second menu.&nbsp;&nbsp;Thank you, The UK Au Pair Agency</td></tr>";
				echo "<tr><td class=\"newsfooter\" width=\"100%\">Error written by <i>The UK Au Pair Agency Management</i>.</td></tr>";
				echo "</table>";
			}
	}
}
?>

That's the full script, it still says the same thing. 🙁

Thanks,

Chris

[ahundiak]

And somewhere you do

$news = new News();
$news->call_dbfunction();
$news->retrieve_news('table_name');

And I assume you can connect to the database from mysql or some other admin tool? No chance the dbname is spelled wrong? echo out $this->dbmane just to verify it's correct.

Also, the manual says this function should not be used anymore. So you might try using mysql_select_db();

http://www.php.net/manual/en/function.mysql-db-query.php

[laserlight]

yeah, mysql_db_query() is deprecated

maybe it would be better to connect and select a DB, then use mysql_query()