Link Function

Hylian

I'm currently trying to make a function to sort a list of links where it follows this scheme:

Category 1
--Link 1
--Link 2
Category 2
--Link 1
--Link 2

I have the databse scheme correct...yet I just can't get the loop to display it like above. It repeats the same link over and over...rather than moving onto the next category after it's done all the links n the previous category. Could you please help?

function makelinks($styleid,$type){
	global $db, $n;
	if($type=="single"){
		$searchquery = "";
	} elseif($type=="left"){
		$searchquery = "AND menuside='1' ";
	} elseif($type=="right"){
		$searchquery = "AND menuside='2'";
	}
	$info_style = $db->query_first("SELECT linkformat,catformat,linkblockformat FROM hh_style WHERE id = '$styleid'");
	$cat_query = $db->query("SELECT * FROM hh_links WHERE iscat='1' ".$searchquery."ORDER BY numorder ASC");
	while($category = $db->fetch_array($cat_query)) {
		$link_output .= str_replace("%name%", $category['name'], $info_style['catformat']);
		$link_query = $db->query("SELECT * FROM hh_links WHERE islink='1' AND parentcat='".$category['id']."' ORDER BY numorder ASC");
		while($link = $db->fetch_array($link_query)) {
			$link_output .= str_replace("%name%", $link['name'], $info_style['linkformat']);
			$link_output .= str_replace("%url%", $link['url'], $link_output);
			$link_output .= str_replace("%target%", $link['target'], $link_output);
		}
	}
	return $link_output;
}

BuzzLY

what is "menuside?"

In the last else condition, you are missing a space at the end, after '2':

$searchquery = "AND menuside='2'";
                           here ^

I don't know what your type value is, so I don't know if that's causing a problem with your SQL query.

Otherwise, I'd look closer at the link_output variable. Echo your variables to the screen as you are building your output to see what's happening.

Hylian

it's not the else that's messing it up...because it's the "single" right now.

I'll try echoing it like you said...

Hylian

Damn...I'm an idiot...lol

Take a look at the second while loop. I have it concatinating the string while it's replacing each variable...so after each replacement...it's adding to the output...which shouldn't happen. I just made it a separate variable then added it after it has replaced all the stings...and it works perfectly... 🙂

BuzzLY

I had a feeling something strange was going on there LOL. However, my assessment of your else still stands -- if you don't fix that line, you will get an error eventually.

Glad to hear you fixed it. You may want to click the Resolved link at the bottom of the page...