How to change this to one line

Cynthia_Blue

Is it possible to change this code into one line?
If so, how? 🙂
Thanks.

if (strpos($component, "*") === false) {
// Not Found, Do Nothing
} else {
  $component =  str_replace("*", "%", $component); 
}

kevinsequeira

strpos($component, "*")?$component =  str_replace("*", "%", $component):$component = $component;

reg
kevin

Cynthia_Blue

He he cool thanks. Doesn't work, though. If I only put a in the field (first position) it comes back not replacing the char. :p Most likely because the first field is a 0...? If I put a in the 2nd or other position, it works. 🙂

kevinsequeira

use strstr instead of strpos

reg
kevin

philipolson

A couple more ways:

<?php
// If you mean ternary operator, than this
$component = (false === strpos($component, '*')) ? $component : str_replace('*', '%', $component);

// I prefer this, it's more readable {braces optional}
if (strpos($component, '*') !== false) {
    $component = str_replace('*', '%', $component);
}

// Or just this, see below
$component = str_replace('*', '%', $component);
?>

This assumes that more often then not there will not be a replacement otherwise just use str_replace without any strpos check as it won't hurt.

strstr is less efficient than strpos as it returns a string instead of of a simple integer so using a strict === or !== is the right idea here. The difference of course depends on the size of $component.

Cynthia_Blue

Ah thank you very much. 🙂 I will use your third option

$component = str_replace('*', '%', $component);

as it's short and simple and seems to be working well. 🙂

So much to learn... 😉