What Am I Doing Wrong?

[Lchris006]

Hi there, can someone help me out and tell me what i am doing wrong here

$supported_extensions = array(".jpg", ".png", ".gif", ".swf");

global $supported_extensions;

$chrisimg = "<img id="\".ID_PICTURE."\" src=\"$picture_url\"  alt=\"$picture_url\"";

if ($ext=='jpg') echo("$chrisimg");
else
if ($ext=='png') echo("$chrisimg");
else
if ($ext=='gif') echo("$chrisimg");
else
if ($ext=='swf');
print"<object width=\"550\" height=\"400\"><param name=\"movie\" value=\"$picture_url\"><embed src=\"$picture_url\" width=\"550\" height=\"400\"></embed></object>";

hopefully it seperates images from flash files and displays them accordingly, its not working though, any help would be kindly appreciated!

Chris

[uniflare]

echo the $ext var, if its right, then try this:

global $supported_extensions;

$chrisimg = "<img id="".ID_PICTURE."" src=\"$picture_url\"  alt=\"$picture_url\"";

if ($ext=='jpg') echo("$chrisimg");
else
if ($ext=='png') echo("$chrisimg");
else
if ($ext=='gif') echo("$chrisimg");
else
if ($ext=='swf')
print"<object width=\"550\" height=\"400\"><param name=\"movie\" value=\"$picture_url\"><embed src=\"$picture_url\" width=\"550\" height=\"400\"></embed></object>";

[skripty]

I dont really understand what you are trying to do... you make an array containing extensions but never use it.

One problem could be that you are making a Variable global after defining its contents.

Maybe if you could explain in a little more detail about what you are trying to do i will be able to help you further.

Thanks
John

ADDON

Uniflare is correct but there is no need for all those If and else... try this

if ($ext=='jpg' or $ext=='png' or $ext=='gif') {

  echo $chrisimg; 

}elseif ($ext=='swf'){

  echo"<object width=\"550\" height=\"400\">
  <paramname=\"movie\" value=\"$picture_url\">
  <embed src=\"$picture_url\" width=\"550\"
  height=\"400\"></embed></object>";

}else{

  //you can add code to this section to deal with
  //unsupported types.

}

Also note that in the array you made you have included the point in the extension eg .jpg not jpg

Also it is better if you use braces ( { } ) to open and close your statements... php may not run your code correctly otherwise.

Thanks again

[skripty]

also....

this is the corrected version of you statement.

$chrisimg = "<img id=\"".$ID_PICTURE."\" src=\"$picture_url\"  alt=\"$picture_url\""; 

Thanks

[uniflare]

try this:

$chrisimg = '<img id="'.$ID_PICTURE.'" src="'.$picture_url.'"  alt="'.$picture_url.'">';

if (($ext) == ("jpg"||"gif"||"png")) { 

  echo $chrisimg;  

}elseif ($ext=='swf'){ 

  echo'<object width="550" height="400"> 
  <paramname="movie" value="'.$picture_url.'"> 
  <embed src="'.$picture_url.'" width="550" 
  height="400"></embed></object>'; 

}else{ 

  //you can add code to this section to deal with 
  //unsupported types. 

}

:p mine is smaller (turned into a game now, lol)

---

if everyone likes different things, why does all my m8's like ice cream?😕

[skripty]

ok... if you want to play games.... make this smaller...

if ($a == 1) {

 $b = 'one';

} else {

$b = 'other';

}

Im hoping you dont know this... but give it a go... lol

Skripty

[foofoobar]

It looks like you aren't concatenating correctly. You concatenate like this...

$string="I like to eat ".$children." dipped in ".$syrup."!";

Also, HTML does not require quotes (excet when adding in line code such as javascript). So you can get rid of all those additional quotes. Following these simple principles, your line would read like this...

$chrisimg = "<img id=".$ID_PICTURE." src=".$picture_url." alt=".$picture_url.">";

[ucbones]

if ($a == 1) { 
     $b = 'one'; 
} else { 
    $b = 'other'; 
}

or

if ($a == 1)   $b = 'one'; 
else $b = 'other'; 

sure that's not what you meant though... 😉

ucbones

[uniflare]

ok here is it smaller:

$b='other';
if($a=1)$b = 'one';

:o

[skripty]

For those interested... the best way to do

if ($a == 1) { 

 $b = 'one'; 

} else { 

$b = 'other'; 

}

is...

$b = ($a==1) ? 'one' : 'other';

This is a c-style construct with syntax...

[var] = [condition] ? [if true] : [if false];

Hope u like it

Thanks