[Resolved] updating database

SureFire

I'm trying to update my database with a form. I'm using an online tutorial, but for somereason it just isn't working. No errors or anything, it just doesn't update it.

Here is page one:

<?



$id=$_GET['authid'];
$username="xxx";
$password="xxx";
$database="xxxx";
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

$query="SELECT * FROM authors WHERE authid='$id'";
$result=mysql_query($query);
$num=mysql_num_rows($result);
mysql_close();


$i=0;
while ($i < $num) {

$name=mysql_result($result,$i,"name");
$prefix=mysql_result($result,$i,"prefix");
$contributorsince=mysql_result($result,$i,"contributorsince");
$latestsub=mysql_result($result,$i,"latestsub");




++$i;
}




?>

<form action="updated.php" method="post">
<input type="hidden" name="ud_id" value="<? echo "$id"; ?>">
Name: <input type="text" name="ud_name" value="<? echo "$name"?>"><br>
Prefix: <input type="text" name="ud_prefix" value="<? echo "$prefix"?>"><br>
Contributor Since: <input type="text" name="ud_contributorsince" value="<? echo "$contributorsince"?>"><br>
Latest Submission: <input type="text" name="ud_latestsub" value="<? echo "$latestsub"?>"><br>

<input type="Submit" value="Update">
</form>

I know the GET function is working. So thats not the problem

Page TWO:

<?

$username="xxxx";
$password="xxx";
$database="xxx";

$ud_id=$_POST['ud_id'];
$ud_name=$_POST['ud_name'];
$ud_prefix=$_POST['ud_prefix'];
$ud_contributorsince=$_POST['ud_contributorsince'];
$ud_latestsub=$_POST['ud_latestsub'];


mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="UPDATE authors WHERE authid='$ud_id' SET name='$ud_name' prefix='$ud_prefix' contributorsince='$ud_contributorsince' latestsub='$ud_latestsub'";
mysql_query($query);
echo "Record Updated";
mysql_close();
?>

Norman_Graham

Hi Surefire

I think there may be some slight confusion here, but let's check first: you want to update a row in a table which contains the field authid, correct? Where is authid coming from? ON your first page you have a GET for authid - get from where?

If this isn't relevant, then perhaps the lack of semicolons in the echo statements in your form are causing a problem. You have a semicolon in the first one, but not in the others:

<form action="updated.php" method="post"> 
<input type="hidden" name="ud_id" value="<? echo "$id"; ?>"> 
Name: <input type="text" name="ud_name" value="<? echo "$name"?>"><br> 
Prefix: <input type="text" name="ud_prefix" value="<? echo "$prefix"?>"><br> 
Contributor Since: <input type="text" name="ud_contributorsince" value="<? echo "$contributorsince"?>"><br> 
Latest Submission: <input type="text" name="ud_latestsub" value="<? echo "$latestsub"?>"><br>

Are you sure these echo statements are not causing a parse error? I would expect them to do so.

The next thing is, and I think this might be the real problem, you've specified $i<$num in your while statement ... but if $num only equals 1, then $i<$num will be zero. Don't you want $i<=$num?

HTH

Norm

SureFire

Your statement about wanting to retrieve data from a table containing authid is correct authid is just the authors ID number which is an auto increment.

I get the ID from the url on the page before these two theres a link, I know that the GET command is working. I fixed all the echo statements but that didn't fix anything. and I added the <= equal to and this time I got an error:

Warning: mysql_result(): Unable to jump to row 1 on MySQL result index 3 in /home/internet/www/www/update.php on line 21

Here is what the first page looks like.
http://www.internetstuntman.com/update.php?authid=8

When you change the stuff in the boxes, then hit update it says Record Updated, but when I go and view the table, it hasn't been.

Thanks for all the suggestions!

Norman_Graham

Well, your code will say "record updated" whatever happens since you have no conditions placed on this message - you echo "record updated" no matter what happens. I just tried it.

Is the $_POST[] working?

Oh ... wait a minute ... you need to do this:

for ($i=0; $i<=$num; $i++)

++$i; is not a legal statement. Your while routine can't possibly work. Sorry for not spotting this earlier.

Norm

SureFire

do you mean replace ++$i; with $i++?

I did that just now and nothing has changed. I believe the POST is not working, do you know how I could check on that?

Thanks for all your help so far!

Norman_Graham

No, I mean your while routine won't work at all. You need to replace it with this:

for ($i=0; $i<=$num; $i++)
{
$name=mysql_result($result,$i,"name"); 
$prefix=mysql_result($result,$i,"prefix"); 
$contributorsince=mysql_result($result,$i,"contributorsince"); 
$latestsub=mysql_result($result,$i,"latestsub");
}

To find out if the post statement is working, echo out the variables.

HTH

Norm

SureFire

Ok, I just started back over from scratch and everything worked..
I just must have typed in something wrong.

My routine is working somehow..

Thanks for all the help Norman!

Norman_Graham

Glad to be of assistance. You might want to mark this thread as resolved now.

Best o luck

Norm

Oh, I see you did that already. Well done. 😃