[Resolved] Writing Javascript

paul_mac

I'm trying to get PHP to write

ONCLICK="return doEvent("delete",$counter,"yes");"

and all I get is

ONCLICK="return doEvent(delete,$counter,yes);"

I've tried putting \" in place of the single quote and I've tried using variables i.e. $what2Do = "delete" and $confirm = "yes" earlier in the page
and echoing

ONCLICK=\"return doEvent(\"$whatToDo\",$counter,\"$confirm\");\"

but it doesn't seem to work and I still get javascript error when the page loads.

Thanks

jayant

The problem is with the javascript:-

ONCLICK="return doEvent("delete",$counter,"yes");"

It should be

ONCLICK="return doEvent('delete',$counter,'yes');"

(single quotes inside) simply echo it.
you can escape single quotes though optional here

jkohns

I think it's in the way you are using double quotes...try:

print 'ONCLICK="return doEvent(\'delete\',$counter,\'yes\');"';

paul_mac

Thanks for the replies neither worked but I have managed to get it to work. firstly the javascript I posted was part of a longer line:

echo "<TD CLASS='tablerowred'><INPUT TYPE='submit' VALUE='Confirm' ONCLICK='return doEvent($delete,$counter,$confirm)'></TD></TR>\n";

and what I did was declare 2 php variables at the start of the program:

$confirm = "ohyes";
$delete = "dlt";

$counter is a counter for the loop I'm working through

I then declared 2 JavaScript variables:
var dlt = "delete";
var ohyes = "yes";

PHP writes the JavaScript as variable names the contents of which are then picked up and used in the program.

Thanks again

paul_mac

Since posting the reply I have had futher problems writing javascript which the orginal replies to my original query did not resolve. However I now do the following if I wish to write and onclick statement:

$jsString = "onClick = ".chr(34)."subWindow(".chr(39).$details[0].chr(39).");return false;".chr(34);

and then insert the $jsString variable in the line as follows:

echo "<A HREF='company/$details[0].html' $jsstring><IMG SRC='images/logos/$details[0].gif' BORDER='0'></A></TD>";