Simple fuction doesn't work

[miracleman]

I've been working on this function for a while now. I've tried it several ways, but I can't seem to get it to return correctly.

The first return works, but it never makes it to the second return. I'm sure the problem is simple, but my PHP skills don't seem to be up to the task.

Any help would be REALLY good. Here's the code:

function getNoShipping($product)
{
$result = mysql_query(sprintf("SELECT * FROM defaultPrices where product = '%s'", $product), $GLOBALS["g_db"]);
if ($result) {
$myrow = mysql_fetch_array($result);
if ($myrow["ship"] = 1)
return "";
if ($myrow["ship"] = 0)
return "&shipping=0.00";
} else {
return "";
}

}

[lanjoky]

<?
function getNoShipping($product) 
{ 
     $result = mysql_query(sprintf("SELECT * FROM defaultPrices where product = '%s'", $product), $GLOBALS["g_db"]); 

 if ($result) { 
    $myrow = mysql_fetch_array($result); 
    if ($myrow["ship"] == 1) // need double '=' when doing compare
        return ""; 
     if ($myrow["ship"] == 0) // need double '=' when doing compare
        return "&shipping=0.00"; 
} else 
     return ""; 
}
?>

THat should fix it 🙂

GL

[miracleman]

Logan,

Thanks for the reply. Unfortunatly, that doesn't work as expected either. But the new thing is that now the secord return works and is returned no matter what value $myrow["ship"] equals.

Thanks again.

Donnie

[kevinsequeira]

can u post the edited code

reg
kevin

[lanjoky]

right after $myrow = mysql_fetch_array($result); do an

echo $myrow["ship"]; and tell me what values are beeing printed to the screen to do this you will need to comment out your returns I believe

[miracleman]

This function returns no result:

<?php
function getNoShipping($product)

{

$result = mysql_query(sprintf("SELECT * FROM defaultPrices where product = '%s'", $product), $GLOBALS["g_db"]);

 if ($result) {  
    $myrow = mysql_fetch_array($result);  
     echo $myrow["ship"];
     //if ($myrow["ship"] == 1) // need double '=' when doing compare 
       // return "";  
     //if ($myrow["ship"] == 0) // need double '=' when doing compare 
      //  return "&shipping=0.00";  
} //else  
    // return "";  

}
?>

Here is my table:
#

Table structure for table defaultPrices

#

CREATE TABLE defaultPrices (
product text NOT NULL,
price double NOT NULL default '0',
ship double NOT NULL default '0'
) TYPE=MyISAM;

#

Dumping data for table defaultPrices

#

INSERT INTO defaultPrices VALUES ('Shipped 4x6', '0.39', '1');
INSERT INTO defaultPrices VALUES ('Shipped 5x7', '1.99', '1');
INSERT INTO defaultPrices VALUES ('Shipped 8x10', '4.95', '1');
INSERT INTO defaultPrices VALUES ('Pickup 4x6', '0.39', '0');
INSERT INTO defaultPrices VALUES ('Pickup 2 Wallets', '0.9', '0');
INSERT INTO defaultPrices VALUES ('Pickup 5x7', '1.99', '0');
INSERT INTO defaultPrices VALUES ('Pickup 8x10', '4.95', '0');
INSERT INTO defaultPrices VALUES ('Pickup 8x12', '5.95', '0');
INSERT INTO defaultPrices VALUES ('Pickup - 11x14', '9.95', '0');
INSERT INTO defaultPrices VALUES ('Pickup 12x18', '14.95', '0');
INSERT INTO defaultPrices VALUES ('Shipped 8x12', '5.95', '1');
INSERT INTO defaultPrices VALUES ('Shipped 11x14', '9.95', '1');
INSERT INTO defaultPrices VALUES ('Shipped 12x18', '14.95', '1');
INSERT INTO defaultPrices VALUES ('Shipped 2 Wallets', '0.9', '1');

[kevinsequeira]

<?php
function getNoShipping($product){
// dont u need to connect to database first ??
$query = "SELECT * FROM defaultPrices where product = '".$product."'";
$result = mysql_query($query);
echo $query;
if (mysql_error()){
	echo mysql_error();
}
if ($result) {
  $myrow = mysql_fetch_array($result);
  echo $myrow["ship"];
  if ($myrow["ship"] == 1){
   	return "";
		}elseif($myrow["ship"] == 0){
	   return "&shipping=0.00";
		}else{
 	  return "";
		}
}
?>

reg
kevin

[miracleman]

Kevin,

That was helpful to teaching me a little about PHP, but it still doesn't work as I thought it might. I rewrote the function to something like this:

function getNoShipping($product){
$result = mysql_query(sprintf("SELECT * FROM defaultPrices where product = '%s'", $product), $GLOBALS["g_db"]);

if ($result) { 

$myrow = mysql_fetch_array($result);
echo $myrow["ship"];
if ($myrow["ship"] == 1){
return "";
}elseif($myrow["ship"] == 0){
return "&shipping=0.00";
}else{
return "";
}
}
}

"&shipping=0.00" returns for all results. 🙁

Here is more info on this:

Starting with Web page, I'm attempting to call from here with a form element:

<?php
echo "<font size=\"1\"><b>Print this photo:</b></font><br>";
echo "<SELECT size=1 name=\"Product\" onChange=\"if(options[selectedIndex].value) window.open(options[selectedIndex].value)\">";
echo "<OPTION value=>Choose an Option&nbsp;</option>";
ButtonsForAllProducts($GLOBALS["id"], $gallery->album->fields["name"]);
echo "</select>";
?>

This call this function:

function ButtonsForAllProducts($picture, $album)
{
$result = mysql_query(sprintf("SELECT * FROM defaultPrices", $product), $GLOBALS["g_db"]);
if ($result) {
while ($myrow = mysql_fetch_array($result)) {
$ship = getNoShipping($product);
$productName = $myrow["product"];
$finalPrice = getFinalPrice($album, $GLOBALS["id"], $productName);
echo payPalProductButton($ship, $picture, $productName, $finalPrice);
echo " ";
}
} else {
// There are no products. Probably shouldn't output anything.
echo "Not for sale";
}
return TRUE;
}

Which calls getNoShipping and this function:

function payPalProductButton($ship, $picture, $product, $price)
{
if ($price == $GLOBALS["g_notForSale"]) {
return $product . "(n/a)";
} else {
return "<option value=\"https://www.paypal.com/cart/add=1&business="
.
$GLOBALS["g_paypalEmail"]
.
$ship
.
"&item_name="
.
$product
.
"+-+"
.
$picture
.
"&item_number=&amount="
.
sprintf("%01.2f", $price)
.
"\">"
.
$product
.
"($"
.
sprintf("%01.2f", $price)
.
")</option>";
}
}

The database is connected with an include:

include($GALLERY_BASEDIR . "mods/constants.php");

Which reads something like this (of course with working values:

$GLOBALS["g_dbUser"] = "username";
$GLOBALS["g_dbPassword"] = "password";
$GLOBALS["g_dbName"] = "database";

$GLOBALS["g_paypalEmail"] = "name%40domain.com";

[miracleman]

Thanks for all of your help. I was able to solve the problem!

Basically, I simplified the call to that fuction.

Instead of calling getNoShipping in ButtonsForAllProducts and then passing that variable to payPalProductButton, I called getNoShipping in payPalProductButton.

I guess I should have been thinking simple.

Here is the final getNoShipping fuction that worked:

function getNoShipping($product){
$result = mysql_query(sprintf("SELECT * FROM defaultPrices where product = '%s'", $product), $GLOBALS["g_db"]);

if ($result) { 

$myrow = mysql_fetch_array($result);

if ($myrow["ship"] == 1){
return "";
}elseif($myrow["ship"] == 0){
return "&shipping=0.00";
}else{
return "";
}
}
}

Without your help I would not have been able to write this fuction correctly!

Thanks!

Donnie

[kevinsequeira]

could u mark this resolved if the thread is over, there is a link below, thanks

reg
kevin