Please help

artizan

Hello peeps, im new to all this and have been trying hard for the last few days to get my login script working. Started with many errors, but i have managed to get it down to one problem, and without it throwing errors at me.....yippe...
this is my php script, and im using a login.html page before this for the user input...

index.php

<html>
<head><title> Grab MySQL Data </title></head>
<body bgcolor="#FFFFFF">

//check that the form fields are not blank
if (empty($username) || empty($password)) {
echo "error";
}
else{

$conn = mysql_connect ("localhost", "root" ,"password");
mysql_select_db("peeps" ,$conn);

$POST['$username'];
$POST['$password'];

$result = mysql_query("select * from users where username='username' AND password='password'", $conn);

//check that at least one row was returned

$rowCheck = mysql_num_rows($result);
if($rowCheck > 0){
while($row = mysql_fetch_array($result)){

//start the session

session_start();

echo 'Success!';
}
}
}
?>

all that this code does at the minute is display error, which is returned from my echo at the top... even if password fields are entered it displays this...

please help if you can..
thanks in advance

Thora_Fan

What error is it displaying?

artizan

Hi thanks for the reply..

its not giving me any paser errors, but just displays the echo "error" at the top of my code.. even if password and username fields have data, it just keeps displaying error from echo error..

Art

chadu

What does your form on index.html look like?

artizan

<html>
<head>
<title>login</title>
</head>
<body>
<form method="POST" action="login.php">
Username: <input type="text" name="username" size="20">
Password: <input type="password" name="password" size="20">
<input type="submit" value="Submit" name="login">
</form>
</body>
</html>

Thanks
Art

Thora_Fan

Gotcha. I misinterpeted what you were talking about.

My suggestion is that any time throughout your script where you are referring to variables that have been passed via POST or GET (in this case, $username or $password, you refer to them as $POST[username] and $POST[password]. If register_globals is turned off in your php.ini file, just referring to a variable as $password that has been passed from another page won't work.

trooper

U sure thats right cuz at the top of the first post you have said "index.php" not login.php which is what your form is posting to

?????

chadu

I think if you follow Thora_Fan's suggestion you will figure this out.

artizan

Originally posted by trooper
U sure thats right cuz at the top of the first post you have said "index.php" not login.php which is what your form is posting to

?????

Sorry typo.... it's login.php

Thora.... thanks for the tip, will try that..

trooper

Just a small point in addition to thora_fan's last note

If you use exctract($_POST) then all the variables will be able to be used as you have done.

Thora_Fan

Wow, I wish I had known about extract(). Would have saved me a few lines of code here and there. Thanks for mentioning that, I think my PHP life will be that much easier from now on.

trooper

Its amazing what a rainy sunday afternoon can bring up 😃

artizan

Ba&8 ard still not working...

Thanks for ya input anyways ppl......... more head scratching and taking my frustration out on the neighbor i think….. 😃

artizan

Well it was another very late night trying to get this code working, but still not joy...

Anyone else have any productive suggestions, because i could really do with the input.

PS same thing as stated above happends.....error from echo, nothing more.

Thanks in advance
Art 🙂

artizan

Ok, i have changed the php code around and most of it works im sure. I got no Parser erros, rather it just dont log me in. Please help, been working on this for sometime now.
PHP CODE LOGIN.PHP
<?
$POST['username'];
$POST['password'];

$connection = mysql_connect("localhost", "root", "blah")
or die ("Couldn't connect to server.");

$db = mysql_select_db("peeps", $connection)
or die ("Couldn't select database.");

$sql = "SELECT id
FROM users
WHERE username='$username' and password='$password'";

$result = mysql_query($sql)
or die("Couldn't execute query.");

$num = mysql_numrows($result);

if ($num == 1) {

echo "<P>You are a valid user!<br>";
echo "Your username is $username<br>";
echo "Your password is $password</p>";

} else if ($num == 0) {

echo "You are not authorised"

}

?>
Problem is, is that it keeps showing "You are not authorised".... so i think its a problem with my POST, but not sure what

login.HTML
<html>
<head>
<title>Login</title>
</head>
<body>
<form action="login.php" method="POST" >

Username: <input type="text" name="username" size="20">
Password: <input type="password" name="password" size="20">
<input type="submit" value="Submit" name="login">
</form>
</body>
</html>

Thanks for ya input

Art

chadu

this doesn't look good:

try:

trooper

Why have you go these two lines on their own at the top ????

There is no need to have them there


$_POST['username'];
$_POST['password'];

Instead put extract($_POST);

HTH

GM
PHP CODE LOGIN.PHP
<?
$POST['username'];
$POST['password'];

$connection = mysql_connect("localhost", "root", "blah")
or die ("Couldn't connect to server.");

$db = mysql_select_db("peeps", $connection)
or die ("Couldn't select database.");

$sql = "SELECT id
FROM users
WHERE username='$username' and password='$password'";

$result = mysql_query($sql)
or die("Couldn't execute query.");

$num = mysql_numrows($result);

if ($num == 1) {

echo "<P>You are a valid user!<br>";
echo "Your username is $username<br>";
echo "Your password is $password</p>";

} else if ($num == 0) {

echo "You are not authorised"

}

?>
Problem is, is that it keeps showing "You are not authorised".... so i think its a problem with my POST, but not sure what

Thanks for ya input

Art [/B][/QUOTE]

artizan

Trooper, Thanks very much for that...
It worked.... no joke, u jumped for joy.............

Again thank you

Art