finding specific values in foreach

dartcol

I'm having a few problems with validating data. In the form I call about 50 variable names from the database, loop through them in a form providing an input box for the user to fill in the number of products needed.

I want to check that they've only inputted a number. Here's the code that doesn't work.

	foreach($_POST as $variablename => $quantity)
		{
		if ( (!empty($quantity)) && (!is_int($quantity)) )
			{
			$nofilt = 'no';
			$error = 'TRUE';
			}
		}
	if ($nofilt == 'no')
		{
		echo 'Please only enter numbers.';
		}

I follow this with

	if (isset($error))
		{
		echo '<input type=button value=back onClick=history.back()>';

and finish up. If there isn't an error then I go onto the database queries and send an email.

Now something tells me that I've got this very wrong. I assume that it's looking at all 50 variables, working out that some are empty and some aren't and then returning TRUE for the $error. Hence the problem. What I can't figure out is how to make it check that only the variable names whose quantities were completed on the previous page are integers and if so returning $error as FALSE and continuing. Any help much appreciated.

Xoid

why don't you use a value that stores the number of errors?

example:

IF (!integer) THEN
Add 1 to ErrorHolder
ENDIF

IF(ErrorHolder>0) THEN
PRINT "Errors";
ENDIF

I think it would be alot simpler that way!

dartcol

Thanks for your input. Wouldn't I still have the same problem though? At the moment only some of the $keys have a $val. I need to filter out the empty $key and then check that there is a $val which is an integer higher or equal to 1 in the remaining $keys.

I've been trying to go a different way with this and have scraped together the code you see below. Unfortunately I'm getting an invalid argument supplied for foreach error statement. The line number given is for the first line of the second foreach statement.

Any ideas anyone?

foreach($_POST as $key => $val)
	{
	if (($val > 0) && (is_int($val)))
		$new_array['$key'] = $val;
	}

if (count($new_array) == 0)
	{
	$error = 'TRUE';
	}

foreach($new_array as $product => $quantity)
	{
	echo "".$product.": ".$quantity."<br>";
	}

dartcol

I've just found out that any data supplied through a form is classed as a string. To check if data is an integer in a string I need to use the is_numeric function rather than is_int. This gets the code working until no quantities are sent. Then I get the error message. Again, any ideas welcome. Cheers.

dartcol

I've solved the problem. It was pretty easy really. One of those 'Oh yeah ... twit' moments. Here's the finished code. Someone may find it useful.

foreach($_POST as $key => $val)
		{
		if (($val > 0) && (is_numeric($val)))
			$new_array[$key] = $val;
		}

if (count($new_array) == 0)
	{
	echo 'Please enter a quantity for the product(s) you are interested in.';
	$error = 'TRUE';		
	}
else
	{

	foreach($new_array as $product => $quantity)
		{
		echo "".$product.": ".$quantity."<br>";
		}
	}