Passing values for an update

Keaner

Hey guys and gals,

I posted this question earlier today but I didn't really explain what was going wrong. I'm trying to get my update page to work but I'm having a bit of trouble. Here's the run down:

1 - updateForm.php - This page displays the contents of the database and puts and "Edit" link and the beggining of each record. When the user clicks on the link it brings them to update.php

2 - update.php - This page consists of text input boxes and one drop down box. So depending on which link the user clicks, it should display the contents of that record in the input boxes so the user can see what they are changing. Then they can click on update and update the database.

I am getting no errors and the data is not being displayed in the input boxes. Any help would be greatly appreciated and thanks in advance. Here is my code:

UPDATEFORM.PHP
<?
include("header.inc");
include("details.inc");
?>

<H2>hoose a Record to Update</H2>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

include("title.inc");

$query="SELECT * FROM assets ORDER BY location ASC";
$result=mysql_query($query);

while ($rs = mysql_fetch_array($result)) {

printf("<TR ALIGN=CENTER><TD><A HREF=update.php?id=$id>Edit</A></TD><TD>" . $rs['itemName'] . "</TD><TD>" . $rs['serialNum'] . "</TD><TD>" . $rs['assetNum'] . "</TD><TD>" . $rs['location'] . "</TD><TD>" . $rs['description'] . "</TD><TD>" . $rs['entryDate'] . "</TD><TD>" . $rs['warranty'] . "</TD></TR>");

}

mysql_close();

include("footer.inc");
?>

UPDATE.PHP
<?
include("header.inc");
?>

<H2>Update Database</H2><P><HR>
<P>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

<?
include("details.inc");

$asset = $POST['asset'];
$name = $POST['name'];
$location = $POST['location'];
$description = $POST['description'];
$warranty = $POST['warranty'];
$serial = $POST['serial'];
$id=$_GET['id'];

$query=" SELECT * FROM assets WHERE id='$id'";
$result=mysql_query($query);
mysql_close();

if(isset($_POST['btnUpdate'])) {
$query = "UPDATE assets SET
serialNum = '$serial',
assetNum = '$asset',
itemName = '$name',
location = '$location',
description = '$description',
warranty = '$warranty'
WHERE id LIKE '$id'";
mysql_query($query) or die (mysql_error());
mysql_close();
}

<TABLE BORDER=1 WIDTH=40% ALIGN="CENTER">
<TR ALIGN=CENTER>
<TD><B>Item Name</B></TD><TD><Input type="text" name="name" size="20" value=<? echo "$name"; ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Serial Number</B></TD><TD><Input type="text" name="serial" size="20" value=<? echo "$serial"; ?> ></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Asset Number</B></TD><TD><Input type="text" name="asset" size="20" value=<? echo "$asset"; ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Location</B></TD><TD><Select name="location" value="<? echo "$location"; ?>">
<OPTION>
<OPTION>Baie Verte
<OPTION>Botwood
<OPTION>Bishop Falls
<OPTION>Buchans
<OPTION>Carmanville
<OPTION>Centreville
<OPTION>Change Islands
<OPTION>Fogo Island
<OPTION>Gambo
<OPTION>Gander
<OPTION>Gaultois
<OPTION>Glenwood
<OPTION>Glovertown
<OPTION>Grand Falls
<OPTION>Greenspond
<OPTION>Harbour Breton
<OPTION>Hare Bay
<OPTION>Harry's Harbour
<OPTION>Hermitage
<OPTION>King's Point
<OPTION>La Scie
<OPTION>Lewisporte
<OPTION>Lumsden
<OPTION>Musgrave Harbour
<OPTION>Norris Arm
<OPTION>Point Leamington
<OPTION>Robert's Arm
<OPTION>Seal Cove
<OPTION>Springdale
<OPTION>St. Alban's
<OPTION>Summerford
<OPTION>Twillingate
<OPTION>Wesleyville
</SELECT></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Description</B></TD><TD><Input type="text" name="description" size="20" value=<? echo "$description"; ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Warranty</B></TD><TD><Input type="text" name="warranty" size="20" value=<? echo "$warranty"; ?>></TD>
</TR>
</TABLE>
<BR><CENTER>
<input type="Submit" name="btnUpdate" Value="Update Record">
<input type="Reset" name="Reset">
</FORM></CENTER>

<?
include("footer.inc");
?>

kevinsequeira

DEBUG : print out the query to see whats going on, that should point you in the right direction..

also for the option value, should it be like this ?

<OPTION value="Baie Verte">Baie Verte</OPTION>

reg
kevin

Keaner

How exaclty do I print out the query?

I'm not 100% sure but I don't think that the </OPTION> isn't required. Just good programming practice.

kevinsequeira

whereever you have this
mysql_query($query) or die (mysql_error());

do this

print ($query);
mysql_query($query) or die (mysql_error());

i was talking about the value in the option field tag not the close tag

reg
kevin

Keaner

It say:

SELECT * FROM assets WHERE id=''No Database Selected

I know what that means but how do I fix it.

kevinsequeira

two things
1. id is not being passed cause the query is SELECT * FROM assets WHERE id= ????

u need to write code to conenct to db, something like
$host = "yourhost";
$username="your_username";
$password="your_pwd";
$database="the_db_name";
mysql_connect($host,$username,$password);
mysql_select_db($database);

this should be at the top of each page.

i suggest you search on google for some tutorials which explain how to add/update/delete records from db using php

reg
kevin

Keaner

All the connection stuff is in the details.inc file. I have already made a enter/delete page and have a good understanding of it. But the update is giving me trouble. Basically what I'm asking is what should I make $id equal in oder to get this to work.

kevinsequeira

well for starters

printf should be print and the $id that u're passing as $id shoud be $rs['id'];

next have a hidden field called id in the form on update.php

$id=$_GET['id'];

change it to
if(isSet($GET['id']){
$id=$GET['id']
}else{
$id = $_POST['id'];
}

reg
kevin

Keaner

Ok, after making these changes (I think I made them correctly) it still isn't working. It displays an error message:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/html/updateForm.php on line 21

I screwed around with the code a bit and got rid of the error but I had to take out <A HREF=update.php?'id'=$rs['id'];> in order to get it to work. Also when I do this the debug says there is still no database selected. So here is my code as is with the error coming up:

SEARCHFORM.PHP
<?
include("header.inc");
include("details.inc");
?>

<H2>hoose a Record to Update</H2>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

include("title.inc");

$query="SELECT * FROM assets ORDER BY location ASC";
$result=mysql_query($query);
mysql_close();

while ($rs = mysql_fetch_array($result)) {

print ("<TR ALIGN=CENTER><TD><A HREF=update.php?'id'=$rs['id'];>Edit</A></TD><TD>" . $rs['itemName'] . "</TD><TD>" . $rs['serialNum'] . "</TD><TD>" . $rs['assetNum'] . "</TD><TD>" . $rs['location'] . "</TD><TD>" . $rs['description'] . "</TD><TD>" . $rs['entryDate'] . "</TD><TD>" . $rs['warranty'] . "</TD></TR>");

}

include("footer.inc");
?>

SEARCH.PHP

<?
include("header.inc");
?>

<H2>Update Database</H2><P><HR>
<P>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

<?
include("details.inc");

$asset = $POST['asset'];
$name = $POST['name'];
$location = $POST['location'];
$description = $POST['description'];
$warranty = $POST['warranty'];
$serial = $POST['serial'];
$id=$_GET['id'];

$query="SELECT * FROM assets WHERE id='$id'";
$result=mysql_query($query);
mysql_close();

print ($query);
mysql_query($query) or die (mysql_error());

<TABLE BORDER=1 WIDTH=40% ALIGN="CENTER">
<TR ALIGN=CENTER>
<TD><B>Item Name</B></TD><TD>
<Input type="text" name="name" size="20" value=<? echo $rs['itemName'] ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Serial Number</B></TD><TD><Input type="text" name="serial" size="20" value=<? echo $rs['serialNum'] ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Asset Number</B></TD><TD><Input type="text" name="asset" size="20" value=<? echo $rs['assetNum'] ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Location</B></TD><TD><Select name="location" value="<? echo $rs['location'] ?>">
<OPTION>
<OPTION>Baie Verte
<OPTION>Botwood
<OPTION>Bishop Falls
<OPTION>Buchans
<OPTION>Carmanville
<OPTION>Centreville
<OPTION>Change Islands
<OPTION>Fogo Island
<OPTION>Gambo
<OPTION>Gander
<OPTION>Gaultois
<OPTION>Glenwood
<OPTION>Glovertown
<OPTION>Grand Falls
<OPTION>Greenspond
<OPTION>Harbour Breton
<OPTION>Hare Bay
<OPTION>Harry's Harbour
<OPTION>Hermitage
<OPTION>King's Point
<OPTION>La Scie
<OPTION>Lewisporte
<OPTION>Lumsden
<OPTION>Musgrave Harbour
<OPTION>Norris Arm
<OPTION>Point Leamington
<OPTION>Robert's Arm
<OPTION>Seal Cove
<OPTION>Springdale
<OPTION>St. Alban's
<OPTION>Summerford
<OPTION>Twillingate
<OPTION>Wesleyville
</SELECT></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Description</B></TD><TD><Input type="text" name="description" size="20" value=<? echo $rs['description'] ?>></TD>
</TR>
<TR ALIGN=CENTER>
<TD><B>Warranty</B></TD><TD><Input type="text" name="warranty" size="20" value=<? echo $rs['warranty'] ?>></TD>
</TR>
</TABLE>
<BR><CENTER>
<input type="Submit" name="btnUpdate" Value="Update Record">
<input type="Reset" name="Reset">
</FORM></CENTER>

<?
include("footer.inc");
?>

kevinsequeira

post details.inc or open it and see if the db is selected :
mysql_select_db($database); ????
is id in your table a string or a numeric value ?
change ure print statement to this

 print ("<TR ALIGN=CENTER><TD><A HREF=update.php?id=".$rs['id'].">Edit</A></TD><TD>" . $rs['itemName'] . "</TD><TD>" . $rs['serialNum'] . "</TD><TD>" . $rs['assetNum'] . "</TD><TD>" . $rs['location'] . "</TD><TD>" . $rs['description'] . "</TD><TD>" . $rs['entryDate'] . "</TD><TD>" . $rs['warranty'] . "</TD></TR>");

u have not made the change i suggested for this bit

$id=$_GET['id'];

f(isSet($GET['id']){
$id=$GET['id']
}else{
$id = $_POST['id'];
}

change this bit
if(isset($_POST['btnUpdate'])) {
$query = "UPDATE assets SET
serialNum = '$serial',
assetNum = '$asset',
itemName = '$name',
location = '$location',
description = '$description',
warranty = '$warranty'
WHERE id LIKE '$id'";
mysql_query($query) or die (mysql_error());
mysql_close();
}

<?php
if(isset($_POST['btnUpdate'])) {
$query = "UPDATE assets SET serialNum = '".$serial."', assetNum = '".$asset."', itemName = '".$name."',location = '".$location."', description = '".$description."',warranty = '".$warranty."' WHERE id = ".$id;
mysql_query($query) or die (mysql_error());
echo $query;
mysql_close();
} 
// REMEMBER IF THE VALUE IS NUMERIC THEN DONT USE '' ELSE USE '' 
?>

if u get any errors post the edited code , the error and point out which line in the code the error is and any other output u get

reg
kevin

Keaner

Hey, all of the errors are gone now. But it still will not output the variable to the input boxes. And id is a integer set to auto increment.

I cannot put the following statement into the page because I keep getting this error (Parse error: parse error, unexpected '}' in /home/html/update.php on line 23):

if(isSet($GET['id'])){
$id=$GET['id']
}else{ Line 23
$id = $_POST['id'];
}

Here is the code I have right now:

UPDATEFORM.PHP
<?
include("header.inc");
include("details.inc");
?>

<H2>Choose a Record to Update</H2>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

<?
include("title.inc");

$query="SELECT * FROM assets ORDER BY location ASC";
$result=mysql_query($query);

while ($rs = mysql_fetch_array($result)) {

print ("<TR ALIGN=CENTER><TD><A HREF=update.php?id=".$rs['id'].">Edit</A></TD><TD>" . $rs['itemName'] . "</TD><TD>" . $rs['serialNum'] . "</TD><TD>" . $rs['assetNum'] . "</TD><TD>" . $rs['location'] . "</TD><TD>" . $rs['description'] . "</TD><TD>" . $rs['entryDate'] . "</TD><TD>" . $rs['warranty'] . "</TD></TR>");}

include("footer.inc");
?>

UPDATE.PHP
<?
include("header.inc");
?>

<H2>Update Database</H2><P><HR>
<P>
<A HREF="enterForm.php">Enter a Record</A>
<A HREF="searchForm.php">Search Database</A>
<A HREF="userForm.php">Create a New User</A><P><HR></CENTER><P>

<?
include("details.inc");

$asset = $POST['asset'];
$name = $POST['name'];
$location = $POST['location'];
$description = $POST['description'];
$warranty = $POST['warranty'];
$serial = $POST['serial'];

if(isSet($GET['id'])){
$id=$GET['id']
}else{
$id = $_POST['id'];
}

$query="SELECT * FROM assets WHERE id='$id'";
$result=mysql_query($query);

print ($query);
mysql_query($query) or die (mysql_error());

if(isset($_POST['btnUpdate'])) {
$query = "UPDATE assets SET serialNum = '".$serial."', assetNum = '".$asset."', itemName = '".$name."',location = '".$location."', description = '".$description."',warranty = '".$warranty."' WHERE id = ".$id;
mysql_query($query) or die (mysql_error());
echo $query;
mysql_close();
}

<?
include("footer.inc");
?>

Keaner

Ok, nevermind. I got the following line to work. There were just a few small syntax errors.

if(isSet($GET['id'])){
$id=$GET['id'];
}else{
$id = $_POST['id'];
}

Now here's my output on the page:

SELECT * FROM assets WHERE id='1'

But no info in the input boxes.

kevinsequeira

like i mentioned if id is numeric dont use ' '
so change ure query
$query="SELECT * FROM assets WHERE id='$id'";

$query="SELECT * FROM assets WHERE id=".$id;

reg
kevin

Keaner

Ok, I made the change. I'm still getting the same screen as before. Empty input boxes and "SELECT * FROM assets WHERE id=1".

kevinsequeira

changes ..

$query="SELECT * FROM assets WHERE id=".$id;
$result=mysql_query($query);

add this line next

$rs= mysql_fetch_array($result);

reg
kevin

Keaner

Bingo, you da man. I really appreciate your help. I'll see if I can get the update to work. If I have any troubles I'll post back here. If not I'll make this resolved.

Rod

Keaner

I have one final question before this page is complete. How do I get the location to display in the drop down box before the update is done? Right now all the values output fine except location. It stays blank.

kevinsequeira

replace this bit

 <Select name="location" value="<? echo $rs['location'] ?>">
<OPTION>
<OPTION>Baie Verte
<OPTION>Botwood
<OPTION>Bishop Falls
<OPTION>Buchans
<OPTION>Carmanville
<OPTION>Centreville
<OPTION>Change Islands
<OPTION>Fogo Island
<OPTION>Gambo
<OPTION>Gander
<OPTION>Gaultois
<OPTION>Glenwood
<OPTION>Glovertown
<OPTION>Grand Falls
<OPTION>Greenspond
<OPTION>Harbour Breton
<OPTION>Hare Bay
<OPTION>Harry's Harbour
<OPTION>Hermitage
<OPTION>King's Point
<OPTION>La Scie
<OPTION>Lewisporte
<OPTION>Lumsden
<OPTION>Musgrave Harbour
<OPTION>Norris Arm
<OPTION>Point Leamington
<OPTION>Robert's Arm
<OPTION>Seal Cove
<OPTION>Springdale
<OPTION>St. Alban's
<OPTION>Summerford
<OPTION>Twillingate
<OPTION>Wesleyville
</SELECT>

with this

<?php
	$location_array = array("Baie Verte","Botwood", "Bishop Falls", "Buchans", "Carmanville","Centreville", "Change Islands", "Fogo Island", "Gambo", "Gander", "Gaultois", "Glenwood", "Glovertown", "Grand Falls", "Greenspond", "HarbourBreton", "Hare Bay", "Harry's Harbour", "Hermitage", "King's Point", "LaScie", "Lewisporte", "Lumsden", "Musgrave Harbour", "Norris Arm", "Point Leamington", "Robert's Arm", "Seal Cove", "Springdale", "St. Alban's", "Summerford", "Twillingate", "Wesleyville");
echo "<SELECT NAME=location>";
foreach($location_array as $value){
	echo "<OPTION VALUE=".$value.";
	if($rs['location'] == $value)
		echo " SELECTED"; 
	echo ">".$value."</OPTION>";
}	 
echo "</SELECT>";
?>

PS : remember i asked u to have the options as <option value="XXXX">XXXX</option> earlier, this was why.

reg
kevin

Keaner

I get an error that says theres and unexpected , in line 61. aka location_array=all the locations

kevinsequeira

echo "<OPTION VALUE=".$value.";

change to

echo "<OPTION VALUE=".$value;

reg
kevin