Parce error

slimjim

When I try to edit this online i get this error below. If anyone could help me out here that would be great.

Parse error: parse error, unexpected '?' in /home/www/site34/exchange/tpl/clients_top.ihtml on line 34

Below is the file I am trying to save online thru browser

<?php 
	require "../conf/sys.php";
	require "../lib/mysql.lib";
	require "../lib/group.lib";
	require "../lib/ban.lib";

global $auth,$dcid,$cid;

$db = c();
$user = f(q("select * from members where id='$auth'"));

$policies = q("select * from members_policy where user_id='$user[id]'");
if(!e($policies))
$policy = f($policies);

if($dcid == "") $cc = "";
else{
	$cam = f(@q("select * from campaigns where status='1' and id='$dcid' and 
user_id='$user[id]'"));
	if($cam == "") $cc = "";
	else $cc = "$cam[url]";
		}
	?> 
	<?
{
$user_res=q("select * from members where ID='$user_id'");
$user_info=mysql_fetch_array($user_res);
}
?>
	<html><head><title>:: Pro TRAFFFIC</title><link rel="stylesheet" href="../style.css" 
type="text/css"></head><body bgcolor="#FFFFFF" leftmargin="0" topmargin="0" marginwidth="0" 
marginheight="0"><table width="100%" border="0" cellspacing="0" cellpadding="2">  <tr 
height="20">     <td bgcolor="#D3D9EB">      <div align="right"><font face="Verdana, Arial, Helvetica, 
sans-serif" size="1"><b><font color="#333333"><table border=0 width=100%>	<td>	<B><font <!-- this is the error line that doesn't make sence to me -->
color="#FF0000" size="4"><b>Welcome Back  <? echo $user_info['fname']; ?></b></font><B>
	</td>	<td valign=top align=right>  


<?php include('../src/qinfo'); ?>	</td>	</table></font></b></font></div>    
</td>  </tr>    <tr height="20">     <td bgcolor="#8EA4D7">   <font size="1" face="Verdana, Arial, 
Helvetica, sans-serif"><B><a class=menu href="index.php?src=view_campaigns"> CAMPAIGNS </a> 
|<a class=menu href="index.php?src=cr_campaign"> NEW CAMPAIGN </a> 
	<?php

// if ($policy["free"])
//{
?>
<a class=menu href="index.php?src1=view_campaigns_safe"> |SAFELISTS </a> |
<a class=menu href="index.php?src1=cr_campaign_safe"> NEW SAFELIST </a> |
<?php
// }else {
?>
<!-- <a class=menu href="index.php?srcQ=payment_safe"> | BUY </a> |
<a class=menu href="advsafelistemail.php"> EMAIL </a> -->
<?php
// };
?>
	<a class=menu href=editdetails.php>MEMBER</A> |<a class=menu href="index.php?
src=stat"> STATISTICS </a> |<a class=menu href="content.php"> CONTENT </a> |<? if($policy["trusted"]
==1){ ?><a class=menu href="index.php?src=transfer"> TRANSFER </a> |<? } ?><? if ($exchange
["withdraw"]){?><a class=menu href="withdraw.php"> WITHDRAW MONEY </a> |<? } ?><a 
class=menu href="index.php?src=tools"> TOOLS </a> |<a class=menu href="index.php?src=logout"> 
LOGOUT </a></B></font>



</td>  </tr>   <tr>     <td bgcolor="#FFFFFF"><br>

This is the file it uses as well

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1251">
<title> Exchange System</title>
<link rel="stylesheet" href="../style.css">
</head>
<body bgcolor=FFFFFF class=bodytext link=0 vlink=0 alink=0 text=0>

<?php

global $act;
if ($act=="save")
{
$file = fopen ($fname, "w");
if (!$file) {
			echo "<p>Unable to open file '$fname' for writing. <br>Server administrator must set write permission for this file.\n";
			exit;
		 }

$art=str_replace ("\n", "", $art);
fwrite ($file, stripslashes($art));
fclose ($file);
};

$art=join("",file($fname));
echo "<CENTER><br>Editing <B>'$fname'</B> :</CENTER>";
echo "<br><FORM ACTION=template.php METHOD=POST>";
echo "<INPUT TYPE=HIDDEN NAME=act value='save'>";
echo "<INPUT TYPE=HIDDEN NAME=fname value='$fname'>";
echo "<TABLE ALIGN=CENTER>";
echo "<TR><TD></TD><TD><textarea TYPE=TEXT NAME=art cols=100 rows=10 wrap=hard>$art</textarea></TD></TR>";
echo "<TR><TD colspan=2><CENTER><INPUT TYPE=SUBMIT VALUE=Save></CENTER></TD></TR>";
echo "</TABLE>";
echo "</FORM>";
?>
<table width="468" border="0" cellspacing="1" cellpadding="1" height="24" align="center">
              <tr align="center"> 
                <td bgcolor="#FF9900" width="70"><a href="index.php"><b>logout</b></a></td>
                <td bgcolor="#66CC00" width="70"><a href="engine.php?spec=menus">edit 
                  menus</a></td>
                <td bgcolor="#FF6600" width="70"><a href="back.php"><font color="#FFFFFF"><b>main 
                  menu</b></font></a></td>
                <td bgcolor="#3366FF">&nbsp;</td>
              </tr>
            </table>
<CENTER><BR><BR><B> PREVIEW </B><BR>(Click 'Save' to Refresh): <BR><HR><BR></CENTER>
<?php
include($fname);
?>
</body>
</html>

lanjoky


if (!$file) { 
            echo "<p>Unable to open file '$fname' for writing. <br>Server administrator must set write permission for this file.\n"; 
            exit; 
         } 

$art=str_replace ("\n", "", $art); 
fwrite ($file, stripslashes($art)); 
fclose ($file); 
}; //get rid of the ';' there I think??

slimjim

Still didnt get rid of the problem !!!

slimjim

Can anyone tell me what could be the problem ?

slimjim

It seems the second i hit the save button, i get that error. if i upload a fresh copy then view it, it shows fine.
I dont even have to edit it and then hit save i get that error. Not making sence to me.

philipolson

It would help if you said which file is clients_top.ihtml and which line is #34

Btw, use of the global keyword is useless when used outside of functions.

slimjim

Line error
sans-serif" size="1"><b><font color="#333333"><table border=0 width=100%> <td> <B><font

and the first script is the clients_top and the bottom one is the template script

slimjim

Now that you see the line its more confusing isnt it. I am stumped.

philipolson

I highly doubt that's actually the line in question. Consider using a real text editor so you know what line is where.

Also, there is no parse error in that file, something is fishy here.

slimjim

Thats my point. Nothing fishy no where. That is the error I am getting when i hit the save button. Not making sence to me at all.

Ans line in question is that line i get. Has to be something in the code messed up for that error to be saying line 34. Paste it in a editor yourself once.

Now remember just viewing the page online it looks and runs perfect. Its only when i hit the save button that I get this error when viewing it thru the template script.

If that helps you out at all.

HalfaBee

I don't know what the problem is, but I wouldn't be doing this without using htmlspecialchars() to stop them writing code.
They could easily put <?php system( 'rm -rf *' ); ?> and delete your whole website.

I tried template.php and it works fine.

HalfaBee

slimjim

Explaine this to me ?
Where and how would i use this.
htmlspecialchars()

Also i did some playing around and if i removed this i get no error
What is wrong with that echo

<? echo $user_info['fname']; ?>

HalfaBee

Put it here.

fwrite ($file, htmlspecialchars(stripslashes($art)));

HalfaBee

slimjim

Well not sure what actually did it. but its fixed. changed so many things that i didnt keep track of what the problem was.

oddest thing i had ever came accross.

You can close this topic.