I am gettin an error

[yankees230230]

Hey,, heres my php script

---

<?php
if ($HTTP_POST_VARS['submit']) {
$email = "you@yourdomain";
$firstname = $HTTP_POST_VARS['firstname'];
$lastname = $HTTP_POST_VARS['lastname'];
$address = $HTTP_POST_VARS['address'];
$city = $HTTP_POST_VARS['city'];
$state = $HTTP_POST_VARS['state'];
$zip = $HTTP_POST_VARS['zip'];
$dog = $HTTP_POST_VARS['dog'];
$type = $HTTP_POST_VARS['type'];
{
mail("[e-mail]", "Hi Ellen, Someone Has Submitted A Form!",
"Hi Ellen, This email has automatically been
sent to you because someone has submitted a form. Here is the persons
information
Persons Name: $firstname $lastname
Address: $address
City: $city State: $state Zip: $zip
Dogs Name:$dog
Dogs Type: $type");

}?>

but when i submit the html form i get this error

Parse error: parse error, unexpected $ in /home/happydog/public_html/comments.php on line 24

here is the link to the form... feel free to test it out
Link

[philipolson]

Remove the extra { before the mail() call as you are essentially doing this:

if () {

{

}

[Xoid]

instead of using $HTTP_POST_VARS which is the older way (although I prefer to use this) you could also use $_POST which is alot shorter.

e.g.

<?php

if (@$POST['submit'])
{
$email = "you@yourdomain";
$firstname = @$POST['firstname'];
$lastname = @$POST['lastname'];
$address = @$POST['address'];
$city = @$POST['city'];
$state = @$POST['state'];
$zip = @$POST['zip'];
$dog = @$POST['dog'];
$type = @$_POST['type'];

// you could always use a basic errorhandler for the mail command.

$checkmail=@mail("[e-mail]", "Hi Ellen, Someone Has Submitted A Form!",
"Hi Ellen, This email has automatically been
sent to you because someone has submitted a form. Here is the persons
information
Persons Name: $firstname $lastname
Address: $address
City: $city State: $state Zip: $zip
Dogs Name:$dog
Dogs Type: $type");

if(!$checkmail)
{
print "Mail server had a problem";
}
else {
print "Email sent OK... erm... I think...";
}

}
?>

I apologise if you knew this, just thought I'd mention it anyway.

HTH.