again, same problem

singboy

I have some problem regarding the attachments below:
newbook.php and insert_book.php seem to be can't "tolerate"
although i have tested it, but still the same problem out: which couldn't all the strings in newbook.php can seem to be POST to insert_book.php to print into my database. I have actually check for database :db_connect.php (its correct with no error).
**
Can somebody tell me, whats the problem occur?

newbook.php <html>
<head>
<title>book</title>
</head>
<body>
<h1>Books Result</h1>

</tr>
<tr>
<td>Author</td>
<td> <input type="text" name="author" maxlength=30 size=30><br></td>
</tr>
<tr>
<td>Title</td>
<td> <input type="text" name="title" maxlength=60 size=30><br></td>
</tr>
<tr>
<td>Price $</td>
<td><input type="text" name="price" maxlength=7 size=7><br></td>
</tr>
<tr>
<td colspan=2><input type="submit" value="Register"></td>
</tr>
</table>
</form>
</body>
</html>

insert_book.php
<html>
<body>
<h1>Book Entry Results</h1>
<?php
require_once("db_connect.php");

if (!$book_isbn || !$author || !$title || !$price)

{
echo "You have not entered all the required details.<br>"
."Please go back and try again.";
exit;
}

$book_isbn =$POST['book_isbn'];
$author = $POST['author'];
$title = $POST['title'];
$price = $POST['price'];
$query = "insert into books values
('', '$book_isbn', '$author', '$title', '$price')";
$result = mysql_query($query);
if ($result)
echo mysql_affected_rows()." book inserted into database.";
?>

</body>
</html>

I 'm sick of it
🙁

Damien_Buttler

Singboy, I had a hard time understanding what you meant but I ran your script and found the only problem I have was with your variables. Do you have global variables turned off? try changing the line:

if (!$book_isbn || !$author || !$title || !$price)

if (!$POST['book_isbn'] || !$POST['author'] || !$POST['title'] || !$POST['price'])

If you are not getting any errors, check that you have all errors turned on in php.ini

Xoid

just skimmed throught your code and as Damien suggests your validating BEFORE you've called the POST variables.

could you post the db_connect.php code just to check something

singboy

newbook.php
<html>
<head>
<title>book</title>
</head>
<body>
<h1>Books Result</h1>

insert_book.php
<html>
<body>
<h1>Book Entry Results</h1>
<?php
require_once("db_connect.php");

$book_isbn =$POST['book_isbn'];
$author = $POST['author'];
$title = $POST['title'];
$price = $POST['price'];

if (!$book_isbn || !$author || !$title || !$price)

{
echo "You have not entered all the required details.<br>"
."Please go back and try again.";
exit;
}

$query = "insert into books values
('', '$book_isbn', '$author', '$title', '$price')";
$result = mysql_query($query);
if ($result)
echo mysql_affected_rows()." book inserted into database.";
?>

</body>
</html>

I have made a changes in insert_book.php, but it seem still cannot insert data into the database. About the global variables, is better i turn off(it shown warning when i turn on), should i?
So any comment?[

crosbystillsnas

print the query and see what comes out there.
copy the printed text and paste it in phpMyAdmin's sql-textarea, or somewhere similar... it's the easiest way to find out what happens.

$query = "insert into books values 
('', '$book_isbn', '$author', '$title', '$price')"; 
$result = mysql_query($query); 
echo $query;

batman

Use this for your insert_book.php page:

<html> 
<body> 
<h1>Book Entry Results</h1> 
<?php 
require_once("db_connect.php"); 

$book_isbn =$_POST['book_isbn']; 
$author = $_POST['author']; 
$title = $_POST['title']; 
$price = $_POST['price']; 

if((!$book_isbn) || (!$author) || (!$title) || (!$price)){
	echo 'You did not submit the following required information! <br />';
	if(!$book_isbn){
		echo "Book ISBN is a required field. Please enter it below.<br />";
	}
	if(!$author){
		echo "Author is a required field. Please enter it below.<br />";
	}
	if(!$title){
		echo "Title is a required field. Please enter it below.<br />";
	}
	if(!$Price){
		echo "Price is a required field. Please enter it below.<br />";
	}
	include 'new_book.php';
	exit(); 
}
else{
$query = "insert into books values 
('', '$book_isbn', '$author', '$title', '$price')"; 
$result = mysql_query($query); 
if ($result) 
echo mysql_affected_rows()." book inserted into database."; 
}
?> 

</body> 
</html>

That gives a little bit better error checking, and it should also work.

batman

Aw...just noticed something. In your query, your giving the values but your not telling it where to place those values. Your query should look more like this:

$query = "INSERT INTO books (,book_isbn, author, title, price) VALUES('', '$book_isbn', '$author', '$title', '$price')";

Plug that into the above code that I gave you and you should be set.

Damien_Buttler

You don't need to include the name of the values (column names) if you include all values in the value string which singboy has done. I had the script working fine at my server just by changing the line that I stated with the first reply so I don't think that there is any other problem with the code. There could still be some problems with the table setup however, which, if a problem does not return any errors. If it is still not working, maybe we should check the table setup...

Norman_Graham

Dear Singboy

Because you cross-posted your question, I just spent 10 minutes answering a question that had already been adequately answered by loads of other people.

Don't do this, please! :mad:

Norm

singboy

Norman Graham , i am very sorry. I just sick of doing this coding. Anyway i am trying hard, as several experts guiding me. Thanks and apologise to you.

singboy

newbook.php
<html>
<head>
<title>Book Entry</title>
</head>
<body>
<h1>Book Entry</h1>
<form action="insert_book.php" method="post">
<table border=0>
<tr>
<td>ISBN</td>
<td><input type="text" name='book_isbn' maxlength=13 size=13><br></td>

  </tr>
  <tr>
    <td>Author</td>
    <td> <input type="text" name='author' maxlength=30 size=30><br></td>
  </tr>
  <tr>
    <td>Title</td>
    <td> <input type="text" name='title' maxlength=60 size=30><br></td>
  </tr>
  <tr>
    <td>Price $</td>
    <td><input type="text" name='price' maxlength=7 size=7><br></td>
  </tr>
  <tr>
    <td colspan=2><input type='submit' value="Register"></td>
  </tr>
</table>

/form>
</body>
</html>

insert_book.php

<html>
<head>
<title>Entry Results</title>
</head>
<body>
<h1>Book Entry Results</h1>
<?php

require_once("db_connect.php");

$book_isbn =$POST['book_isbn'];
$author = $POST['author'];
$title = $POST['title'];
$price = $POST['price'];

if((!$book_isbn) || (!$author) || (!$title) || (!$price))
{
echo "You did not submit the following required information! <br />";
if(!$book_isbn){
echo "Book ISBN is a required field. Please enter it below.<br />";
}
if(!$author){
echo "Author is a required field. Please enter it below.<br />";
}
if(!$title){
echo "Title is a required field. Please enter it below.<br />";
}
if(!$price){
echo "Price is a required field. Please enter it below.<br />";
}

include 'newbook.php';
exit();

}
else{
$query = "INSERT INTO books (,book_isbn, author, title, price) VALUES('', '$book_isbn', '$author', '$title', '$price')";
$result = mysql_query($query);
if ($result)
echo mysql_affected_rows()." book inserted into database.";
}

?>
</body>
</html>

anyhow after i run again and again, edit here edit there still the same as blak page except Book Entry Results print out. Is that the inserting part not really "INSERT" into the BOOKS table?
I bet experts are tiring answer my question, but i think i would give it a last try. SIGH@
😕
Thank everybody anyway, batman Damien_Buttler crosbystillsnas
Xoid Norman Graham

singboy

to expert, Thanks everybody, I appreciate very much.
I have succeed!

batman

Post what was wrong with it, so we can see what you did, or didn't do. 🙂