Coding modification for PHP 4.3

[babulgogoi]

Hi

I am in a B-I-G trouble now. And looking for help/guidance.

I was running a freeware PHP script (CMS) for my website. Earlier the PHP Version was 4.06 (!) and it was working fine.

Now, the PHP program of my web server is upgraded into PHP 4.3 and the CMS is giving trouble.. specially with "setlocal" strings.

can anyone pls help me modifying my codes?

Regards,

Babul Gogoi
[e-mail]

the error message is like:==============

Warning: setlocale() [function.setlocale]: Passing locale category name as string is deprecated. Use the LC_* -constants instead. in /home/asmorg/public_html/links.php on line 428

here's part of the links.php==================

echo "<span class=\"searchprops\">Description: </span>$description<br />";

setlocale ("LC_TIME", "$locale");
ereg ("([0-9]{4})-([0-9]{1,2})-([0-9]{1,2}) ([0-9]{1,2}):([0-9]{1,2}):([0-9]{1,2})", $time, $datetime);
$datetime = strftime("%d-%b-%Y", mktime($datetime[4],$datetime[5],$datetime[6],$datetime[2],$datetime[3],$datetime[1]));
$datetime = ucfirst($datetime);

echo "<span class=\"searchprops\">Added on: </span>$datetime Hits: $hits<br />";
$result2=mysql_query("select title from links_categories where cid=$cid");
list($ctitle) = mysql_fetch_row($result2);
echo "<span class=\"searchprops\">Category: </span>$ctitle";
$result3=mysql_query("select title from links_subcategories where sid=$sid");
while(list($stitle) = mysql_fetch_row($result3)) {
    echo " / $stitle";
}
echo "<br /><br />";
}
echo "</td></tr></table>";

[tsinka]

Hi,

in recent php versions the locale categories are specified as constants, it should be sufficient to replace

setlocale ("LC_TIME", "$locale");

by

setlocale (LC_TIME, "$locale");

[babulgogoi]

Still there is no solution for me!!!

U may pls look at: www.assam.org/links.php

is there any other code that I can fix the error??

[tsinka]

Hi,

seems like the locale problem is fixed but you have a problem with one or more sql queries.

I'd suggest to add mysql_error() calls to your mysql_??? function calls so you can see what the error exactly is.

Example:

$result3=mysql_query("select title from links_subcategories where sid=$sid") or die ("SQL Error: ".mysql_error()."<br>\n";

That will give you a human readable error description of the exact error.
Add the mysql_error() code to mysql_connect,mysql_select_db and any mysql_query.