[Resolved] Update a line in mysql

[fean0r]

I've created a profile page where people can edit there profile

when the user clicks save changes they get forwarded to a page with this code

<?
include("dbconnect.php");
include("mcheck.php");
$sql = "UPDATE user SET team_name=`$team_name`,clan_tag=`$clan_tag`,player1_name=`$player1_name`,player1_wonid=`$player1_wonid`,player2_name=`$player2_name`,player2_wonid=`$player2_wonid`,player3_name=`$player3_name`,player3_wonid=`$player3_wonid`,reserve1_name=`$reserve1_name`,reserve1_wonid=`$reserve1_wonid`,reserve2_name=`$reserve2_name`,reserve2_wonid=`$reserve2_wonid`,email=`$email`,clan_web=`$clan_web`,server_type=`$server_type`,server_ip=`$server_ip`,clan_info=`$clan_info` WHERE username=$username";
$result = mysql_query($sql);
echo "Thank you! Information updated.";
?>

Now all the $variables to have the correct info and I do get the echo saying Thank you! Information updated but the information isnt saved?

Any ideas?

dbconnect.php = connect to database
mcheck.php = checks if they are logged in

[laserlight]

Maybe try:

<?php
include("dbconnect.php");
include("mcheck.php");
$sql = "UPDATE user SET
	team_name='$team_name',
	clan_tag='$clan_tag',
	player1_name='$player1_name',
	player1_wonid='$player1_wonid',
	player2_name='$player2_name',
	player2_wonid='$player2_wonid',
	player3_name='$player3_name',
	player3_wonid='$player3_wonid',
	reserve1_name='$reserve1_name',
	reserve1_wonid='$reserve1_wonid',
	reserve2_name='$reserve2_name',
	reserve2_wonid='$reserve2_wonid',
	email='$email',
	clan_web='$clan_web',
	server_type='$server_type',
	server_ip='$server_ip',
	clan_info='$clan_info'
	WHERE username='$username'";
if ($result = mysql_query($sql)) {
	echo "Thank you! Information updated.";
}
else {
	die(mysql_error());
}
?>

Of course the variables used are presumed to exist in the first place, i.e. if they are incoming variabes you may need to check if isset() or empty() first, then use addslashes() if needed.

I usually see backticks used to enclose field names rather than to enclose field data though.

[fean0r]

no luck I tried your code and get the same result, it says the info has been saved but thats about it.....

I must be missing something! probably something obvious or a silly mistake.

[fean0r]

actually! your code works perfect 🙂

Thanks for your help...

$username is what i quoted here but i need to change it to my $cookiename lol

Thanks again