Going insane

[Deposeni]

I've been trying to fix these bugs for hours and hours and hours, I've asked 5+ people who've been using PHP For years, and still no luck...

First off, I'll state the bugs: Once the database reaches 60 rows, it ALWAYS activates this piece of code

$exist = mysql_query("SELECT * FROM players WHERE name='".$_POST['user']."'");
if ($row = mysql_fetch_array($exist, MYSQL_ASSOC)){
$registered = true;
}
if ($registered) print "User already exists";
else {

So basically the user already exists (Did I mention that even when theres a player by the same name, it STILL doesn't say the user exists? I.E. I could have 20+ guys named Test, and it still doesn't activate this code).

Second bug: This is the one that is pissing me off majorly... Pardon my language, but I stayed up for 4 hours last night, and spent an hour today trying to fix this little SoB.

$useron = $_SESSION['user'];
$blah1 = mysql_query("SELECT * FROM login WHERE user='$useron'");
while ($data1 = mysql_fetch_array($blah1))

$player1 = $data1['player1'];
$player2 = $data1['player2'];
//Create the new character in Player1 if there is nothing in there.
if ($player1 == false) {
$add_user = "INSERT INTO players (name, account, race, str, con, dex, qui, piety, intel, chp, x, y, cmana, csta, level, exp, cweight) VALUES ('".$POST['name']."', '".$SESSION['user']."', '".$POST['race']."', '$str', '$con', '$dex', '$qui', '$piety', '$intel', '$chp', '500', '500', '$cmana', '$stamina', '1', '0', '0' )";
mysql_query($add_user) or die(mysql_error());
mysql_query("UPDATE login set player1= '".$POST['name']."' where user='$useron'");
}

//Something is in Player1!? Oh no! Try to put it in player2!
else if ($player2 == false) {
$add_user = "INSERT INTO players (name, account, race, str, con, dex, qui, piety, intel, chp, x, y, cmana, csta, level, exp, cweight) VALUES ('".$POST['name']."', '".$SESSION['user']."', '".$POST['race']."', '$str', '$con', '$dex', '$qui', '$piety', '$intel', '$chp', '500', '500', '$cmana', '$stamina', '1', '0', '0' )";
mysql_query($add_user) or die(mysql_error());
mysql_query("UPDATE login set player2= '".$POST['name']."' where user='$useron'");
}

//Awww the user already has two characters, so don't create the character.
else {
print "You already have two characters";
}

As you can see, this is supposed to look at the Session for the user's name, look in the table Login, compare the session name to the matching row, look at the cells player1 and player2... And if player1 exists it activates the else if statement, if player1 AND player2 exist then it says you have two characters and doesn't do jack... Well this doesn't work - it always activates the first if statement and adds to player1 - overwrites it every time... BUT it I used an print statement to see if it was even seeing that there was something in player1 - and it sees it... its just not doing anything about it.

If you want/need to see the full code its at www.lejendz.com/New%20Folder/makechar.php

Help would be nice... I've gone insane trying to fix this...

[Xoid]

try this for bug1:

<?php
$getuser = @$_POST['user'];

$exist = @mysql_query("SELECT * FROM players WHERE name='$getuser';"); 

if(@mysql_num_rows($exist)<=0)
{ 
 print "User does not exist"; 
} 
 else
    {
     print "User already exists"; 
    }

?>

[Xoid]

I will pick holes in this INSERT INTO <table> VALUE blah blah

I usually find INSERT INTO SET is alot easier to implement

instead of this;

$add_user = "INSERT INTO players (name, account, race, str, con, dex, qui, piety, intel, chp, x, y, cmana, csta, level, exp, cweight) VALUES ('".$POST['name']."', '".$SESSION['user']."', '".$_POST['race']."', '$str', '$con', '$dex', '$qui', '$piety', '$intel', '$chp', '500', '500', '$cmana', '$stamina', '1', '0', '0' )";

try this:

$add_user = "INSERT INTO players SET name='$POST['name']',
account='$SESSION['user']'";

and so on...

[Deposeni]

Doesn't work... "User does not exist"

And for bug2: I've tried changing that - it doesn't really matter... But I'll try your way once I get the bugs fixed.

[Xoid]

first things first;

patience :p

try this:

<?php
$getuser = @$_POST['user'];

$exist = @("SELECT * FROM players WHERE name='$getuser';");

$row_num = @mysql_num_rows($exist);

print $row_num;
?>

[Deposeni]

it prints '0' without the ' 's

Er it prints 0 when I type in a name thats already in the table

[Xoid]

err... it shouldn't do because it works fine on my system 🙁

I assume your calling mysql_connect? mysql_select_db ?

[Deposeni]

class database {

 var $obj = array ( 
	 	"sql_database"   	=> "lejendz_rpg",
		"sql_user"       	=> "secret",
		"sql_pass"       	=> "secret",
		"sql_host"       	=> "localhost");
 var $query_id      = "";
 var $connection_id = "";
 var $query_count   = 0;
 var $record_row    = array();

/*========================================================================*/
// Connect to the database
/*========================================================================*/  

function connect() {

	$this->connection_id = mysql_connect($this->obj['sql_host'], $this->obj['sql_user'], $this->obj['sql_pass']);

	if (!mysql_select_db($this->obj['sql_database'], $this->connection_id) )
	{
		echo ("ERROR: Cannot find database ".$this->obj['sql_database']);
	}
}
}

Thats in my config.php

$a = new database();
$a->connect();

[batman]

It prints out 0 because obviously there isn't an acount for $getuser. To check if a user already exists, what you want to use is something like this:

$name = $_POST['user'];
$exist = mysql_query("SELECT * FROM players WHERE name='$name'");
$result = mysql_num_rows($exist);
if ($result == 0)
{ 
echo "User already exists!";
} 
else 
{
echo "That name is not in use by anybody.";
}

Use this for second part:

$useron = $_SESSION['user']; 
$blah1 = mysql_query("SELECT * FROM login WHERE user='$useron'"); 
while ($data1 = mysql_fetch_array($blah1)) 
{
$player1 = $data1['player1']; 
$player2 = $data1['player2'];
}
//Create the new character in Player1 if there is nothing in there. 
if ($player1 < 0) 
{ 
$add_user = "INSERT INTO players (name, account, race, str, con, dex, qui, piety, intel, chp, x, y, cmana, csta, level, exp, cweight) VALUES ('".$_POST['name']."', '".$_SESSION['user']."', '".$_POST['race']."', '$str', '$con', '$dex', '$qui', '$piety', '$intel', '$chp', '500', '500', '$cmana', '$stamina', '1', '0', '0' )"; 
mysql_query($add_user) or die(mysql_error()); 
mysql_query("UPDATE login set player1= '".$_POST['name']."' where user='$useron'"); 
} 

//Something is in Player1!? Oh no! Try to put it in player2! 
if(($player1 > 0) && ($player2 < 0)) 
{ 
$add_user = "INSERT INTO players (name, account, race, str, con, dex, qui, piety, intel, chp, x, y, cmana, csta, level, exp, cweight) VALUES ('".$_POST['name']."', '".$_SESSION['user']."', '".$_POST['race']."', '$str', '$con', '$dex', '$qui', '$piety', '$intel', '$chp', '500', '500', '$cmana', '$stamina', '1', '0', '0' )"; 
mysql_query($add_user) or die(mysql_error()); 
mysql_query("UPDATE login set player2= '".$_POST['name']."' where user='$useron'"); 
} 

//Awww the user already has two characters, so don't create the character. 
if(($player1 > 0) && ($player2 > 0))
{ 
echo "You already have two characters in use already. Couldn't create the player."; 
}

See what that does for you.

[Bijan]

Originally posted by Xoid
first things first;

patience :p

try this:

<?php
$getuser = @$_POST['user'];

$exist = @("SELECT * FROM players WHERE name='$getuser';");

$row_num = @mysql_num_rows($exist);

print $row_num;
?>

Why don't you remove the @ signs that we can see if it's any error message??

[Deposeni]

Okay my friend helped me get bug 2 fixed, I just needed to take out a while statement... But bug1 is still there 🙁

[batman]

Did you try my code?

[Deposeni]

Yay it works! :-) Thank you batman! Now go save innocent civilians from harm... and beat penguin, joker, etc. 😛

Hey, stupid unrelated question: How would I forward someone to a new page? I've tried headers... but they obviously have to be at the top of the page .... so that doesn't work in an if/else statement

[Deposeni]

Scratch that - it doesn't work... Well it does in a sense.. it says theres already a user there - but it ALWAYS does that no matter if there is or isn't

[batman]

The headers don't need to be at the top of a page, it just can't be after any ouptput from the browser. It can't be put after and echos prints and stuff like that. But the code that you are using can only take headers after the results variable.

As for the problem try this:

$name = $_POST['user']; 
$exist = mysql_query("SELECT * FROM players WHERE name='$name'"); 
$result = mysql_num_rows($exist); 
if ($result > 0) 
{  

echo "User already exists!"; 
}  

else if($result < 0)
{ 
echo "That name is not in use by anybody."; 
}

[Deposeni]

Strangely enough it still doesn't fix it... now it always says theres no one by that name

[batman]

That is weird, because it should work.

$name = $_POST['user'];  

$exist = mysql_query("SELECT * FROM players WHERE name='$name'");  

while($result = mysql_num_rows($exist))
{  

if ($result > 0)  

{   

echo "User already exists!";  

}   

else
{  

echo "That name is not in use by anybody.";  

}
}

Try that.

[Deposeni]

Just tried it, it doesn't say or do anything now...so still doesn't work

[batman]

Crap, I don't know why it's not working. Try this:

$name = $_POST['user'];   

$exist = mysql_query("SELECT * FROM players WHERE name='$name'");   

$result = mysql_fetch_array($exist); 

if ($result > 0)   

{    

echo "User already exists!";   

}    

else 
{   

echo "That name is not in use by anybody.";   

} 

[Deposeni]

Atleast it says something now... Now it ALWAYS says the name is not in use by anybody... when it is (like 25 times)