PHP Template Variables...

madcat

Hi-

I'm trying to build this small template system...but I keep getting an error. The links in menu.php point to $page.html. But the problem seems to lie in the require_once ("$page.html"); - This is not allowed. How come? This is the error:

Fatal error: Failed opening required '.html' (include_path='.;c:\php4\pear') in C:\FoxServ\www\Other\template.php on line 12

Thanks for any help!

Also, if and when it works should I change that to $_GET['page'].html instead of $page.html?

planetsim

Never ever have a variables in any includes its not good programming.

Its also why you are getting the error.

madcat

So, I shouldn't attempt what I'm trying to do? How would I do that?

Thora_Fan

Originally posted by planetsim
Never ever have a variables in any includes its not good programming.

Why exactly? I've never heard of that, and was actually planning on doing the exact same thing in a script I will soon be writing. Is there a better way?

ahundiak

madcat,

The problem is that $page has not been set. You probably need to do something like
$page = $_GET['page'];

To set it's value. The require_once statement is trying to load a file called '.html' because $page is not being set.

All,
I'm pretty sure planetsim was joking about not having variables in includes. Developer humor can be subtle.

madcat

Thanks-

But say I have a template.php page where I'm calling in the other pages of the website. My objective is to fill that $page.html variable with a default page so I don't get the error...

Where would $page = $GET['page']; (or $page = $GET['default']😉 actually go in the document? First thing in template.php? Where would I store the default page exactly- right with my other .html docs- because I've tried doing this and I still get errors.

Basically, how do I make it so my default page is filling the $page variable when a user comes to the site- and is replaced each time a new variable is clicked on via a link?

That was subtle humor? That's like calling the Grand Canyon a pebble. :p

ahundiak

<div class="body">
<?php 
  $page = $_GET['page'];
  if ($page === null) $page='default';
  echo $page; /* For debugging */
  require_once ("$page.html"); 
?>
</div>

I assume your menu links are something like
index.php?page=whatever

madcat

Supercool! Thank, I understand...

But that $page = 'default'; statement seems to put the word 'default' before the actual page information in default.html. That shouldn't be I don't think.

Anyway, thanks that's awesome...

madcat

echo $page; / For debugging /

Ah, I see what you are saying...never mind.