Having problems emailing query results

dmyers

Ok, I am fairly new to php, but have been doing Visual Basic and C++ for years so I have the theories and pricipals of programming down pretty good.

I am having two problems with this page that are driving me NUTS. I have looked and looked, tried and tried but can not seem to find the problem.

The php page is a lost password utility for a website I am designing. The first problem is that when the page first appears, it displays every record in the database. This is done because I have used echo to display the results of my query, but even if I didn't echo the results it would still be pulling every record to begin with. I need it to not make any query until the "Submit" button is clicked.

The second problem is that it will not mail the password to the user, who's email address is the vaiable $uemail. That vaiable is retrived from a text box on the form that is filled in by the user. The form then should query the database looking for anyone with that email address and email the required information back to the user at that email address.

Can someone help me and tell me what I am doing wrong?

--- Start of PHP Code ---

<html>
<head>
<title>Find Password</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

}
</style>

</head>

<body bgcolor="#FFFFFF">
<table width="60%" border="0" cellspacing="5" cellpadding="0" align="center">
<tr>
<td colspan="3">
<div align="center"></div>
</td>
</tr>
<tr>
<td width="17%">
<div align="left"><img src="../../images/GLTA-logo-new.gif" width="120" height="98"></div>
</td>
<td width="62%">
<div align="center"><b><font color="#000000">Please note that if you have
not set up your Password Retrieval Profile, which includes providing your
e-mail address, you will not be able to use this feature.</font></b></div>
</td>
<td width="21%"><img src="../../images/GLTA-logo-new.gif" width="120" height="98"></td>
</tr>
<tr>
<td colspan="3" height="11"> </td>
</tr>
</table>
<form name="form1" >
<table width="342" border="1" cellspacing="3" cellpadding="3" bordercolor="#333333" align="center">
<tr align="center" bgcolor="A5E2FF">
<td colspan="2"><font face="Tahoma"><b><font color="#FF0000">Retrieve Account
Information</font></b></font></td>
</tr>
<tr bgcolor="#CCCCCC">
<td width="224" bgcolor="#FFFFCC">
<input type="text" name="uemail" size="30" value="Type your email address here">
</td>

<td width="118" bgcolor="#FFFFCC">
<input type="submit" name="Submit" value="Find Account">
</td>
</tr>
</table>
</form>
<table width="40%" border="0" cellspacing="0" cellpadding="0" align="center">
<tr>
<td>
<div align="center"><b><font color="#000000">Click <a href="../login.php" target="_self">here</a>
to go back to the login screen.</font></b> </div>
</td>
</tr>
</table>

<?
@mysql_connect('**', '', '') or die(mysql_error());
@$result = mysql_list_tables('**') or die(mysql_error());

$sql = "SELECT * FROM authuser WHERE email = '$uemail'";
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

while ($row = mysql_fetch_row($result)) {
// $tb_names[] = $row[0];
// echo "System ID: ";
// echo $row[0].'<br />';
echo "First Name: ";
echo $row[8].'<br />';
echo "Last Name: ";
echo $row[9].'<br />';
echo "User Group: ";
echo $row[3].'<br />';
echo "Status: ";
echo $row[5].'<br />';
echo "Username: ";
echo $row[1].'<br />';
echo "Password: ";
echo $row[11].'<br />';
// echo "Encrypted Password: ";
// echo $row[2].'<br />';
// echo "Level: ";
// echo $row[4].'<br />';
// echo "Last Logon: ";
// echo $row[6].'<br />';
// echo "Logon Count: ";
// echo $row[7].'<br />';
echo "E-Mail Address: ";
echo $row[10].'<br />';

$username = $row[1];
$firstname = $row[8];
$lastname = $row[9];
$password = $row[11];
$email = $row[10];
$group = $row[3];
$status = $row[5];
$uemail = $row[10];
}

$msubject = "Account information from GLTA";
$mbody .= "The account information you requested is displayed below.\n";
$mbody .= "\n";
$mbody .= "Username\t\t: $username \r\n";
$mbody .= "Password\t\t: $password \r\n";
$mbody .= "E-Mail\t\t: $email \r\n";
$mbody .= "User Group\t\t: $group \r\n";
$mbody .= "Access Level\t\t: $level \r\n";
$mbody .= "Status\t\t: $status \r\n";
$mheader = "From: GLTA Security";

$to = "$uemail <$uemail>";
$headers = "From: \"".addslashes($uemail)."\" <".$uemail.">\r\n";
$headers .= "MIME-Version: 1.0\r\n";
$headers .= "Content-Type: text/html; charset=iso-8859-1\r\n";
$headers .= "X-Priority: 1\r\n";
$headers .= "X-Mailer: PHP / ".phpversion()."\r\n";
mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";
?>
The email to <?=$to?> (<?=$to?> ) Was send successfully.<br><br>
The message was: <?=$mbody?><br><br>

And the headers were: <?=$headers?>
</body>
</html>

--- End of PHP Code ---

PHPdev

Well the first thing is that you have to make sure the submit button has been clicked (like you mentioned). I prefre to do this by cecking the number of elements in the $_POST array. Like this

if (count($_POST) > 0) {

}

This way if the count() funtion returns a value greater than 0 I know the form has been submitted....

As far as why it is not emailing.. I am not sure at this point....

Thanks

PHPdev

dmyers

Were would I put that bit of code?

PHPdev

Sorry my mind is a little spacey today...

you would wrap the entire PHP section with it, starting from where you connect to the database until you send the email. This shoud limit when the db query is called and when the email is sent.

PHPdev

dmyers

I wrapped the code like you said and I do not get all the records at the begining. But I also do not get any recoards when I click the submit button. I get:

The email to ( ) Was send successfully.

The message was:

And the headers were:

Which is the base text in the HTML ststement after the php code.

Any idesa?

<?
if (count($_POST) > 0) {
@mysql_connect('localhost', 'gltanet_gltaadmi', 'gltaglta') or die(mysql_error());
@$result = mysql_list_tables('gltanet_gltauser') or die(mysql_error());

$sql = "SELECT * FROM authuser WHERE email = '$uemail'";
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

$username = $row[1];
$firstname = $row[8];
$lastname = $row[9];
$password = $row[11];
$email = $row[10];
$group = $row[3];
$status = $row[5];
$uemail = $row[10];

}

$to = "$uemail <$uemail>";
$headers = "From: \"".addslashes($uemail)."\" <".$uemail.">\r\n";
$headers .= "MIME-Version: 1.0\r\n";

$headers .= "Content-Type: text/html; charset=iso-8859-1\r\n";

$headers .= "X-Priority: 1\r\n";

$headers .= "X-Mailer: PHP / ".phpversion()."\r\n";

mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";

}
?>

PHPdev

Once entering the if statement your echos should still output data... one thing to check is to make sure your form is posting to the same PHP page....

something else you can do for debugging is to...

load the page in the browser....
edit the file adding
<?php
phpinfo();
die();
?>

so when you submit the form you can see exactly what values get passed to the server, there will be a section that will show you the HTML varialbes, $_POST, etc...

Thanks

PHPdev

Paulus_Magnus

I'm kind of surprised it works at all as the HTML isn't formatted as it should be. You're relying on the browser to interpret the HTML code and fill in the gaps, which isn't good practice as I'm sure you're aware.

On the <form> tag you should really have a method="POST" and action="<?=$PHP_SELF?>" to force the variables to be posted back to this same PHP script.

I guess you're working with a newer version of PHP where the register globals setting is now turned off. Form variables don't automatically get converted to variables so you'd have to use $_POST['uemail'] instead of $uemail.

I guess your echo strings after the query are just to test your query rather than anything on the system or you'd be revealing all of a user's information otherwise.

I'd also suggest using mysql_fetch_array rather than mysql_fetch_row as it makes your code far more readable by using $row['lastname'], saves having to load $lastname with the same value, doesn't increase the execution time significantly and also adapts should you insert extra columns into your database table.

dmyers

Is this what you meant it to look like. Because this is what I get as a response.

.
..
...
....
E-Mail Address: dmyers@4-webdesign.net
Error handling message. message not sent. The email to <> ( <> ) Was send successfully.

The message was: The account information you requested is displayed below. Username : Password : E-Mail : User Group : Access Level : Status :

And the headers were: From: "dmyers@4-webdesign.net" MIME-Version: 1.0 Content-Type: text/html; charset=iso-8859-1 X-Priority: 1 X-Mailer: PHP / 4.3.1

--- Start of code ---

<html>
<head>
<title>Find Password</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

}
</style>

</head>

<body bgcolor="#FFFFFF">
<table width="60%" border="0" cellspacing="5" cellpadding="0" align="center">
<tr>
<td colspan="3">
<div align="center"></div>
</td>
</tr>
<tr>
<td width="17%">
<div align="left"><img src="../../images/GLTA-logo-new.gif" width="120" height="98"></div>
</td>
<td width="62%">
<div align="center"><b><font color="#000000">Please note that if you have
not set up your Password Retrieval Profile, which includes providing your
e-mail address, you will not be able to use this feature.</font></b></div>
</td>
<td width="21%"><img src="../../images/GLTA-logo-new.gif" width="120" height="98"></td>
</tr>
<tr>
<td colspan="3" height="11"> </td>
</tr>
</table>
<form name="form1" method="POST" action="<?=$PHP_SELF?>" >
<table width="342" border="1" cellspacing="3" cellpadding="3" bordercolor="#333333" align="center">
<tr align="center" bgcolor="A5E2FF">
<td colspan="2"><font face="Tahoma"><b><font color="#FF0000">Retrieve Account
Information</font></b></font></td>
</tr>
<tr bgcolor="#CCCCCC">
<td width="224" bgcolor="#FFFFCC">
<input type="text" name="uemail" size="30" value="Type your email address here">
</td>

  <td width="118" bgcolor="#FFFFCC"> 
    <input type="submit" name="Submit" value="Find Account">
  </td>

</tr>
</table>
</form>
<table width="40%" border="0" cellspacing="0" cellpadding="0" align="center">
<tr>
<td>
<div align="center"><b><font color="#000000">Click <a href="../login.php" target="_self">here</a>
to go back to the login screen.</font></b> </div>
</td>
</tr>
</table>

<?
if (count($_POST) > 0) {
@mysql_connect('localhost', 'gltanet_gltaadmi', 'gltaglta') or die(mysql_error());
@$result = mysql_list_tables('gltanet_gltauser') or die(mysql_error());

$sql = "SELECT * FROM authuser WHERE email = '$uemail'";
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

$_POST['username'] = $row[1];
$_POST['firstname'] = $row[8];
$_POST['lastname'] = $row[9];
$_POST['password'] = $row[11];
$_POST['email'] = $row[10];
$_POST['group'] = $row[3];
$_POST['status'] = $row[5];
$_POST['uemail'] = $row[10];

}

$to = "$POST['uemail'] <$POST['uemail']>";
$headers = "From: \"".addslashes($POST['uemail'])."\" <".$POST['uemail'].">\r\n";
$headers .= "MIME-Version: 1.0\r\n";

$headers .= "Content-Type: text/html; charset=iso-8859-1\r\n";

$headers .= "X-Priority: 1\r\n";

$headers .= "X-Mailer: PHP / ".phpversion()."\r\n";

mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";

}
?>
The email to <?=$to?> (<?=$to?> ) Was send successfully.<br><br>
The message was: <?=$mbody?><br><br>

And the headers were: <?=$headers?>
</body>
</html>

Paulus_Magnus

Nope, not at all.

All your form variables are coming into the page in an array called $POST. You need to modify your query to where email={$POST['uemail']}, please note the braces around the array variable so as not to confuse the PHP parser.

The other use of $POST everywhere is just wrong. $POST is incoming variables and should only be used as read-only array.

dmyers

This is what I did so far. When I run it I get an error that says:

Parse error: parse error, unexpected ']', expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/gltanet/public_html/secure/lostpass/getpass2.php on line 86

I have attached the file to this reply if it helps any. As I said earlier, sorry to be so much trouble.

<?
if (count($_POST) > 0) {
@mysql_connect('localhost', 'gltanet_gltaadmi', 'gltaglta') or die(mysql_error()); 
@$result = mysql_list_tables('gltanet_gltauser') or die(mysql_error()); 

$sql = "SELECT * FROM authuser WHERE email={$_POST['uemail']}; 
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

while ($row = mysql_fetch_row($result)) {
    // $tb_names[] = $row[0]; 
    // echo "System ID: ";
	// echo $row[0].'<br />';
	echo "First Name: ";
	echo $row[8].'<br />';
	echo "Last Name: ";
	echo $row[9].'<br />';
	echo "User Group: ";
	echo $row[3].'<br />';
	echo "Status: ";
	echo $row[5].'<br />';
	echo "Username: ";
	echo $row[1].'<br />';
	echo "Password: ";
	echo $row[11].'<br />';
	// echo "Encrypted Password: ";
	// echo $row[2].'<br />';
	// echo "Level: ";
	// echo $row[4].'<br />';
	// echo "Last Logon: ";
	// echo $row[6].'<br />';
	// echo "Logon Count: ";
	// echo $row[7].'<br />';
	echo "E-Mail Address: ";
	echo $row[10].'<br />';


$username = $row[1];
$firstname = $row[8];
$lastname = $row[9];
$password = $row[11];
$email = $row[10];
$group = $row[3];
$status = $row[5];
$uemail = $row[10];
}

$msubject = "Account information from GLTA";
$mbody .= "The account information you requested is displayed below.\n";
$mbody .= "\n";
$mbody .= "Username\t\t: $username \r\n"; 
$mbody .= "Password\t\t: $password \r\n";
$mbody .= "E-Mail\t\t: $email \r\n";
$mbody .= "User Group\t\t: $group \r\n";
$mbody .= "Access Level\t\t: $level \r\n";
$mbody .= "Status\t\t: $status \r\n";
$mheader = "From: GLTA Security";

$to  = "$uemail <$uemail>";
$headers = "From: \"".addslashes($uemail)."\" <".$uemail.">\r\n"; 
$headers   .= "MIME-Version: 1.0\r\n";  

$headers   .= "Content-Type: text/html; charset=iso-8859-1\r\n";  

$headers   .= "X-Priority: 1\r\n";  

$headers   .= "X-Mailer: PHP / ".phpversion()."\r\n";  

mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";  

}
?> 
The email to <?=$to?> (<?=$to?> ) Was send successfully.<br><br> 
The message was: <?=$mbody?><br><br> 

And the headers were: <?=$headers?> 
</body>
</html>

BuzzLY

Not sure where line 86 is, but you are missing a " on your sql line:

$sql = "SELECT * FROM authuser WHERE email={$_POST['uemail']};

Should read:

$sql = "SELECT * FROM authuser WHERE email={$_POST['uemail']}";

I didn't check the rest of your code to check for errors... make sure all of your syntax is correct.

dmyers

I am getting this error message.

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '@4-webdesign.net' at line 1
SELECT * FROM authuser WHERE email = dmyers@4-webdesign.net

Here is the new code.


<?
if ( isset ( $_POST ["uemail"] ) ) {
@mysql_connect('localhost', 'gltanet_gltaadmi', 'gltaglta') or die(mysql_error()); 
@$result = mysql_list_tables('gltanet_gltauser') or die(mysql_error()); 

$sql = "SELECT * FROM authuser WHERE email = {$_POST['uemail']}"; 
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

while ($row = mysql_fetch_row($result)) {
    // $tb_names[] = $row[0]; 
    // echo "System ID: ";
	// echo $row[0].'<br />';
	echo "First Name: ";
	echo $row[8].'<br />';
	echo "Last Name: ";
	echo $row[9].'<br />';
	echo "User Group: ";
	echo $row[3].'<br />';
	echo "Status: ";
	echo $row[5].'<br />';
	echo "Username: ";
	echo $row[1].'<br />';
	echo "Password: ";
	echo $row[11].'<br />';
	// echo "Encrypted Password: ";
	// echo $row[2].'<br />';
	// echo "Level: ";
	// echo $row[4].'<br />';
	// echo "Last Logon: ";
	// echo $row[6].'<br />';
	// echo "Logon Count: ";
	// echo $row[7].'<br />';
	echo "E-Mail Address: ";
	echo $row[10].'<br />';


$username = $row[1];
$firstname = $row[8];
$lastname = $row[9];
$password = $row[11];
$email = $row[10];
$group = $row[3];
$status = $row[5];
$uemail = $row[10];
}

$msubject = "Account information from GLTA";
$mbody .= "The account information you requested is displayed below.\n";
$mbody .= "\n";
$mbody .= "Username\t\t: $username \r\n"; 
$mbody .= "Password\t\t: $password \r\n";
$mbody .= "E-Mail\t\t: $email \r\n";
$mbody .= "User Group\t\t: $group \r\n";
$mbody .= "Access Level\t\t: $level \r\n";
$mbody .= "Status\t\t: $status \r\n";
$mheader = "From: GLTA Security";

$to  = "$uemail <$uemail>";
$headers = "From: \"".addslashes($uemail)."\" <".$uemail.">\r\n"; 
$headers   .= "MIME-Version: 1.0\r\n";  

$headers   .= "Content-Type: text/html; charset=iso-8859-1\r\n";  

$headers   .= "X-Priority: 1\r\n";  

$headers   .= "X-Mailer: PHP / ".phpversion()."\r\n";  

mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";  

}
?> 
The email to <?=$to?> (<?=$to?> ) Was send successfully.<br><br> 
The message was: <?=$mbody?><br><br> 

And the headers were: <?=$headers?> 
</body>
</html>

BuzzLY

You need to remember the proper syntax for a SQL statement. The where clause needs to be contained within single quotes:

WHERE thefield = 'whatever@blah.com'

Your SQL statement doesn't have that, so it dies. Here is my recommendation:

$uemail = $_POST['uemail'];
$sql = "SELECT * FROM authuser WHERE email = '" . $uemail . "'";

That should work. The first line is optional, of course, but it helps prevent problems when register_globals is set to OFF -- you only have to add that one line and your code should work fine. You don't have to go through all of your code replacing $uemail with $_POST['uemail'].

HTH

dmyers

I fixed that problem by putting apostrphies around the value in the sql.

email = '{$_POST['uemail']}'";

Any idea what is wrong with this mail function?


<?
if ( isset ( $_POST ["uemail"] ) ) {
@mysql_connect('localhost', 'gltanet_gltaadmi', 'gltaglta') or die(mysql_error()); 
@$result = mysql_list_tables('gltanet_gltauser') or die(mysql_error()); 

$sql = "SELECT * FROM authuser WHERE email = '{$_POST['uemail']}'"; 
@$result = mysql_query($sql) or die(mysql_error().'<p>'.$sql.'</p>');

while ($row = mysql_fetch_row($result)) {
    // $tb_names[] = $row[0]; 
    // echo "System ID: ";
	// echo $row[0].'<br />';
	echo "First Name: ";
	echo $row[8].'<br />';
	echo "Last Name: ";
	echo $row[9].'<br />';
	echo "User Group: ";
	echo $row[3].'<br />';
	echo "Status: ";
	echo $row[5].'<br />';
	echo "Username: ";
	echo $row[1].'<br />';
	echo "Password: ";
	echo $row[11].'<br />';
	// echo "Encrypted Password: ";
	// echo $row[2].'<br />';
	// echo "Level: ";
	// echo $row[4].'<br />';
	// echo "Last Logon: ";
	// echo $row[6].'<br />';
	// echo "Logon Count: ";
	// echo $row[7].'<br />';
	echo "E-Mail Address: ";
	echo $row[10].'<br />';


$username = $row[1];
$firstname = $row[8];
$lastname = $row[9];
$password = $row[11];
$email = $row[10];
$group = $row[3];
$status = $row[5];
$uemail = $row[10];
}

$msubject = "Account information from GLTA";
$mbody .= "The account information you requested is displayed below.\n";
$mbody .= "\n";
$mbody .= "Username\t\t: $username \r\n"; 
$mbody .= "Password\t\t: $password \r\n";
$mbody .= "E-Mail\t\t: $email \r\n";
$mbody .= "User Group\t\t: $group \r\n";
$mbody .= "Access Level\t\t: $level \r\n";
$mbody .= "Status\t\t: $status \r\n";
$mheader = "From: GLTA Security";

$to  = "$uemail <$uemail>";
$headers = "From: \"".addslashes($uemail)."\" <".$uemail.">\r\n"; 
$headers   .= "MIME-Version: 1.0\r\n";  

$headers   .= "Content-Type: text/html; charset=iso-8859-1\r\n";  

$headers   .= "X-Priority: 1\r\n";  

$headers   .= "X-Mailer: PHP / ".phpversion()."\r\n";  

mail( $to, $msubject, $mbody, $headers ) or print "Error handling message. message not sent.";  

}
?> 
The email to <?=$to?> (<?=$to?> ) Was send successfully.<br><br> 
The message was: <?=$mbody?><br><br> 

And the headers were: <?=$headers?> 
</body>
</html>