problems with forms/php

gmartin1215

I am new to PHP and am experiencing a problem with passing variables from a form to a MySQL db. I am running PHP 4.2.3 and Apache 1.3.27 locally. Whenever I enter values in the form to be sent to the db, noting happens except for a refreesh of the form. Here is the file I using:

<html>

<body>

<?php

$db = mysql_connect("localhost", "root");

mysql_select_db("mydb",$db);

if ($submit) {

// here if no ID then adding else we're editing

if ($id) {

$sql = "UPDATE employees SET first='$first',last='$last',address='$address',position='$position' WHERE id=$id";

} else {

$sql = "INSERT INTO employees (first,last,address,position) VALUES ('$first','$last','$address','$position')";

}

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

} elseif ($delete) {

// delete a record

$sql = "DELETE FROM employees WHERE id=$id";	

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

if (!$id) {

// print the list if there is not editing

$result = mysql_query("SELECT * FROM employees",$db);

while ($myrow = mysql_fetch_array($result)) {

  printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["first"], $myrow["last"]);

  printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

}

}

<P>

<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a>

<P>

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM employees WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$first = $myrow["first"];

$last = $myrow["last"];

$address = $myrow["address"];

$position = $myrow["position"];

// print the id for editing



?>

<input type=hidden name="id" value="<?php echo $id ?>">

<?php

}

First name:<input type="Text" name="first" value="<?php echo $first ?>"><br>

Last name:<input type="Text" name="last" value="<?php echo $last ?>"><br>

Address:<input type="Text" name="address" value="<?php echo $address ?>"><br>

Position:<input type="Text" name="position" value="<?php echo $position ?>"><br>

</form>

<?php

}

</body>

</html>

Could I have something set wrong in my php.ini file?

cgraz

Haven't looked at how your structure is setup on your if; I'll just assume it's correct. So change

if ($submit) {

if (isset($_POST["submit"])) {

Cgraz

gmartin1215

Thanks! That at least did something else. I gave me the reply page "Record updated/edited!" and created a new row in the db. But, no information got passed to the db

cgraz

change all your form variables from

$var_name

$_POST['var_name']

Then you'll get the values.

Cgraz

gmartin1215

so,

change

First name:<input type="Text" name="first" value="<?php echo $first ?>">

First name:<input type="Text" name="first" value="<?php echo $_POST['first'] ?>">

and so forth?

cgraz

if $first is a variable that comes from your form, then yes. $_POST is only for use when you have a form with the method of post and want to get the values.

Cgraz

gmartin1215

ok, I made those changes for the form, but it is still inserting an empty row, and then tried something different, and still nothing. and the delete does not work either. Here is my updated code:

<html>
<body>
<?php
$db = mysql_connect("localhost", "root");
mysql_select_db("mydb",$db);
if (isset($_POST["submit"])) {

// here if no ID then adding else we're editing
if ($id) {
$sql = "UPDATE employees SET first='$first',last='$last',address='$address',position='$position' WHERE id=$id";
} else {
$sql = "INSERT INTO employees (first,last,address,position) VALUES ('$first','$last','$address','$position')";
}

// run SQL against the DB
$result = mysql_query($sql);
echo "Record updated/edited!<p>";

} elseif ($delete) {
// delete a record
$sql = "DELETE FROM employees WHERE id=$id";
$result = mysql_query($sql);
echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

if (!$id) {
// print the list if there is not editing
$result = mysql_query("SELECT * FROM employees",$db);
while ($myrow = mysql_fetch_array($result))
{
printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["first"], $myrow["last"]);
printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

}
?>

<P>
<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a>
<P>
<form method="post" action="<?php echo $PHP_SELF?>">

<?php
if ($id) {
// editing so select a record
$sql = "SELECT * FROM employees WHERE id=$id";
$result = mysql_query($sql);
$myrow = mysql_fetch_array($result);
$id = $myrow["id"];
$first = $myrow["first"];
$last = $myrow["last"];
$address = $myrow["address"];
$position = $myrow["position"];
// print the id for editing
?>
<input type=hidden name="id" value="<?php echo $id ?>">
<?php } ?>
First name:<input type="Text" name="first" value="<?php echo $HTTP_POST_VARS['first'] ?>"><br>
Last name:<input type="Text" name="last" value="<?php echo $HTTP_POST_VARS['last'] ?>"><br>
Address:<input type="Text" name="address" value="<?php echo $HTTP_POST_VARS['address'] ?>"><br>
Position:<input type="Text" name="position" value="<?php echo $HTTP_POST_VARS['position'] ?>"><br>
</form>
<?php } ?>
<input type="Submit" name="submit" value="Enter information">
</body>
</html>

cgraz

$sql = "UPDATE employees SET first='$first',last='$last',address='$address',pos
ition='$position' WHERE id=$id";
} else {
$sql = "INSERT INTO employees (first,last,address,position) VALUES ('$first','$last','$address','$position')";

Are these variables coming from a form? If so, then you should have also changed these to $_POST

Cgraz

batman

instead of changing all that, it would of been easier to just do something like this at the top of the page. In fact use this:

<html> 
<body> 
<?php 
$first = $_POST['first'];
$last = $_POST['last'];
$address = $_POST['address'];
$position = $_POST['position'];
$id = $_POST['id'];

$db = mysql_connect("localhost", "root"); 
mysql_select_db("mydb",$db); 
if (isset($_POST["submit"])) { 

// here if no ID then adding else we're editing 
if ($id) { 
$sql = "UPDATE employees SET first='$first',last='$last',address='$address',pos
ition='$position' WHERE id=$id"; 
} else { 
$sql = "INSERT INTO employees (first,last,address,position) VALUES ('$first','$last','$address','$position')"; 
} 

// run SQL against the DB 
$result = mysql_query($sql); 
echo "Record updated/edited!<p>"; 

} elseif ($delete) { 
// delete a record 
$sql = "DELETE FROM employees WHERE id=$id"; 
$result = mysql_query($sql); 
echo "$sql Record deleted!<p>"; 

} else { 

// this part happens if we don't press submit 

if (!$id) { 
// print the list if there is not editing 
$result = mysql_query("SELECT * FROM employees",$db); 
while ($myrow = mysql_fetch_array($result)) 
{ 
printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["first"], $myrow["last"]); 
printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]); 

} 
} 
?> 

<P> 
<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a> 
<P> 
<form method="post" action="<?php echo $PHP_SELF?>"> 

<?php 
if ($id) { 
// editing so select a record 
$sql = "SELECT * FROM employees WHERE id=$id"; 
$result = mysql_query($sql); 
$myrow = mysql_fetch_array($result); 
$id = $myrow["id"]; 
$first = $myrow["first"]; 
$last = $myrow["last"]; 
$address = $myrow["address"]; 
$position = $myrow["position"]; 
// print the id for editing 
?> 
<input type=hidden name="id" value="<?php echo $id ?>"> 
<?php } ?> 
First name:<input type="Text" name="first" value="<?php echo $HTTP_POST_VARS['first'] ?>"><br> 
Last name:<input type="Text" name="last" value="<?php echo $HTTP_POST_VARS['last'] ?>"><br> 
Address:<input type="Text" name="address" value="<?php echo $HTTP_POST_VARS['address'] ?>"><br> 
Position:<input type="Text" name="position" value="<?php echo $HTTP_POST_VARS['position'] ?>"><br> 
</form> 
<?php } ?> 
<input type="Submit" name="submit" value="Enter information"> 
</body> 
</html>

DoD

batman, thats what i do on all of mine, too. My server got upgraded after a hack, all my scripts stoped working, and resetting them in the top fixed this for me.

Also, it means i dont have _POST's flying about, and i just prefer it

gmartin1215

ok, I pasted the code exactly as batman has it, and still no changes. What could be wrong??