Array in method

JakesSA

Hi guys

Ive got a query in my class the pulls the data out in an array with mysql_fetch_array(). eg

$this->data = mysql_fetch_array($this->result)
{
     print $this->data['cat_name'];
     print $this->data['cat_desc'];
}

or 

$this->data = mysql_fetch_array($this->result)
{
     return $this->data['cat_name'];
     return $this->data['cat_desc'];
}

When I echo / print from within the method it returns the desired result (but not very good OOP design).

So if I try to return the data it will obviously only return the first line and then exit.

My question is, how do I loop the method data out from a object that I have created. I somehow need to loop out the assoc array.

Thanks in advace

laserlight

Well, a direct transformation would be:

$this->data = mysql_fetch_array($this->result) 
{ 
     return $this->data['cat_name'] . $this->data['cat_desc']; 
}

Unless you're only dealing with 1 row from the DB table, I doubt if this is what you want, though.

adamgeorge

You can't have 2 returns in a row like that. The method will obviously leave itself from the 1st return, and the 2nd one will never happen.

I somehow need to loop out the assoc array.

You can only return ONE variable from a function or method.

If you want to return the entire $this->data array, then just do that:

$this->data = mysql_fetch_array($this->result);

return $this->data;

Although, there's no need to use a global property to store the data and result identifier if you plan on returning it (unless you have a good reason). May as well do this:

$result = mysql_query("select blaldj'sa");
$data = mysql_fetch_array($result);
return $data;

JakesSA

The problem is that if I save it as an array, it stores one row twice when I var_dump() it out.

$this->data = mysql_fetch_array($this->result){
return $this->data; 
}

I need to store all the results in the array and when I call that method do some thing as simple as:


foreach($obj->data as $var=>$val)
$newVar[$var] = $val;{
print $newVar['cat_name'];
}

Something as simple as that does seem to be wanting to work...any other ideas guys.

Thanks

laserlight

I need to ask, what is "it"?
What kind of data do you expect?
A single row returned from your query?
Multiple rows?

$this->data = mysql_fetch_array($this->result){ 
return $this->data;  

}

What this does is assign the array result of 1 row of the given query into the member variable $data, then returns $data

If you want to get all the rows returned, it would be something like:

$result_array = array();
while ($row = mysql_fetch_array($this->result)) {
	$result_array[] = $row;
}
return $result_array;

this would return the rows, each as an array, as an array.
Then you might assign $this->data to this array of arrays.

JakesSA

@ laserlight

If you want to get all the rows returned, it would be something like:

$result_array = array();
while ($row = mysql_fetch_array($this->result)) {
$result_array[] = $row;
}
return $result_array;

it still only produces one result twice. I want to store all the results in an assoc array, within the method. So when I initialize the object I can print the data from the array one row at a time.

eg. (from your example above)


//something to the lines of....

$obj = new category();
$obj->category();

 foreach ($result_array as $val)
 {
      print $val
 }

ahundiak

mysql_fetch_array returns both a assoc array and a numeric array. That may explain why you seem to be getting a row twice.

while($rows[] = mysql_fetch_assoc($result));

foreach($rows as $row)
{
  foreach($row as $name=>$value)
  {
    echo $name . '=' . $value . '<br />';
  }
}

barand

class aClass {

var $result_array = array();

function aMethod () {
    ....
    while ($this->data = mysql_fetch_array($this->result) )
    { 
        $this->result_array[$this->data['cat_name'] ] =  $this->data['cat_desc']; 
    } 
}


}


$obj = new aClass;
aClass->aMethod();

$result = aClass->$result_array;

foreach ($result as $name=>$desc) {
   // process array
}

hth

adamgeorge

I think that might throw a syntax error cause I don't think you can have an array as an index to another array like you did here:

$this->result_array[$this->data['cat_name'] ] =  $this->data['cat_desc'];

prolly should do this instead:

$catName = $this->data['cat_name'];
$this->result_array[$catName] = $catName;

I may be wrong though... I can't quite remember, but I'm pretty sure you can't do what you had there.

-Adam 🙂

laserlight

hmm... I had the impression that mysql_fetch_array() somehow gets the array to store both the numeric indices and associates indices all at once.
I remember as a newbie using it and it didnt seem different to mysql_fetch_assoc() in that respect.

"it still only produces one result twice"
I think that it is time to go to the root and look at your query.
Could it be that your query, and what happens between its execution and the while loop, causes only 1 row to be selected, and somehow duplicated?

JakesSA

@ laserlight

Its not the query....trust me. When you print out from within the method you get the desire result. That array set I need to return it then loop out latter.

ahundiak

So is it working or not?

JakesSA

I hit the resolved thread by mistake (2:32 am here, so the brain is in reverse mode) ... will check it in the morning and let you guys know.

😃