adding the contents of a file to a variable.

[djdaz]

How would i go abouts adding the contents of a file to a variable, i have tried this method where file is the path to the file.

$olddata=@fopen($file);

but it dont work.

any suggestions?

[elToro]

fopen just opens the file; it doesn't read it. You need to use fread as well.

$filename = "/usr/local/something.txt";
$handle = fopen ($filename, "r");
$contents = fread ($handle, filesize ($filename));
fclose ($handle);

[djdaz]

that dont work either?
heres my entire script, but first ill explain what im trying to acheive, i need a function to get the contents of the file as it is, then write some new stuff to this file (and delete everthing else) this i get working, but after this i want to put the old contents of the file back onto the bottom, this dosnt work. Sorry about the messy code, i havn't got use to making it clear yet.

<?php
$file='/tier-2/pwpstore2/6/generalsworld/htdocs/staff/admin/news/comnews.htm';
$handle2 =@fopen ($file, "r"); 
$olddata = @fread ($handle2, ($file)); 
@fclose ($handle2);


$subject=($_POST['subject']);
$body=($_POST['body']);
$username=($_GET['username']);
$date=date('d/m/Y H:i');
$handle=@fopen($file, 'w+');

@fwrite($handle,
		"<table border='0' cellspacing='0' cellpading='0'> \n" . 
		"<tr> \n" .
		"<td><font size='2'><b> $subject" .
		"</b></font>|<font size='1' color='#4D4D4D'><b>Posted by</b> $username" .
		", <b>Date/Time</b> $date" .
		".</font></td> \n" .
		"</tr> \n" .
		"<tr> \n" .
		"<td>" .
		"$body" .
		"</td> \n" .
		"</tr> \n" .
		"</table> \n" .
		"<br> $olddata \n"
	);
@fclose($handle)
?>
<?php include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml') ;?>
<br>
Your new news has been appended to the front page.
<?php include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml') ;?>
		

[bad76]

Hi,
try to remove @ and look if any error happens...
And for write you should have the permission.

Also make this easy try

$olddata=fopen($file);
echo $olddata;

see you

[djdaz]

Originally posted by bad76
Hi,
try to remove @ and look if any error happens...
And for write you should have the permission.

Also make this easy try

$olddata=fopen($file);
echo $olddata;

see you [/B]

trying that gives me this error

Wrong parameter count for fopen()

[bad76]

Sure !
Sorry but i've readed wrong :p ....
You can use file instead of fopen:

$olddata=file($file);
echo $olddata;

This will echos contents of your file.

But for write you have look for permission?

$handle=fopen($file, 'w+'); 

fwrite($handle, 
        "<table border='0' cellspacing='0' cellpading='0'> \n" .  

        "<tr> \n" . 
        "<td><font size='2'><b> $subject" . 
        "</b></font>|<font size='1' color='#4D4D4D'><b>Posted by</b> $username" . 
        ", <b>Date/Time</b> $date" . 
        ".</font></td> \n" . 
        "</tr> \n" . 
        "<tr> \n" . 
        "<td>" . 
        "$body" . 
        "</td> \n" . 
        "</tr> \n" . 
        "</table> \n" . 
        "<br> $olddata \n" 
    ); 
fclose($handle) 

without @, give you any error?

[laserlight]

$olddata = @fread ($handle2, ($file));

that's the problem, you need to use:

$olddata = @fread ($handle2, filesize($file));

still, you could use bad76's suggestion, but you will need to loop through the $olddata variable since file() returns an array.

[HalfaBee]

This does what you want.

I also added the htmlspecialchars() to the input data.
Without these your site is open to attack.

HalfaBee

<?php 
$file='/tier-2/pwpstore2/6/generalsworld/htdocs/staff/admin/news/comnews.htm'; 
$olddata = @file_get_contents ( $file );  

$subject=htmlspecialchars($_POST['subject']); 
$body=htmlspecialchars($_POST['body']); 
$username=htmlspecialchars($_GET['username']); 
$date=date('d/m/Y H:i'); 

$handle=@fopen($file, 'w'); 

@fwrite($handle, 
        "<table border='0' cellspacing='0' cellpading='0'> \n" .  

        "<tr> \n" . 
        "<td><font size='2'><b> $subject" . 
        "</b></font>|<font size='1' color='#4D4D4D'><b>Posted by</b> $username" . 
        ", <b>Date/Time</b> $date" . 
        ".</font></td> \n" . 
        "</tr> \n" . 
        "<tr> \n" . 
        "<td>" . 
        "$body" . 
        "</td> \n" . 
        "</tr> \n" . 
        "</table> \n" . 
        "<br> $olddata \n" 
    ); 
@fclose($handle) 
?> 
<?php include($_SERVER["DOCUMENT_ROOT"].'/'.'nav.shtml') ;?> 
<br> 
Your new news has been appended to the front page. 
<?php include($_SERVER["DOCUMENT_ROOT"].'/'.'footer.shtml') ;?>