Download problem in my PHP script

NoBullMan

Hi,
I have a link in my page that allows users to download an exe file.
However, when I download and run it, it briefly displays the DOS box and
nothing happens.
In my php file, I have:

header("Content-Type: application/octet-stream");
header("Content-Disposition: atachment; filename=$filename");
header("Content-Length: ".filesize("$path/$filename"));
header("Pragma: no-cache");
header("Expires: 0");
$fp=fopen("$path/$filename","r");
print fread($fp,filesize("$path/$filename"));
fclose($fp);
exit();

I tried to zip the file and use content-type as application/x-zip.
Again, it downloads as a zip file but when I try to open it, I get the
following error message:

WinZip
Cannot open file: it does not appear to be valid archive.
If you downloaded this file, try downloading it again.

Am I missing something?

Also, if I click on the download again, after downloading it already, it
displays garbled text on the screen.

Thanks a lot for your help.

kevinsequeira

try this for the zip file

<?php
$file = $path."/".$filename;
if (strstr($HTTP_USER_AGENT,"MSIE")){ 
	header ( "Content-Disposition: attatchment; filename=$filename");
}else{ 
  header ( "Content-Type: application/x-zip-compressed");
  header ( "Content-Disposition: filename=$filename");
} 
readfile($file);

?>

reg
kevin

NoBullMan

The part of "if" statement is what I have in my script and I tested in IE and it does not work. I am not sure if putting the "if...else" statement would make any difference.

Option

your problem could have been that you spelled attatchment completely wrong.

NoBullMan

I thought that might have been the problem, but fixing it did not help at all.
I used header("Content-type: application/force-download") for the .exe file and header("Content-type: application/x-zip-compressed") for the .zip file as well, but to no avail.

I don't know if ftp'ing the file instead of using http would make any difference (using ftp_get(...)).

I don't know how to use this command and what the processes would be before issuing the ftp_get().

For some reason, I believe it is downloading the file in ascci instead of binary. I used:
$fp=fopen("$path/$filename","rb"); to force binary mode, this didn't work either.

Option

Do download ANYTHING I made this...

Function Download($vFile) {
    $shortname = basename( $vFile );
    if( file_exists( $vFile )          // sanity check
      && !eregi( "p?html?", $vFile ) // security check
      && !eregi( "inc", $vFile )
        && !eregi( "php3?", $vFile ) ){
        $size = filesize($vFile);
        header("Content-Type: application/save");
        header("Content-Length: $size");
        header("Content-Disposition: attachment; filename=$shortname");
        header("Content-Transfer-Encoding: binary");
        $fh = fopen("$vFile", "rb");
        fpassthru($fh);
}

where $vFile is the PATH to the file from the location of your script.
This should download ANY binary file if your lucky... including text files... they are ALL binary in the end.
Hope you get it working.

NoBullMan

It worked😃
Thanks a lot.

Option

I try my best.