Strange behavior after editing the script

Pests

I made a script that allowed you to add a prize to a database(Its for a online game I play). Anyways, after you add the prize it redirects you back to the View Prize page (just lists all the prizes) by a header('Location: ...') call. Well, I found a bug and needed to echo out some info but there was a problem because the page redirected without printing anything out, so I removed the header call and tested the script. When I went to test the new script it would still redirect back to the list. I doublechecked the script and the header was gone, but it keeps on redirecting back. This also happends for 4 other scripts that redirect back to a list. I have no clue why its doing it and how to stop it, any ideas?

kevinsequeira

well it would help if u post the code ...

reg
kevin

Pests

Didn't really want to post the code, but here it is. Error reporting is set to E_ALL, and the header is near the bottom.

<?php
include("includes/common.php");
if(!checkuser())
{
	header("Location: error.php?ec=1");
	exit;
}

$title = "<a style=color:white href=menu.php>Main Menu</a> > Add Prize";
include("header.inc.php");

$count = isset($_POST['count']) ? $_POST['count'] : 1;
$submit = isset($_POST['submit']) ? $_POST['submit'] : false;
$winner = isset($_POST['winner']) ? $_POST['winner'] : array();
$bounty = isset($_POST['bounty']) ? $_POST['bounty'] : array();

$tmpbgcolor = $bgcolor1;

if(!$submit)
{
  	/* The page accessing this page has the choice of adding one prize or multiple
  	 * The following deals with one
  	 */
        if(!$count || $count == 1)
        {
        	?>
                Please fill out the following information to add a Prize to the database:
        	<table border="0" cellspacing="5" cellpadding="5" align="center">
        	<form action="add.php" method="post">
        	<tr>
        	<td>Winner</td>
        	<td><input type="Text" name="winner[]" size="15"></td>
        	</tr>
        	<tr>
        	<td>Bounty</td>
        	<td><input type="text" name="bounty[]" size="15"></td>
        	</tr>
        	<tr>
        	<td>Prox</td>
        	<td><input type="checkbox" name="prox[]"></td>
        	</tr>
        	<tr>
        	<td colspan="2" align="CENTER"><input type="submit" name="submit" value="Add"></td>
        	</tr>
        	</form>
        	</table>
        	<?php
        /* More then one prize */
        } else {
        ?>

            Please fill out the following information to add the Prize(s) to the database:
    	<table border="0" align="center" cellspacing="2" cellpadding="2" width="50%">
    	<form action="add.php" method="post">
    	<tr>
    	<td width="33%" align=center><b>Winner</b></td>
    	<td width="33%" align=center><b>Bounty</b></td>
    	<td width="33%" align=center><b>Prox</b></td>
    	</tr>
    	<?php
            for($i = 0; $i < $count; $i++)
            {
            	?>
    		<tr bgcolor="<?php echo $tmpbgcolor; ?>">
    		<td width="33%" align=center><input size="15" type="text" name="winner[]" value=""></td>
    		<td width="33%" align=center><input size="15" type="text" name="bounty[]" value=""></td>
    		<td width="33%" align=center><input type="checkbox" name="prox[]"></td>
    		</tr>
            	<?php
            	/* $bgcolor1 and $bgcolor2 is include()'d */
    		$tmpbgcolor = ($tmpbgcolor == $bgcolor1) ? $bgcolor2 : $bgcolor1;
            }
            ?>
            <tr>
    	<td colspan="3" align="center"><input type="submit" name="submit" value="Add"></td>
    	</tr>
    	</form>
    	</table>

    	<?php
    }
} else {
	if(empty($winner) || empty($bounty))
	{

	header("Location: error.php?ec=3");
	exit;
}
$db = new MySQL;
$db->connect($host, $user, $pass, $name, 1);
$date = date("Y-m-d");
    for ($x=0; $x<sizeof($winner); $x++)
    {
            if(empty($winner[$x]) || empty($bounty[$x])) continue;
	$tprox = ifOn($prox[$x], 1, 0); /* If $prox[$x] is on, return 1, else, return 0 */
            $db->query("INSERT INTO PrizeDB (`Name`, `Bounty`, `Prox`, `Date`, `Host`, `id`) VALUES ('$winner[$x]', '$bounty[$x]', '$tprox', '$date', '".$userinfo['username']."', '')");
            $hl[] = $db->insertId; /* Adds the ID to the array, used below */
    }
    /*Below is the code I would remove when testing, the problem part */
    /* ----------------- */
    $hl = implode("|", $hl);
    header("Location: view.php?hl=$hl"); /* Sends the $hl array seperated by | to the view page to know which prizes to highlight */
    exit;
    /* ------------------*/
}
include("footer.inc.php");
?>

The ugly column names are not mine, I hate useing them, but this is a Web-Interface for another program. The Forum messed up some of my formatting, sorry about that.

Option

we need to see the function checkuser()

why didnt you want to post your code?

Thanks

Pests

Checkuser just checks the login cookie against the database and returns true or false. That header up there just redirects them to an error page saying there was an auth problem. That should have nothing to do with it.

HalfaBee

Could there be a meta tag redirecting the page?

HalfaBee

Pests

Nope.

Option

i think check user is returning false and this code...

if(!checkuser()) 
{ 
    header("Location: error.php?ec=1"); 
    exit; 
}

... is the bit that is redirecting without printing anything.

Pests

The checkuser function is returning true and all the database things work fine. Even if it did return false, the problem is redirecting to view.php, not error.php.

Option

In that case $submit is true... and $winner or $bounty is empty

check that they both contain something just before that IF statement.

Pests

Checked them, problem still if they are both empty, not empty, or one is empty and the other is not. Dont see a reason why that would affect anything tough.

Pests

bump

Someone please help me with this.

Option

Try using these lines instead of the ones you have already

$winner = isset($_POST['winner']) ? $_POST['winner'] : -1;
$bounty = isset($_POST['bounty']) ? $_POST['bounty'] : -1;

and change...

if ($winner == -1 || $bounty == -1)
{

Pests

I tried it and it still redirects. And also I dont see how that would affect anything.

Edit: Err, wait...I think its fixed. Hold on let me test it some more.

Option

Well.. if it did work... it is usually better to rely on a variable having a value rather than
checking it is empty....

Can you always be sure you have found an empty space?
... or is it better to find the places aren't empty?
by Option

when setting a variable you can be sure that the variable is set... in more complex
programming variables can contain a null string but still be taking up space...
...when also, a variable can be null and taking up 0 space. So is the variable empty or
non-existant?

Let us know how you're doing.

Option