Variables not showing in forms

Radon3k

I have a form in which 3 textfields are displayed and one textarea. It should display the values that I told it to, but instead, it just shows the variable. Here's the code:

<?php
				if($_GET['action'] == "edit" AND $_GET['id'] == $id)
				{
					$edit = mysql_query("SELECT * FROM `news` WHERE `ID` = $id") or die(mysql_error());
					if($posts = mysql_fetch_array($edit))
					{
						$edittitle = $posts['title'];
						$editnews = $posts['news'];
						$editdate = $posts['newsdate'];
						$edittime = $posts['edittime'];
						$edittitle = $_POST['edittitle'];
						$editnews = $_POST['editnews'];
						$editdate = $_POST['editdate'];
						$edittime = $_POST['edittime'];
						?>
						Title: <br />
						<input type="text" name="edittitle" id="edittitle" value="$edittitle" /> <br /> <br />
						Date: <br />
						<input type="text" name="editdate" id="editdate" value="$editdate" /> <br /> <br />
						Time: <br />
						<input type="text" name="edittime" id="edittime" value="$edittime" /> <br /> <br />
						News: <br />
						<textarea name="editnews" id="editnews" rows="10" cols="40">
						</textarea> <br />
						<input type="submit" name="submitnews" id="submitnews" value="Edit" /> <br />

How do I solve this? Thanks. 🙂

cgraz

Looks like you forgot php tags around the variables. Look at the color-coding. Notice how they're all black. . .😃

Cgraz

Radon3k

heh, I forgot about that. Last time I did something like that it was being echo'ed, therefore already inside the PHP tags. Now the problem is, not only will it not show the contents, but I can only click "Edit" for the newest thread (ie, I can click edit for ID #2 and it will at least show the boxes, but if I click on ID #1, then it won't show anything). What should I do to fix this?

cgraz

I'm not sure, but this line looks a little iffy to me

AND $_GET['id'] == $id)

in your if statement. What is that supposed to check? Are you just trying to make sure that your url has the variable id in it? If so, I'd just use

if(($_GET['action'] == "edit") && ($_GET['id']))

Anyways, if that doesn't fix your problem, can you post a link and a better description. It's hard to understand from your last post.

Cgraz

Radon3k

Hi,

Thanks for that bit about the ID. It fixed the displaying the boxes issue. What's the difference between what I had and what you posted? Also, it doesn't show the values yet, here is the link to the site:

[Edit]
There's some weird bug in the code that shouldn't be there. I took that out, but it's still there. Anyway, it just shows empty boxes.
[/Edit]

cgraz

my code checked if there was a value, $GET['id'] in the url. Your code said if $GET['id'] is equal to $id

That doesn't make much sense. $GET['id'] and $id are identical if globals are on. If they're off, they're two seperate variables and most likely won't equal eachother. It would hae worked if you had said if($GET['id'] == '7') or something like that (if you only wanted it to work for that id).

Anyways, so you now have php tags around the variables?

<input type="text" name="edittitle" id="edittitle" value="<?= $edittitle ?>" /> <br /> <br />

And so forth...Then I'd change

if($posts = mysql_fetch_array($edit))

while($posts = mysql_fetch_array($edit))

and make sure to include the closing bracket.

Cgraz

Radon3k

I understnad about the $_GET['id'] stuff now. Thanks! 🙂 I changed the if conditional to a while loop and it remains the same, no values being shown.

cgraz

maybe your query isn't returning any results. Try this

$edit = mysql_query("SELECT * FROM news WHERE ID='".$_GET["id"]."'") or die(mysql_error());

Cgraz

Radon3k

That still doesn't do anything, argh.