[Resolved] function not recognizing variable passed to it

[robstl70]

Hi,

I am having a problem that I have been wrestling with for 2 solid days and it is driving me mad. I need another set of eyes to look at it.

I simply have two functions. One that retrieves data from a database, and one that displays it. A link is clicked that passes a 'catid' in the querystring to another page with the following code.

$links = getLinks($_REQUEST['catid']);
displayLinks($links);

Here is the code for the 2 functions

function getLinks($catid)
{ 
  if(!$catid || $catid=="")
    return false;
  $query = "select * from links where catid='$catid'";
  $result = @mysql_query($query);
  if(!$result)
    return false;
  $num_links = @mysql_num_rows($result);
  if($num_links == 0)
     return false;
  $result = db_result_to_array($result);
  return $result;
}

and

function displayLinks($links)
{
  if(!is_array($links))
  {
    echo '<br>No links currently available in this category<br>';
  }
  else
  {
    foreach($links as $row)
    {
      $url = 'show_links.php?linkid=' .($row['linkid']). ' target=content';
      $title = $row["catname"];
      do_html_url($url, $title);
    }
  }
}

For whatever reason, I always get 'No links currently available in this category' when this is not the case. From what I can deduct, getLinks does not recognize 'catid'. You can clearly see the catid passed in the address bar and I can echo it out on the page.

I use two almost identical functions to display the different categories of links (the links that pass the catid) and it works fine. The difference is that getLinks accepts the catid parameter.

There is definitely not a problem with the query or the data either.

I'd appreciate any input 🙂

[HalfaBee]

$links is not an array.

what is this function $result = db_result_to_array($result);

Halfabee

[robstl70]

Hi,

that function is

// CONVERTS A RESULT IDENTIFIER INTO AN ARRAY OF RESULTS
function db_result_to_array($result)
{
   $res_array = array();
   for($count=0; $row = @mysql_fetch_array($result); $count++)
   {
     $res_array[$count] = $row;
   }
   return $res_array;
}

there are several links with the same id so it should return an array.

Thanks

[laserlight]

This might be simpler:

// CONVERTS A RESULT IDENTIFIER INTO AN ARRAY OF RESULTS
function db_result_to_array($result)
{
	$res_array = array();
	while ($res_array[] = mysql_fetch_assoc($result));
	return $res_array;
}

still, I doubt if that is the problem.
I suggest removing the '@' operators for now, echo $_REQUEST['catid'] and see.

[HalfaBee]

Also do a var_dump() or print_r() of $links before the test.

HalfaBee

[robstl70]

Thanks everyone,

I've done a var_dump and I get nothing. Is there anything I can eliminate as the problem? Even when I pass a specific number to 'getLinks' (as catid) it won't recognize it. I've been coding for years and I don't remember being this stumped.

Reid

[laserlight]

try:

function getLinks($catid)
{ 
	if (empty($cat_id))
		die("Cat ID is empty!");
	$query = "select * from links where catid='$catid'";
	$result = mysql_query($query)
		OR die("Couldnt execute query!");
	$num_links = mysql_num_rows($result);
	if($num_links == 0)
		die("No links!");
	$result = db_result_to_array($result);
	return $result;
}

[robstl70]

Hi,
I've done that...catid is empty. It doesn't exist as far as the function goes.

[laserlight]

err, did you change $cat_id to $catid in empty()?
That's a typo error of mine.

[robstl70]

I did.

[laserlight]

ok, so you try:

$links = getLinks(2);

and you get that error?
I have my doubts.

On the other hand, if you tried $links = getLinks($REQUEST['catid']);
and get the error, then it implies that there is no $REQUEST['catid'] being passed.

If you are indeed passing it, say by query string, then check your version of PHP.

[robstl70]

Thats what is making me nuts...I've passed a number directly to it just like you show and I get nothing. I'm using version 4.2

[HalfaBee]

How about uploading a txt version.
There has to be something wrong.

Are you using a MAC?

HalfaBee

[robstl70]

where do I upload them to? I can send you the two php files and the one .sql file

[laserlight]

you can upload them to this forum.

they must be uploaded as text files though

[robstl70]

where?

[HalfaBee]

In the attach file box at the bottom of the reply box.

[robstl70]

It is 3 seperate files

[HalfaBee]

Either post 3 times or zip it and post once

[robstl70]

I am on the other side of the globe, I must go to sleep, but I thank you for your time and will contact you again for help.

Thank you