Help! Not getting required pages upon click

Dev

I Have a problem with this sscript...when I click on the buttons...I don;t go to the required page...I end up with the same page. Eg: when I click "Sign up now!"..I should go to the form...instead..I end up with the same page...HELP!!!! I put the whole page FYI...

dalecosp

Well, first, let me thank you for attaching the code instead of quoting it, and also for truncating the list of nations. When you say, "I put the whole page FYI," do you mean that all the scripts were combined into this document?

Second, if I may make a suggestion, take a look at
Tim Perdue's (---site author's!) excellent article on best practices/coding style. Clean code is easier for humans to understand, and therefore easier to a] teach with (by example, perhaps) and b] debug, which is what you're asking us to do.

I see one thing that may have bearing on this situation. In the HTML output by your echo() statements, you've assigned the values for the "stage" submit buttons like this:

echo "<input type=\"submit\" name=\"stage\" value=\"2\">";

But, then when you test the value, you use:

if ($stage==2) {
   // whatever here
}

Now, one's a string, the other an integer. Likely PHP doesn't care much, but it's something to check. Some languages aren't so forgiving. And, it could be that some mistake like that is the problem....

Also, you missed escaping the quotes in your HTML, down where it says "this is
an image file and not a web page..."

I believe that it's "isset()", not "IsSet()" ... that might be important...

Where are the submits? Is this just a file that's included on some other
page?

Another thing, is register_globals ON or OFF on your server? :eek:

Finally, let me say 'thanks' for the debug joke, I was ROFL...hopefully you won't be banned from the forum 😃

Sorry if I'm not much help .... 🙁

Dev

Any alternatives on testing the values?? It is also my suspicion that the error is there...

$button="
<FORM action=\"join.php\" method=\"POST\" name=\"join1\">
<INPUT TYPE=\"HIDDEN\" name=\"stage\" value=\"1\">
<center><INPUT TYPE=\"SUBMIT\" name=\"submitit\" value=\"I agree!!\" >
</FORM>

" ;

elseif ($stage==1)
{
$main=$toptext.$form1 ;

}

Any suggestions other than the above?

Dev

Any alternatives on testing the values?? It is also my suspicion that the error is there...

$button="
<FORM action=\"join.php\" method=\"POST\" name=\"join1\">
<INPUT TYPE=\"HIDDEN\" name=\"stage\" value=\"1\">
<center><INPUT TYPE=\"SUBMIT\" name=\"submitit\" value=\"I agree!!\" >
</FORM>

" ;

elseif ($stage==1)
{
$main=$toptext.$form1 ;

}

Any suggestions other than the above?

dalecosp

You didn't answer a couple of my return questions. If reg_globals=0, which it does now by default, then you can't say

$stage=$something

and then reload the page and test

(if $stage==$somethingelse;

you must test

(if $_POST['stage']==$something)

I'm not trying to be mean, but it's a typical error....

Dev

register_global is OFF on the Server.

dalecosp

Originally posted by Dev
register_global is OFF on the Server.

OK, so you've changed the code to reflect this situation?

Dev

Thanks for the assistance so far...I am not a PHP expert...I am merely modifying a script written by someone else so please don't lose patience with me. This script works on othher servers...so it may very well be the register_global=0 that is used on my server that is the problem.

This is what I did (without luck)....
I left this the same way:

if(!IsSet($Stage))
{
//include("mysql.php")       ;
//$query="SELECT text FROM pagetext WHERE ID=2 "   ;
//$result=mysql_query($query)  ;
//$termsarray=mysql_fetch_array($result) ;
//$terms=$termsarray[0]    ;

$button="
<FORM  action=\"join.php\" method=\"POST\" name=\"join1\">
<INPUT TYPE=\"HIDDEN\"  name=\"stage\" value=\"1\">
<center><INPUT TYPE=\"SUBMIT\"  name=\"submitit\" value=\"I agree!!\" >
</FORM>

and tested:

elseif ($_POST['stage']==1)
{
$main=$toptext.$form1     ;
}

i got the same page upon reload...again

...when I placed the brackets the way you did...(elseif $POST['stage']==1) i got an error which suggested that the brackets couldn't be placed before elseif....I also got an error when I used $1 instead of 1...elseif($POST['stage']==$1)

dalecosp

OUCH! Did I really code THAT? yes, unfortunately.... Too many light nights. If I drank, that'd be a good excuse 😃

In that last instance, what you need is

elseif ($_POST['stage']==1) {
   // stuff here;
   }

Patiently yours, 😉

DeltaRho2K

Just an FYI, the register globals value in the php.ini file should either be OFF or ON, rather than 0 or 1.

dalecosp

Correct, of course. I notice that in 5 references to this directive, the words ON or OFF were used in a majority of references. 🆒

I hardly think that one should mistake a casual discussion of server status with instructions on modifying the php.ini file. But, then, some people say I just 'hardly think' .... 😃

Nice av grafix, BTW...

Dev

Originally posted by dalecosp
OUCH! Did I really code THAT? yes, unfortunately.... Too many light nights. If I drank, that'd be a good excuse 😃

In that last instance, what you need is
elseif ($_POST['stage']==1) {
   // stuff here;
   }
Patiently yours, 😉 [/B]

Thats exactly what I did (without any luck)...it just didn't go to the form but reloaded and showed the same page 🙁

and....I notice I've been part of the Register_global=0 thing...thanks to someone who is patiently helping me... 😃

Dev

You know....i never did solve this problem...any more suggestions?

DeltaRho2K

Change:

elseif ($_POST['stage']==1) { 
   // stuff here; 
   }

to:

elseif ($_POST['stage']=='1') { 
   // stuff here; 
   }