PHP_SELF variable

phpdesp

Hi,

I'm trying to use this script:

http://www.dmxzone.com/showDetail.asp?TypeId=2&NewsId=4114

(check the final add.php)

but I get this:

You don't have permission to access / Notice: Undefined variable: PHP_SELF in c:/www/add.php on line 30 on this server.

It seems the PHP_SELF variable is undefined? But author says in the text:

You may have noticed the variable $PHP_SELF, all this does is tell the form that when you hit submit, it will reload the page with the current information.

laserlight

sounds like a problem with register_globals

use $_SERVER['PHP_SELF']

"all this does is tell the form that when you hit submit, it will reload the page with the current information"
that is a little inaccurate.
PHP_SELF will print out the path to the current page so that your form can submit to the current page.

phpdesp

Thanks.. that solved it.

I seem to have an issue with this code, it's just a syntax thing but I can't solve the problem:

<html>
<head>
<title>View News</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head> 
<body>
$link = @mysql_connect(localhost, username, password);
if(!$link){
   echo('Error connecting to the database: ' . $mysql_error());
   exit();
}
$db = @mysql_selectdb('mydatabase');
if(!$db){
   echo('Error selecting database: ' . $mysql_error());
   exit();
}
$query = "SELECT id, headline, timestamp FROM news ORDER BY timestamp DESC";
$result = @mysql_query($query);
if(!$result){
   echo('Error selecting news: ' . $mysql_error());
   exit();
}
if (mysql_num_rows($result) > 0){
    while($row = mysql_fetch_object($result))
    {
    ?>
   <font size="-1"><b><? echo $row->headling; ?></b> <i><? echo formatDate($row->timestamp); ?></i></font>
    <?
}else{  <-- this is line 29
   ?>
   <font size="-2">No news in the database</font>
<? }
   mysql_close($link); ?>
</body>
</html>

Parse error: parse error, unexpected '}' in c:\www\view.php on line 29

laserlight

This might be what you want:

<html>
<head>
<title>View News</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$link = @mysql_connect(localhost, username, password)
	OR exit('Error connecting to the database: ' . mysql_error());
$db = @mysql_selectdb('mydatabase')
	OR exit('Error selecting database: ' . mysql_error());
$query = "SELECT id, headline, timestamp FROM news ORDER BY timestamp DESC";
$result = @mysql_query($query)
	OR exit('Error selecting news: ' . mysql_error());
if (mysql_num_rows($result) > 0) {
	while ($row = mysql_fetch_object($result))
	{
?>
<font size="-1"><b><?php echo $row->headling; ?></b> <i><?php echo formatDate($row->timestamp); ?></i></font>
<?php
	}
} else {
?>
<font size="-2">No news in the database</font>
<?php
}
mysql_close($link);
?>
</body>
</html>

There's a missing "<?php" where your PHP code starts, while $mysql_error() is most probably mysql_error(), unless you happen to have a variable $mysql_error whose value is the name of a defined function.

As for your parse error, it is due to the code block for the "if" not being closed before you start the code block for the corresponding "else".
The closing brace that you saw is actually the one that closes the while loop within the "if" block.

phpdesp

Thanks yet again. It wasn't actually my code, I took it from that site which is supposed to "teach" people php, but seems the guy doesn't even double check and test his code. 😕