Insert Help

Sharif

I've been out of PHP coding for a while now (2 months) and I've almost forgot lots of stuff... basic things like inserting into a MySQL table, here's the code:

//Required User Variables
$authorid = "1";

if (isset($_POST['title']) && isset($_POST['teaser']) && isset($_POST['news']))
{
if ($_POST['submit']=='Insert')
{
	foreach ($_POST as $key=>$value) 
	{ 
		$_POST[$key] = htmlspecialchars(addslashes(trim($value)));
	}
}
$action = "INSERT INTO news SET timestamp = adddate(now(),interval 1 hour), title = '$title', teaser = '$teaser', $authorid = '$authorid', news = '$news'";
$query = mysql_query($action,$connection) or die (mysql_error());
echo "<center>\n";
echo "Article successfully inserted!<br>\n";
echo '<a href="' . $PHP_SELF . '"><b>Insert Another Article</b></a>';
echo "</center>\n";
}
elseif (!isset($_POST['title']) && !isset($_POST['teaser']) && !isset($_POST['news']))
{
echo "<form action=\"$PHP_SELF\" method=\"post\" name=\"insert_news\">";
echo "Title: 
	  <input name=\"title\" type=\"text\" id=\"title\" size=\"50\">
      <br>
      Teaser: 
      <br>
      <textarea name=\"textarea\" cols=\"50\"></textarea>
      <br>
      News: 
	  <br>
      <textarea name=\"news\" cols=\"100\" rows=\"25\" id=\"news\"></textarea>
	  <br>";
echo "<input name=\"Insert\" type=\"submit\" value=\"Insert\">";
echo "</form>";
}
?>

What the heck is wrong with it? All this does is display a form to insert articles into a database. It wont do that...

YappyDog

Your insert statement is in the wrong format. It should be something like:

Insert into myTable (myCol1, myCol2) values ('value 1', 'value 2')

Sharif

even with that I have no luck...What's going on?

YappyDog

What does your query look like now?

Sharif

INSERT INTO news (timestamp, title , teaser , authorid , news) VALUES (adddate(now(),interval 1 hour, $title, $teaser, $authorid, $news)

YappyDog

Well, I've never used the adddate function, but it looks like you are missing an ending parenthesis.

prismstone

The INSERT statement has two different forms. One uses the VALUES keyword and one uses the SET keyword as used in the original post. I have used both ways and never had a problem.

I have not used the adddate and now() functions yet. It does seem however from the manual on the following URL:

http://www.phpfreaks.com/mysqlmanual/page/manual_Reference.html#IDX1260

that you used the adddate and now() functions correctly. I do not see any missing parenthesis in your code. Please anybody correct me if I am wrong as I have never used these functions yet.

In this URL it states that adddate is new for MySQL Version 3.22.
What version of MySQL are you using? ADDDATE() is a synonym for DATE_ADD(). If you are using an older version of MySQL that does not support the ADDDATE function you can try DATE_ADD().

Also tell us what the exact error message is. Isolate the error by
trying a simple SQL INSERT statement from the SQL prompt. Have the INSERT statement set the content of only one field. First try one simple field, then try setting only the adddate field using a hardcoded date without the now() function, etc. adding complexity as you go. When you get the first error message, send us the only code snippet that is giving you the first error message without all the other complexities. Also send us the code snippet that worked immediately previous to where you introduced the bug. In order to do this you will need to save different versions of the code for each change that you add. Give each version a name such as xxxTestAdddate.php - If you do not do this you will lose the last working version of your code and will nothing to compare your non working code to!

Send us the exact error message, the description of your database (type the following from your MySQL prompt: describe databaseName (Please substitute the actual databaseName that you are using i.e. describe customers.), the two code snippets that I discussed above and the version number of the MySQL that you are using with the exact error message to us.
It will be much easier for us to resolve your problem. If this message solves the problem for please be so kind as to tell us for our own knowledge.

Thank You

prismstone

My previous post wraps around and
is hard to read. I have no time to play
with it anymore. I would suggest to cut
and paste it into something like Microft Word.
I tried it and it works. Sorry, I will try not to
go so far to the right margin next time. If
anybody has any better ideas please let me
know.

Thank You

YappyDog

The missing parenthesis is in the insert statement after the "hour". Otherwise it is unbalanced. In looking at it closer, it probably also needs some quotes around some of the values.

This:
INSERT INTO news (timestamp, title , teaser , authorid , news) VALUES (adddate(now(),interval 1 hour, $title, $teaser, $authorid, $news)

Should be:
INSERT INTO news (timestamp, title , teaser , authorid , news) VALUES (adddate(now(),interval 1 hour), '$title', '$teaser', $authorid, '$news')

prismstone

Sorry, I stand corrected by Yappydog.
There is indeed a missing parenthesis
in the adddate function.
I am hoping to hear from Sharif if his
problem has been resolved.
I would like some feedback please on
using the Insert statement with the
VALUE clause as opposed to the SET clause.
I wrote that they both work.

Thank You