Last Cry for help (Detailed)

FoxhoundX

Okay, I have been trying to get this working for quite some time, and I'm not sure why it doesn't. I have talked to numerous people on MSN, and they are not sure either, so I will include lots of details in here.

I have a script which I want to update two certain fields, where the user/pass match. I have the following code -

$user = $_POST['user']; 
$pass = $_POST['pass'];
$pass = md5($pass); 
$conn = mysql_connect("localhost","FirebirdX","pass");  

mysql_select_db("memoryx",$conn); 
$query = "Update members set POINTS='POINTS+1000', CHALLENGES='CHALLENGES+1' where USERNAME='$user' and PASSWORD='$pass'"; 
mysql_query($query);

There is a screenshot of the memoryx db here -
http://68.145.31.16/screenshot.gif

Please help, offer suggestions, whatever.

Thanks

FoxhoundX

Btw, those few accounts have the 1000 pts/1 challenges because I removed the WHERE clause, so it updated them ALL

DeltaRho2K

I know this is getting nit picky, but my php server (for whatever reason) is case sensitive when it comes to identifying fields in the DB, so let's change that first.

Next, in the mySQL manual, you don't want to put the single quotes around the equations... Try these couple of changes, and let me know how that goes...

$user = $_POST['user'];  

$pass = $_POST['pass']; 
$pass = md5($pass);  

$conn = mysql_connect("localhost","FirebirdX","pass");   

mysql_select_db("memoryx",$conn);  

$query = "UPDATE members SET points=points+1000, challenges=challenges+1 where username='$user' and password='$pass'";  

mysql_query($query);

FoxhoundX

Thank you!

Been trying to get it working for like 3 days now!

🙂

stolzyboy

but it's not so much your php that is picky, but mysql requires that field names be lowercase, usually people only CAPITALIZE things like SELECT, INSERT INTO, WHERE, LIMIT, etc... the mysql clauses

DeltaRho2K

Thanks for the clarification stolzyboy... I knew there was something whacky going on there, so I have just developd the habit of capitalizing the clauses like you said, and following the case patterns on everything else.

I have also developed the habit of remaining consistent with my case, so I don't have to think much...

For instance, my unique index on my tables are always consistent.

Say, I have a table called 'Colors', then my unique ID field is 'ColorsID'.

I have just found that my coding goes much smoother when I am consistent with the little things. (Just some food for thought for anyone who cares.)

stolzyboy

Organization:

This is probably the first thing you want to do when you start a
project. If you are knewer to db and programming, write it down,
draw pics of how you think it should be. Ask some friends (that
know what you are doing) to criticize your structure and flow of
your project. Once you have that, keep your db's, tables, fields,
variables, functions, classes, etc... named something that make
sense, as you did, that way when you are looking to select the id
from Colors, you don't have to wonder if it is id, ID, etc.... you
just know that since it is in Colors, you have ColorsID. A lot of
folks have a problem getting around with var names and such,
then in the end when they have to change something, they beat
themselves to death cuz they have a function named, let's say,
cleaner, and they don't really know what that is for, but it cleans
the input from forms and such. You should have named it
clean_input or something that gives you a clue what it meant,
etc...

etc...

Organization creates fluid flow which creates fluid programs which create a fluid product for your end user.

my 3 cents // gave a little more this time