[Resolved] code only updated most records - odd

[drewbie]

hey guys, i dont understand why my code updated most of the records. all its doing is taking out the <br /> 's. the counter is saying there's more, which there definately is, but why would str_replace not delete the rest of the <br /> 's? im stumped... thanks guys!

<?
include "common_db.inc";
$link_id = db_connect($default_dbname);
$query = mysql_query("SELECT CCID, comment FROM comments_calls2 WHERE comment LIKE '%<br />%'", $link_id);
$counter = 1;
while ($result = mysql_fetch_array($query))
{
   echo $counter;
   $comment = str_replace('<br />', '', $result[comment]);
   $query2 = mysql_query("UPDATE comments_calls2 SET comment='$comment' WHERE CCID='$result[CCID]'", $link_id);
   $counter++;
}
?>

[planetsim]

You are counting the records not the records which only have <br>'s in them.

[drewbie]

every record returned from the query has at least one <br /> in it when using LIKE '%<br />' in the query:

$query = mysql_query("SELECT CCID, comment FROM comments_calls2 WHERE comment LIKE '%<br />%'", $link_id);

[batman]

Use a foreach() loop.

 <? 
include "common_db.inc"; 
$link_id = db_connect($default_dbname); 
$query = mysql_query("SELECT CCID, comment FROM comments_calls2 WHERE comment LIKE '%<br />%'", $link_id); 
$counter = 1; 
$result = mysql_fetch_array($query);
foreach($result as $a)
{
$b = $a['comment'];
$c = $a['CCID'];
   echo $counter; 
   $comment = str_replace('<br />', '', $b); 
   $query2 = mysql_query("UPDATE comments_calls2 SET comment='$comment' WHERE CCID='$c'", $link_id); 
   $counter++; 
} 
?>

See if that works,

[drewbie]

how odd, it's only returning 4 records now when my code was returning 96 records. i know for a fact that there are 96 records with <br /> 's. i think this and my other problem might be a server problem because cpanel is also acting very strange. any other suggestions? thanks!

[drewbie]

oh and it still isn't updating the records 😕

[sdjensen]

Don't use a foreach loop. Your first posting was ok, but remember the search is only searching for <br /> and not <br> or <br/>.
Could that be the problem?

[drewbie]

nope, they are definately <br /> 's. i just don't get why it would update MOST of the records. there are 96 records still left with <br /> 's, my first code counts them just fine, but it just doesn't want to update them. would mysql be locking these records somehow???

[sdjensen]

is the CCID a number or a textfield in the db?

If it is a number then the update statement should be

$query2 = mysql_query("UPDATE comments_calls2 SET comment='$comment' WHERE CCID=$result[CCID]", $link_id);

[drewbie]

nope, CCID is a combination of letters and numbers, i tried it without the single quotes anyways with no luck 🙁

[drewbie]

somehow unslashed single quotes got into my db with magic_quotes_gpc on, bah, im investigating, thanks for all the help!