[Resolved] query not executing?

[drewbie]

hey guys, my code copies a record to a history table and then select all the comments for that record and copies them to a history table. now for some odd reason, SOMETIMES the comments arent copied to their history table, and even stranger, when they arent copied, they also arent deleted. call me crazy, i dunno. also, how can i make this code fail-safe or a better way to do it? thanks!

$del_query = mysql_query("SELECT * FROM current_calls WHERE CID='$CID'", $link_id);
                $num_rows = mysql_num_rows($del_query);
                $del_result = mysql_fetch_row($del_query);
                if ($num_rows == 1)
                {
                        $copy_query = mysql_query("INSERT INTO call_his VALUES('$del_result[0]','$del_result[1]','$del_result[2]','$del_result[3]','$del_result[4]','$del_result[5]','$del_result[6]','$del_result[7]','$SID1', NOW() + 0)", $link_id);
                        $del_query2 = mysql_query("DELETE FROM current_calls WHERE CID='$CID'", $link_id);
                        $com_query = mysql_query("SELECT * FROM comments_calls WHERE CID='$CID'", $link_id);
                        while ($com_result = mysql_fetch_row($com_query))
                        {
                                $copy_query2 = mysql_query("INSERT INTO comments_calls2 VALUES('$com_result[0]','$com_result[1]','$com_result[2]','$com_result[3]','$com_result[4]','$com_result[5]','$com_result[6]','$com_result[7]','$com_result[8]')", $link_id) OR die(mysql_error());
                        }
                        $del_query3 = mysql_query("DELETE FROM comments_calls WHERE CID='$CID'", $link_id);
                        echo "Record deleted.<br>";
                }
                else
                {
                        echo "Record not found.<br>";
                }

[planetsim]

At the end of the query.. at this

or die(mysql_error());

[drewbie]

ok, thanks, but that doesn't explain why the comments would only be copied/then deleted sometimes...hmmm

[batman]

First of all, I believe that you can take out that while loop. Second in your insert querys, I see the values, but your not giving it fields to go into. Your query should look something like this:

$sql = mysql_query("INSERT INTO table (var1, var2, var3, var4, var5) VALUES ('$var1','$var2','$var3','$var4','$var5')");

[planetsim]

You dont need the feilds to go with the values its not required, as long as you make sure the values are in the correct order.

[drewbie]

the while loop is needed to iterate through the comments, it is definately needed. and as i said before, the comments are only copied SOMETIMES. this is so wierd. why would it not copy the comments sometimes? and as i said before, when they arent copied, they also arent deleted. i dont get it...😕

[sdjensen]

Three things
1) if there are more then one record returned from $del_query you will not copy these records because of your "if ($num_rows == 1) "
2) if CID is a number then you don't need the '' around the $CID

finally
use "or die(mysql_error());" this will tell you if any errors occured in the statement.

[drewbie]

$del_query will return at most, 1 record, $CID is a unique value. and yes, like my other thread, $CID is a combination of letters and numbers, thanks for that bit of knowledge though 😉 and im gonna see if i get any errors from mysql, thanks!

[drewbie]

somehow unslashed single quotes got into my db with magic_quotes_gpc on, bah, im investigating, thanks for all the help!