[Resolved] Trying to set up an edit news system

Kraft

Alright, this is my first bit of php work I've ever done and here is what I have so far:

A news database is set up
You can add to the database
You can view the database

Now I am trying to get an editing system up. I'm trying not to tie these all into one file, as I am going to have different levels of editing for different users, but right now I just want to get the dang thing working. Here is what I have so far

edit.php

 <html>
<head><title> Saving News </title></head>
<body bgcolor="#FFFFFF">

<?

// get newsid from link

$i = $_GET['newsid'];


/* declare some relevant variables */
$DBhost = "localhost";
$DBuser = "*******";
$DBpass = "*******";
$DBName = "pspnetw_pspdata";
$table = "psp_news";

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable toconnect to database");
@mysql_select_db("$DBName") or die("Unable to select database $DBName");

$sqlquery = "SELECT * FROM psp_news";
$result = mysql_query($sqlquery);

$newsid = mysql_result($result,$i,"newsid");
$newstitle = mysql_result($result,$i,"newstitle");
$summary = mysql_result($result,$i,"summary");
$fullarticle = mysql_result($result,$i,"fullarticle");

Print "<FORM METHOD=POST ACTION='editsubmit.php3'>
<TABLE>
<TR><TD>
<INPUT TYPE='text' NAME='newstitle' VALUE='$newstitle'><br><br>
<TEXTAREA NAME='summary' ROWS=8 COLS=100>$summary</text><br>
<TEXTAREA NAME='fullarticle' ROWS=14 COLS=100>$fullarticle</text><br>

<p><INPUT TYPE='submit' value='Submit News'></td></tr>
</TABLE></FORM></body></html>"; 


?>

And editsubmit.php3

<html>
<head><title> Saving News </title></head>
<body bgcolor="#FFFFFF">

<?
/* declare some relevant variables */
$DBhost = "localhost";
$DBuser = "*******";
$DBpass = "*******";
$DBName = "pspnetw_pspdata";
$table = "psp_news";

$summary=$_POST['summary'];
$newstitle=$_POST['newstitle'];
$fullarticle=$_POST['fullarticle'];
$newsid=$_POST['newsid'];

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable toconnect to database");
@mysql_select_db("$DBName") or die("Unable to select database $DBName");

$sql = "UPDATE psp_news SET newstitle='$newstitle', summary='$summary',fullarticle='$fullarticle' WHERE newsid='$newsid'";

  $result = mysql_query($sql);


mysql_close();

print "<HTML><TITLE> PHP and MySQL </TITLE><BODY
BGCOLOR=\"#FFFFFF\"><center><table border=\"0\"
width=\"500\"><tr><td>";
print "<p>news updated!</td></tr></table>
</center></BODY></HTML>";


?>

Any suggestions as to what I am doing wrong? Right now it will pull up the article for editing, and let me hit submit... then it says news updated! and looks like it is working alright... but it doesn't actually update it.

n00854180t

Try this maybe (I'm not that great at this):
Instead of this:

$sql = "UPDATE psp_news SET newstitle='$newstitle', summary='$summary',fullarticle='$fullarticle' WHERE newsid='$newsid'"; 

  $result = mysql_query($sql); 


mysql_close(); 

print "<HTML><TITLE> PHP and MySQL </TITLE><BODY 
BGCOLOR=\"#FFFFFF\"><center><table border=\"0\" 
width=\"500\"><tr><td>"; 
print "<p>news updated!</td></tr></table> 
</center></BODY></HTML>";

Try this:


if($_POST["$submit"] {
$sql = "UPDATE psp_news SET newstitle='$newstitle', summary='$summary',fullarticle='$fullarticle' WHERE newsid='$newsid'"; 
$result = mysql_query($sql); 

print "<HTML><TITLE> PHP and MySQL </TITLE><BODY 
BGCOLOR=\"#FFFFFF\"><center><table border=\"0\" 
width=\"500\"><tr><td>"; 
print "<p>news updated!</td></tr></table> 
</center></BODY></HTML>"; 


} else {

Print "<FORM METHOD=POST ACTION="<?php $PHP_SELF ?>"> 
<TABLE> 
<TR><TD> 
<INPUT TYPE='text' NAME='newstitle' VALUE='$newstitle'><br><br> 
<TEXTAREA NAME='summary' ROWS=8 COLS=100>$summary</text><br> 
<TEXTAREA NAME='fullarticle' ROWS=14 COLS=100>$fullarticle</text><br> 

<p><INPUT TYPE='submit' value='Submit News'></td></tr> 
</TABLE></FORM></body></html>";  

}
mysql_close();

I am by no means an expert, so if it doesn't work, my apologies.

Kraft

Argh... I understand what the code you wrote is doing in concept... but it is generating the following error now

Parse error: parse error, unexpected ';' in /home/pspnetw/public_html/_staff/sources/editsubmit.php3 on line 14

Which is killing me because line 14 is just the sql UPDATE call, which doesn't have any extra ;'s...

n00854180t

Maybe make it into one script and just make an include that handles your user levels (also I suggest putting your db connection in a separate file and just including it, it's much easier that way):

 <html> 
<head><title> Saving News </title></head> 
<body bgcolor="#FFFFFF"> 

<? 

// get newsid from link 

$i = $_GET['newsid']; 


/* declare some relevant variables */ 
$DBhost = "localhost"; 
$DBuser = "*******"; 
$DBpass = "*******"; 
$DBName = "pspnetw_pspdata"; 
$table = "psp_news"; 

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable toconnect to database"); 
@mysql_select_db("$DBName") or die("Unable to select database $DBName"); 

$sqlquery = "SELECT * FROM psp_news"; 
$result = mysql_query($sqlquery); 

$newsid = mysql_result($result,$i,"newsid"); 
$newstitle = mysql_result($result,$i,"newstitle"); 
$summary = mysql_result($result,$i,"summary"); 
$fullarticle = mysql_result($result,$i,"fullarticle"); 

if($_POST["submit"] {
$sql = "UPDATE psp_news SET newstitle='$newstitle', summary='$summary',fullarticle='$fullarticle' WHERE newsid='$newsid'";
$result = mysql_query($sql); 
echo "News entered!";

} else {



?>  



<FORM METHOD=POST ACTION='<?php $PHP_SELF ?>'> 
<TABLE> 
<TR><TD> 
<INPUT TYPE='text' NAME='newstitle' VALUE='<?=$newstitle?>'><br><br> 
<TEXTAREA NAME='summary' ROWS=8 COLS=100><?=$summary?></text><br> 
<TEXTAREA NAME='fullarticle' ROWS=14 COLS=100><?=$fullarticle?></text><br> 

<p><INPUT TYPE='submit' name='submit' value='Submit News'></td></tr> 
</TABLE></FORM></body></html> 

<?php
}
?>

Kraft

Ugh... I'm still getting that same error on the same line. What sucks is the syntax looks right and I have no idea why it is generating a parse error...

Oh, and thanks for the tip on the database connection. I will probably made a couple different header files and function files after I get the framework of this stuff accomplished.

n00854180t

Try putting the sql query on several lines and echoing to the browser:

<html> 
<head><title> Saving News </title></head> 
<body bgcolor="#FFFFFF"> 

<?  

// get newsid from link 

$i = $_GET['newsid'];  


/* declare some relevant variables */  

$DBhost = "localhost";  

$DBuser = "*******";  

$DBpass = "*******";  

$DBName = "pspnetw_pspdata";  

$table = "psp_news";  

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable toconnect to database");  

@mysql_select_db("$DBName") or die("Unable to select database $DBName");  

$sqlquery = "SELECT * FROM psp_news";  

$result = mysql_query($sqlquery);  

$newsid = mysql_result($result,$i,"newsid");  

$newstitle = mysql_result($result,$i,"newstitle");  

$summary = mysql_result($result,$i,"summary");  

$fullarticle = mysql_result($result,$i,"fullarticle");  

if($_POST["submit"]) { 
$sql = "UPDATE psp_news 
SET newstitle='$newstitle', summary='$summary',
fullarticle='$fullarticle' WHERE 
newsid='$newsid'"; 
$result = mysql_query($sql);  

$echo $sql;
echo "News entered!"; 

} else { 



?>   



<FORM METHOD=POST ACTION='<?php $PHP_SELF ?>'> 
<TABLE> 
<TR><TD> 
<INPUT TYPE='text' NAME='newstitle' VALUE='<?=$newstitle?>'><br><br> 
<TEXTAREA NAME='summary' ROWS=8 COLS=100><?=$summary?></text><br> 
<TEXTAREA NAME='fullarticle' ROWS=14 COLS=100><?=$fullarticle?></text><br> 

<p><INPUT TYPE='submit' name='submit' value='Submit News'></td></tr> 
</TABLE></FORM></body></html> 

<?php 
} 
?>

n00854180t

Also just another tip. Put all your html formatting in a css file so you can just link to it and you won't have to keep formatting.

Kraft

good call on the css. I am integrating this into an invisionboard so chances are I will just link to the css file out of there. But back to the PHP thing, I am back to step one.

I found what was giving the errors: in the code you posted, the if statement was opened ( but never closed ). Just just went straight to the {. Also you don't need a variable declaration $ before echo in the echo $sql; statement.

Of course now that I have those two things fixed... the new code of doom still isn't operating right. I am back to it saying it is updated, then the database laughing at me.

Sorry I am such a pain with this, and I do appreciate all your help n008. Luckily though once I learn what I am doing wrong I won't forget how to fix it.

n00854180t

So it's just not putting anything in the DB? Hehe I went as far as to try and write any HTML I used in XHTML just to make it that much faster but I guess it's not that widely accepted yet LOL..

NP for the help, I am just trying to wrap my brain around as much PHP as possible lately so I can get back into programming and try to get myself a better job.

Oh I know why it isn't inputting it into the db I think.

Try changing

$sqlquery = "SELECT * FROM psp_news";   

$result = mysql_query($sqlquery);

to this:

$sql = "SELECT * FROM psp_news";   

$result = mysql_query($sql);

The variable $sql will only equal the update query when you hit the submit button now.

n00854180t

My edited post is now correct with the ) on the if statement.

Kraft

I'm about to give that a try. The only other thing I can think of is that I botched the logic when I was writing the store to database tag. What I have it do is on one page it generates a list of all the news titles and has a dynamically generated hyperlink to this page. This edit page then loads up, and reads the newsid (my auto_increment key) and saves it to $i. Should I have it query the update data to "where newsid='$i'" ?

n00854180t

Yeah go ahead and give that a try.

Kraft

Still nothing... but I just had a thought...

Is it me or are the variables just not updating when the submit button is triggered? The file reads the original variables from the database, sets up the page, and when submit is hit.... it auto submits the stored variables. Won't these be the same variables I loaded from the database originally?

It seems like I should have something that looks like this instead:

if($_POST["submit"]) {  

//Assign contents of form to variables
$newstitle = $_POST['newstitle'];
$summary = $_POST['summary'];
$fullarticle = $_POST['fullarticle'];

$sql = "UPDATE psp_news  

SET newstitle='$newstitle', summary='$summary', 
fullarticle='$fullarticle' WHERE  

newsid='$newsid'";  

$result = mysql_query($sql);   

$echo $sql; 
echo "News entered!";  

}

Am I totally wrong on this or is this correct?

n00854180t

You could also just do it like this:

instead of

 $sql = " ... WHERE newsid='$i'";

you could do this:

 $sql = " ... WHERE newsid='" . $_GET["newsid"] . "'";

And take out $i = $_GET["newsid"];

n00854180t

LOL! I hadn't even noticed that. I think that is probably what happened. It looks like you just made it so that the results of the sql query were what was being put into the db. Yeah try that with the post vars.

And if that doesn't work try this. In my edit script I used this type of thing:

$myrow = mysql_fetch_array($result);

then used $myrow["columnname"] in the form to load the info in the db

Then I just used the name variable of the text fields in the actual sql query.

It would make your script look like this:

<html> 
<head><title> Saving News </title></head> 
<body bgcolor="#FFFFFF"> 

<?   

// get newsid from link 




/* declare some relevant variables */   

$DBhost = "localhost";   

$DBuser = "*******";   

$DBpass = "*******";   

$DBName = "pspnetw_pspdata";   

$table = "psp_news";   

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable toconnect to database");   

@mysql_select_db("$DBName") or die("Unable to select database $DBName");   

$sql = "SELECT * FROM psp_news";   

$result = mysql_query($sql);   

$myrow = mysql_fetch_array($result);


if($_POST["submit"]) {  

$sql = "UPDATE psp_news SET newstitle='" . $_POST["newstitle"] . "', summary='" . $_POST["summary"] . "', fullarticle='". $_POST["fullarticle"] . "' WHERE newsid='". $_GET["newsid"] . "'"; 
$result = mysql_query($sql);   

echo "News entered!";  

} else {  



?>    



<FORM METHOD=POST ACTION='<?php $PHP_SELF ?>'> 
<TABLE> 
<TR><TD> 
<INPUT TYPE='text' NAME='newstitle' VALUE='<?=$myrow["newstitle"]?>'><br><br> 
<TEXTAREA NAME='summary' ROWS=8 COLS=100><?=$myrow["summary"]?></text><br> 
<TEXTAREA NAME='fullarticle' ROWS=14 COLS=100><?=$myrow["fullarticle"]?></text><br> 

<p><INPUT TYPE='submit' name='submit' value='Submit News'></td></tr> 
</TABLE></FORM></body></html> 

<?php  

}  

?>

n00854180t

Have you tried it?

Kraft

Sorry about the late response. I had to run some errands and now I need to get on Xbox Live for my MotoGP2 league. I'll give it a try tonight though and let you know. I appreciate all the help n008!

n00854180t

XBox huh? Have you tried putting Linux on it yet? Hehe if I ever buy an XBox that will probably be 99% of what I use it for 😛 I am going home from work now so I will look at your reply tomorrow. Laters

Kraft

One xbox is a 'virgin' box so I can play Xbox Live, the other one is the one I tinker around with. I haven't put linux on it yet, as there hasn't been a need for me to (I already have one comp running on linux).

As far as the php file... it still hates me. It's doing the same thing as always: saying it updates but the cells dont change.

n00854180t

Post your current code. I think I am going to buy the PS2 linux kit eventually.