ImageCreateFromJPEG - AHHHH

[kingsol]

Greetings coders. Here is my problem. I know it lies within the ImageCreateFromJPEG function below. This script loops through a certain amount of uploads, creates a white 300x300 images, copies and resizes(scales) the uploaded image into the new 300x300 image, saves it, moves it, and deletes the temporary files. I have included the code below. I am getting these errors.

Warning: getimagesize: Unable to open 'Resource id #2' for reading. in... on line 261

Warning: imagecopyresampled(): supplied argument is not a valid Image resource... on line 287

		$files = $_FILES['pfiles'];
		for ($u=0; $u<$PostedUploads; $u++) {
			if (is_uploaded_file($files['tmp_name'][$u])) {
				//Save file to temporary location
				move_uploaded_file($files['tmp_name'][$u],"images/tmp-" . substr(strtoupper($files['name'][$u]),0,-4) . ".jpg");
				$ogfile=ImageCreateFromJPEG("images/tmp-" . substr(strtoupper($files['name'][$u]),0,-4) . ".jpg");
				$newfilename="images/" . substr(strtoupper($files['name'][$u]),0,-4) . ".jpg";
				//Create new file that is 300x300 with white background
				$newimage=ImageCreateTrueColor(300,300);
				$white = ImageColorAllocate($newimage, 255, 255, 255);
				ImageFill($newimage,0,0,$white);
				//Grab Orginals Dimensions
				$size=GetImageSize($ogfile);
				$ix=$size[0];
				$iy=$size[1];
				//Set Scale
				if($ix>$iy) {
					$scale=300/$ix;
				} else {
					$scale=300/$iy;
				};
				//Set cordinates on the new image
				$newx=round(((300-($scale*$ix))/2),0);
				$newy=round(((300-($scale*$iy))/2),0);
				$neww=round(($scale*$ix),0);
				$newh=round(($scale*$iy),0);

			//Display Info for debugging.
			$ErrMSG.="Name=" . $newfilename;
			$ErrMSG.="<br>Width=" . $ix;
			$ErrMSG.="<br>Height=" . $iy;
			$ErrMSG.="<br>Scale=" . $scale;
			$ErrMSG.="<br>New X=" . $newx;
			$ErrMSG.="<br>New Y=" . $newy;
			$ErrMSG.="<br>New W=" . $neww;
			$ErrMSG.="<br>New H=" . $newh;
			$ErrMSG.="<br>";
			//Copy the resize to new image and center it
			ImageCopyResampled($newimage,$temp_im,$newx,$newy,0,0,$neww,$newh,$ix,$iy);
			//Save new image in products folder delete temp image
			ImageJPEG($newimage,$newfilename,100);
			ImageDestroy($ogfile);
			copy($newfilename,"../ftimages/products/" . substr(strtoupper($files['name'][$u]),0,-4) . ".jpg");
			unlink($newfilename);			
			$ErrMSG.=$newfilename . " - Successful<br>";
		} else {
			$ErrMSG.=strtoupper($files['name'][$u]) . " - Failed<br>";
		};
	};

Any Help or suggestions would be wonderful. Thanks!

[Floodboy]

try with imagesx and imagesy instead of getimagesize and try imagecreate before imagecopyresampled let me show you a function that I have

function create_thumb($imagen){
	if(is_file($imagen)){
		$image=imagecreatefromjpeg($imagen);
		$ancho=imagesx($image);
		$alto=imagesy($image);
	}else{
		print "no se abrio el archivo";
	}
	$anp=$ancho/1000;
	$alp=$alto/1000;
	$an=$ancho;
	$al=$alto;
	if($ancho < $alto){
		while($al > 160){
			$al-=$alp;
			$an-=$anp;
		}
	}elseif($ancho > $alto){
		while($an > 120){
			$an-=$anp;
			$al-=$alp;
		}
	}
	$nuevoancho=ceil($an);
	$nuevoalto=ceil($al);
//	$tmp_img=imagecreatetruecolor($nuevoancho, $nuevoalto);// use this if your server has GD2
	$tmp_img=imagecreate($nuevoancho, $nuevoalto);// use this if your server doesn't have GD2
	imagecopyresized($tmp_img, $image, 0, 0, 0, 0, $nuevoancho, $nuevoalto, $ancho, $alto);
	imagedestroy($image);
	$image=$tmp_img;
	imagejpeg($image, "images/current_cam.jpg",70);
	imagedestroy($image);
}

some parts are in spanish but I hope this helps 🙂

[Jinks]

Ya, here's how i did mine as well.. Supports both JPEG and GIF formats. Also checks the uploaded files dimensions and resizes accordingly!

if (($image_size[1] >= $image_size[0]) && ($image_size[1] > 300)) {
  $new_h = 300;
  $new_w = ($new_h * $image_size[0])/$image_size[1];
}

if (($image_size[0] > $image_size[1]) && ($image_size[0] > 300)) {
  $new_w = 300;
  $new_h = ($new_w * $image_size[1])/$image_size[0];
}

$newfilename = $new_num.".".$new_type;
$movefile = copy($new_pic, "images/user_cars/$user[0]/$newfilename");

$new_file = "images/user_cars/$user[0]/$newfilename";

if ($image_size[2] == 1) {
  $dst_img=ImageCreate($new_w,$new_h); 
  $src_img=ImageCreateFromGIF($new_file); 
  ImageCopyResized($dst_img,$src_img,0,0,0,0,$new_w,$new_h,ImageSX($src_img),ImageSY($src_img)); 
  $newfilename1 = "images/user_cars/$user[0]/".$new_num."-th.".$new_type;
  ImageGIF($dst_img, $newfilename1);
}

if ($image_size[2] == 2) {
  $dst_img=ImageCreate($new_w,$new_h); 
  $src_img=ImageCreateFromJpeg($new_file); 
  ImageCopyResized($dst_img,$src_img,0,0,0,0,$new_w,$new_h,ImageSX($src_img),ImageSY($src_img)); 
  $newfilename1 = "images/user_cars/$user[0]/".$new_num."-th.".$new_type;
  ImageJpeg($dst_img, $newfilename1);
}

[kingsol]

Is there any reason my ImageCreateFromJPEG wouldn't work?? from what you can see from my code in the intial post?

I'm drownding here...

thanks!

[Jinks]

which line is line 261 on there.

[kingsol]

Sorry.... I should have been more specific. Line 261 is the ImageCreateFromJPEG. If I set $ogfile equal to a path the file, all the functions work except ImageCopyResampled which bombs, becase the $ogfile wasn't "opened" for use. (to be specific it says invalid arguement). So I try and set $ogfile to be opened and a new image (ImageCreateFromJPEG) and it bombs. I know that GD works and JPEGS Work and ImageCreateFromJPEG work because I use them other areas on the site.

HELP!! THanks.