Unexpected error

KelteN

Hi,

I'm writting a little user system for fun and as I was scripting I ran into this problem:

Parse error: parse error, unexpected '\"' in /home/username/public_html/php/register.php on line 27

Here is the code on line 27:

mysql_query("INSERT INTO users (`ID`, `User`, `Pass`) VALUES("", $_POST['username'], md5($_POST['password']))") or die("Failed to execute query.");

Can anyone figure it out? Thanks 🙂

planetsim

Change it from this

mysql_query("INSERT INTO users (`ID`, `User`, `Pass`) VALUES("", $_POST['username'], md5($_POST['password']))") or die("Failed to execute query.");

to this

mysql_query("INSERT INTO users (ID, User, Pass) VALUES('', $_POST['username'], md5($_POST['password']))") or die("Failed to execute query.");

But i dont think thats where there error is, if it ws it would have echoed out

Faild to execute the query.

You may need to post a couple of lines above this if its not the error.

KelteN

Hmmm... well that fixed it! Thanks! But now the query is failing. Here is the whole script:

<!doctype html public "-//W3C//DTD HTML 4.0 //EN">
<html>
<head>
       <title>Registration</title>
<?php
//Database Information
$user = "db_user";
$pass = "pass";
$db = "db_name";
$host = "localhost";
?>
</head>
<body>
<?php
if(isset($_POST['username']) && isset($_POST['password'])){
    if($_POST['username'] == ""){
        die("You need to go back and choose and username.");
    }
    if($_POST['password'] == ""){
        die("You need to go back and choose a password.");
    }
    //Make connection to database
    $conn = @mysql_connect($host, $user, $pass);
    if(!$conn){
        die("Failed to connect to database.");
    }
    //Select database
    $sdb = @mysql_select_db($db);
    if(!$sdb){
        die("Failed to select correct database.");
    }
    //Query registration
    mysql_query("INSERT INTO users (ID, User, Pass) VALUES('', $_POST['username'], md5($_POST['password']))") or die("Failed to execute query.");
    echo "Your account has been created. Click <a href='login.php' alt='Proceed to login'>HERE</a> to proceed.";
} else {
?>
<h2>Registration Form:</h2><br>
<form action="register.php" method="post">
Desired username: <input type="text" name="username" width="50" maxlength="16"><br>
Desired password: <input type="password" name="password" width="50" maxlength="16"><br>
<input type="submit" name="submit" value="Submit Registration">
</form>
<?php
}
?>
</body>
</html>

ahundiak

Is id an autoincremented integer? If so, use

"INSERT INTO users (User, Pass) VALUES($POST['username'], md5($POST['password']))"

The system will fill in the id automatically.

And add mysql_error() to your die argument, the system will give you some sort of hint on where the statement is failing.

KelteN

Ok I did that. Here's the new line:

mysql_query("INSERT INTO users (User, Pass) VALUES($_POST['username'], md5($_POST['password']))") or die("Failed to execute query." . mysql_error() . "");

Here's the error:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ' md5())' at line 1

ahundiak

Ok. php is not going to execute functions inside of strings.

$password = md5($POST['password']);
$username = $POST['username'];

"INSERT INTO users (User, Pass) VALUES($username,$password)"

KelteN

Ok, well it seemed to work. Now I have yet another error.(Don't you just love debugging 😛):

Unknown column 'test' in 'field list'

test is the username I tryed to register. I think it may be due to my db. Not sure though :\

ahundiak

Sure do. And I'm really missing stuff tonight. Anyways, you need to surround your data with single quotes.
"INSERT INTO users (User, Pass) VALUES('$username','$password')"

KelteN

Ahh worked! Thanks for the help 😃