file uploading and moving

unclecurio

I'm trying to create a news submission script which will allow an image to be uploaded to accompany the news item. I have the form set up ok but then things get sticky...

When I move to the sub.php file which actions the form, I entered a line to echo the file name using $userfile_name where the form field was called "userfile". This returns nothing (although other lines demonstrate that the script runs fine). It seems that it is not setting up the name size etc values. Does anyone have any suggestions?

Also, should I be using relative file paths or absolute ones when I come to move files? my current script moves the file to "../images/uploads"

larand

I would suggest trying to access the image attributes by means of the GLOBAL $_FILES variable. Like this:

echo $_FILES['userfile']['type'];
 // Echo the File Type
echo $_FILES['userfile']['size'];
 // Echo the file Size

 // You get the Picture....

I always use that method and it never fails me.

Also, ensure that you have included this attribute in the FORM tag declaration:

enctype="multipart/form-data"

Its indipensable when you find yourself sending Binary data.

unclecurio

Thanks - that's let me show the file name so I know it's been taken on. However, I'm still completely unable to place the file in the chosen directory. The code I'm using is:

if ($userfile) {echo "$userfile_name uploaded succesfully<br>";
if (copy($userfile, "../../images/news/".$userfile_name)){echo "file copy successfull<br>";}}
else {echo "file upload failed";}

can you see anything obviously wrong?

stolzyboy

what happens, nothing, errors, is register_globals = On, or Off?

unclecurio

Output is thus:

H:\RUGBYAID\IMAGES\SITE\gavin_hastings.jpg uploaded succesfully

Warning: Unable to open 'H:\RUGBYAID\IMAGES\SITE\gavin_hastings.jpg' for reading: No such file or directory in /home/.sites/14/sitex/web/xxxxxxxxx/cgi-bin/upload2.php on line 4

I can't confirm if register globals is on or not right now but I'll check with the hosts

Thanks

stolzyboy

just put up a php page like

<? phpinfo(); ?>

then scroll down there will be register_globals on that page which tells you whether it is off or on

unclecurio

seems to be on...

Also, I've checked to make sure the directories can be written to by the public.

drag0n

Can you check if the image is really uploaded to the directory? And what permissions is on the directory?

unclecurio

The permission is 2747 and the directory remains empty (I set it up to test the uploading thing).

Thanks

drag0n

ahh so the file isnt getting in but it says it is, I think I know the problem, chmod the permission of the folder to 777 and if it is possible, paste the upload part of your code.

unclecurio

Did the CHMOD and tried again - no luck yet.

The file is uploaded from a form as follows:

The code posted previously is the upload script in it's entirety.

Thanks

drag0n

if ($userfile) {echo "$userfile_name uploaded succesfully<br>";
if (copy($userfile, "../../images/news/".$userfile_name)){echo "file copy successfull<br>";}}
else {echo "file upload failed";}

Thats ur code? Everything?

unclecurio

...starting to get the feeling I may have missed something fairly fundamental here...

yeah that's it

drag0n

Nothing else? You dont have $userfile variable set? You didnt have closing curlies on your first if statement:

if ($userfile) {echo "$userfile_name uploaded succesfully<br>";

should be

if ($userfile) {echo "$userfile_name uploaded succesfully<br>"};

The big problem is that @userfile isnt set before... meaning the code doesnt know what happens or what is $userfile...
I really dont understand your code, maybe Im too rusty, I dont know...

unclecurio

Ah, ok - the curlies are closed later on. The following IF is part of the same section as the "uploaded successfully" bit.

My understanding (limited I admit) was that PHP creates $userfile, $userfile_name, $userfile_size automatically when it recieves the form data (note the file input is called userfile).

have I go the wrong end of the stick here?

drag0n

Im a bit rusty from php, but my understanding is that it doesnt create those variables $_FILE and the thing is... you have to define the variables the submission form sends to... so that when the action page which you have ur code on to answer and process those variables

You might want to check out
http://us3.php.net/manual/en/function.move-uploaded-file.php?PHPSESSID=8e82e8aa7812ad7c4dd0888de60b2b6f

unclecurio

So I would have to seperately establish that $userfile = $_FILE in my processing script? I'm getting a little misty on how PHP manages the actual file data.

All other form data is created as $xyz automatically when subbed but am I right in thinking that uploads are handled differently -ie the values aren't created from the field name?

Sorry if I'm being thick here! :rolleyes:

-Edit-
Thanks for the link - I'll check it out tomorrow. Hopefully that's it and I'm just using bizarro code to do something that's much simpler!
-/Edit-

drag0n

What are you trying to do with those 2 it statements? Your not giving them contriants...

unclecurio

The first should confirm that the uploaded file exists and has been passed to the script and the second should be the copy bit.

drag0n

theres ur problem then , holdon letme fix it