[Resolved] problem with If statement

genom

I'll start by saying i'm probably just being really blind to a minor error here. Could someone either spot my error or tell me if there is an easier way to do this check.

I'm playing with a form that when submitted will check to see if 'name' exists already in the database, if it does it executes one piece of code and if it doesn't exist it inserts it into the database.

The bits of code are irrelevant as I they work perfectly fine on thier own, it's just when it checks if the name exists already it pulls up the warning, but if it doesn't exist it seems to be skipping my else chunk.

// connecting
include("db.php");

// checking for existing
   $sql = "SELECT name FROM herbal WHERE name=\"$name\"";
   $result = mysql_query($sql);
   if ($result != false) {
     while($data = mysql_fetch_assoc($result)){
       echo $data['name'];
       if ($data['name'] == "$name") {
         echo "<br>its $name. Warning this exists already";
       }
       else {
         // can't seem to get this executed for some reason
         echo "<br>It's not there stick it in the database.";
         }
     }
   }
   else {
     echo mysql_error();
   }

Additional info if required, usign PHP 4.3.1.1 and MYSQL 3.23.38 on Apache 1.3.14 under windows XP pro (I think)

kevinsequeira

try changing this

if ($result != false) to if (!mysql_error())

and if ($data['name'] == "$name") { to if ($data['name'] == $name) {

any change ??

reg
kevin

genom

nope still works exactly the same, if I use an existing name it says so, but if it's not it's still skipping the else statement.

dbchip2000

I would code it like:

include("db.php");
$result=mysql_query("SELECT name FROM herbal WHERE name=\"".$name."\" LIMIT 0,1");
if (mysql_num_rows($result)==0) {
     mysql_query("INSERT INTO herbal(name) VALUES(\"".$name\"")");
     echo("<br>Added");
} else {
     echo("<br>The record already exists.");
}

One thing to be aware of is what if the user inputs something with a double quote in it. You can use some of PHP's functions like strip_slashes($name).

genom

That works, thank you.

I'm presuming it must have had something to do with it being in the while loop. My php coding isn't too bad, but I've been having horrendous problems trying to add in the MSYQL stuff.

I'm aware of the qoute problem with the queries, but as I'ts just me addign entries for the moment, I can afford to add more error checks at a later date, this is just the first of many I need to do 🙂